Skip to contentSkip to conversation

MIPS atomic operations, "sync"

DISCUSSION Mathieu Desnoyers 2 participants 3 messages Nov 10, 2006 – Nov 11, 2006

lore
Share & tools
lore
#0 lore raw

Hi,

I am currently creating a "LOCK" prefix free and memory barrier free version of atomic.h to fulfill my tracer (LTTng) needs, which is to atomically update per-cpu data and have a minimal performance loss.

I just came across the MIPS atomic.h and system.h implementations in 2.6.18 which brings a question :

Why are the primitives in include/asm-mips/atomic.h using the "sync" instruction even in the UP case ? system.h cmpxchg only uses the sync in the SMP case.

Mathieu

OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68 
#1 lore raw
Quoted 10 lines · Mathieu Desnoyers

I am currently creating a "LOCK" prefix free and memory barrier free version of atomic.h to fulfill my tracer (LTTng) needs, which is to atomically update per-cpu data and have a minimal performance loss.

I just came across the MIPS atomic.h and system.h implementations in 2.6.18 which brings a question :

Why are the primitives in include/asm-mips/atomic.h using the "sync" instruction even in the UP case ? system.h cmpxchg only uses the sync in the SMP case.

Why are the standard atomic operations insufficient for your needs?

There is an enormous amout of subtilities in those atomic ops for some architectures you probably do yourself a big favor by avoiding new variants.

Ralf

#2 lore raw
Quoted 13 lines · * Ralf Baechle ([email protected]) wrote:
Quoted 10 lines · Mathieu Desnoyers

I am currently creating a "LOCK" prefix free and memory barrier free version of atomic.h to fulfill my tracer (LTTng) needs, which is to atomically update per-cpu data and have a minimal performance loss.

I just came across the MIPS atomic.h and system.h implementations in 2.6.18 which brings a question :

Why are the primitives in include/asm-mips/atomic.h using the "sync" instruction even in the UP case ? system.h cmpxchg only uses the sync in the SMP case.

Quoted 6 lines

Why are the standard atomic operations insufficient for your needs?

There is an enormous amout of subtilities in those atomic ops for some architectures you probably do yourself a big favor by avoiding new variants.

Performance cost.

I add a memory barrier where needed when the data needs to appear to be written sequentially from the other CPUs perspective.

Mathieu

OpenPGP public key:              http://krystal.dyndns.org:8080/key/compudj.gpg
Key fingerprint:     8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68