Skip to contentSkip to conversation

drivers/ide: stray bracket

PATCH In review Nicolas Kaiser 2 participants 3 messages Nov 11, 2006 libata

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers/ide: stray bracket

Stray bracket in debug code.

---

 drivers/ide/legacy/hd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ide/legacy/hd.c +1 -1
diff -uprN a/drivers/ide/legacy/hd.c b/drivers/ide/legacy/hd.c
@@ -459,7 +459,7 @@ ok_to_read:
 #ifdef DEBUG
 	printk("%s: read: sector %ld, remaining = %ld, buffer=%p\n",
 		req->rq_disk->disk_name, req->sector, req->nr_sectors,
-		req->buffer+512));
+		req->buffer+512);
 #endif
 	if (req->current_nr_sectors <= 0)
 		end_request(req, 1);
#1 lore raw

drivers/ide/legacy/hd.c ok_to_read: · line 463

Quoted 11 lines · Nicolas Kaiser

Stray bracket in debug code.

drivers/ide/legacy/hd.c +1 -1
@@ -459,7 +459,7 @@ ok_to_read:
 #ifdef DEBUG
 	printk("%s: read: sector %ld, remaining = %ld, buffer=%p\n",
 		req->rq_disk->disk_name, req->sector, req->nr_sectors,
-		req->buffer+512));
+		req->buffer+512);
 #endif

Just remove whole printk. It was broken for a looong time.

#2 lore raw

* Alexey Dobriyan <[email protected]>:

Quoted 4 lines · Nicolas Kaiser
Quoted 1 line

Stray bracket in debug code.

Just remove whole printk. It was broken for a looong time.

If you prefer it that way, here we go:
Remove debug code that was broken for long time.

---

 drivers/ide/legacy/hd.c |    5 -----
 1 file changed, 5 deletions(-)
drivers/ide/legacy/hd.c +0 -5
diff -uprN a/drivers/ide/legacy/hd.c b/drivers/ide/legacy/hd.c
@@ -456,11 +456,6 @@ ok_to_read:
 	req->errors = 0;
 	i = --req->nr_sectors;
 	--req->current_nr_sectors;
-#ifdef DEBUG
-	printk("%s: read: sector %ld, remaining = %ld, buffer=%p\n",
-		req->rq_disk->disk_name, req->sector, req->nr_sectors,
-		req->buffer+512));
-#endif
 	if (req->current_nr_sectors <= 0)
 		end_request(req, 1);
 	if (i > 0) {