Skip to contentSkip to conversation

atkbd: disable spurious ACK/NAK warning on panic

PATCH In review Luca Tettamanti 2 participants 3 messages Nov 13, 2006 Input drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 atkbd: disable spurious ACK/NAK warning on panic

After the panic() message has been printed kernel may blink keyboard leds to signal the abnormal condition.
atkbd warns that "Some program might be trying access hardware directly" at every blink, scrolling the useful text out of the screen. Avoid printing the warning when oops_in_progress is set in order to preserve the panic message.

---
Patch against current GIT tree.

 drivers/input/keyboard/atkbd.c |    2 ++
 1 file changed, 2 insertions(+)
drivers/input/keyboard/atkbd.c +2 -0
index cbb9366..81d2701 100644
@@ -412,6 +412,8 @@ static irqreturn_t atkbd_interrupt(struc
 			goto out;
 		case ATKBD_RET_ACK:
 		case ATKBD_RET_NAK:
+			if (oops_in_progress)
+				goto out;
 			printk(KERN_WARNING "atkbd.c: Spurious %s on %s. "
 			       "Some program might be trying access hardware directly.\n",
 			       data == ATKBD_RET_ACK ? "ACK" : "NAK", serio->phys);

Luca

Signature · 2 lines
"In linea di principio sarei indifferente al natale, se solo il natale
 ricambiasse la cortesia e mi lasciasse in pace." -- Marco d'Itri
maintainer
#1 lore raw
Quoted 7 lines · Luca Tettamanti

After the panic() message has been printed kernel may blink keyboard leds to signal the abnormal condition.
atkbd warns that "Some program might be trying access hardware directly" at every blink, scrolling the useful text out of the screen. Avoid printing the warning when oops_in_progress is set in order to preserve the panic message.

Hi Luca,

Current input git tree already has code in i8042 supressing extra ACKs caused by palic blinks; as soon as Linus pulls from me you should not see these messages anymore.

Signature · 1 line
Dmitry
#2 lore raw

On 11/13/06, Dmitry Torokhov <[email protected]> wrote:
Hi,

Quoted 11 lines · Luca Tettamanti
Quoted 6 lines

After the panic() message has been printed kernel may blink keyboard leds to signal the abnormal condition.
atkbd warns that "Some program might be trying access hardware directly" at every blink, scrolling the useful text out of the screen. Avoid printing the warning when oops_in_progress is set in order to preserve the panic message.

Current input git tree already has code in i8042 suppressing extra ACKs caused by panic blinks; as soon as Linus pulls from me you should not see these messages anymore.

Great, thanks.

Luca