Skip to contentSkip to conversation

make menuconfig regression in 2.6.19-rc

DISCUSSION Phil Oester 3 participants 5 messages Nov 14, 2006 – Nov 21, 2006 Kconfig

lore
Share & tools
lore
#0 lore raw

In commit 350b5b76384e77bcc58217f00455fdbec5cac594, the default menuconfig color scheme was changed to bluetitle. This breaks the highlighting of the selected item for me with TERM=vt100. The only way I can see which item is selected is via:

make MENUCONFIG_COLOR=mono menuconfig

Which restores the pre-2.6.19 white on black highlighting.

Sam?

Phil

#1 lore raw

Hallo.

Quoted 8 lines · Phil Oester

In commit 350b5b76384e77bcc58217f00455fdbec5cac594, the default menuconfig color scheme was changed to bluetitle. This breaks the highlighting of the selected item for me with TERM=vt100. The only way I can see which item is selected is via:

make MENUCONFIG_COLOR=mono menuconfig

Which restores the pre-2.6.19 white on black highlighting.

Classic theme also doesn't work, and this commit doesn't look like changing anything in it.

Thus, i think, just export variable with working theme (mono) on your exotic setup.

Quoted 1 line

Sam?

If you want answer from busy developers, try to add their e-mail next time.

Quoted 1 line

Phil

____

#2 lore raw
Quoted 8 lines · Oleg Verych
Quoted 7 lines · Phil Oester

In commit 350b5b76384e77bcc58217f00455fdbec5cac594, the default menuconfig color scheme was changed to bluetitle. This breaks the highlighting of the selected item for me with TERM=vt100. The only way I can see which item is selected is via:

make MENUCONFIG_COLOR=mono menuconfig

Quoted 7 lines
Quoted 1 line

Which restores the pre-2.6.19 white on black highlighting.

Classic theme also doesn't work, and this commit doesn't look like changing anything in it.

Thus, i think, just export variable with working theme (mono) on your exotic setup.

Hmm...vt100 is exotic? If only you'd told me that 20 years ago ;-)

Quoted 4 lines
Quoted 1 line

Sam?

If you want answer from busy developers, try to add their e-mail next time.

Thanks for the tip.

Phil

#3 lore raw
In reply to Phil Oester

Hi,

Quoted 8 lines · Phil Oester

In commit 350b5b76384e77bcc58217f00455fdbec5cac594, the default menuconfig color scheme was changed to bluetitle. This breaks the highlighting of the selected item for me with TERM=vt100. The only way I can see which item is selected is via:

make MENUCONFIG_COLOR=mono menuconfig

Which restores the pre-2.6.19 white on black highlighting.

Could you try the patch below?

bye, Roman

---
 scripts/kconfig/lxdialog/util.c |   16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)
scripts/kconfig/lxdialog/util.c +7 -9
Index: linux-2.6-mm/scripts/kconfig/lxdialog/util.c
===================================================================
@@ -221,16 +221,14 @@ static void init_dialog_colors(void)
  */
 static void color_setup(const char *theme)
 {
-	if (set_theme(theme)) {
-		if (has_colors()) {	/* Terminal supports color? */
-			start_color();
-			init_dialog_colors();
-		}
-	}
-	else
-	{
+	int use_color;
+
+	use_color = set_theme(theme);
+	if (use_color && has_colors()) {
+		start_color();
+		init_dialog_colors();
+	} else
 		set_mono_theme();
-	}
 }
 
 /*
#4 lore raw
Quoted 3 lines · Roman Zippel

Could you try the patch below?

bye, Roman

Yes, that restores the menu highlighting. Thanks Roman.

Phil