Skip to contentSkip to conversation

Fix of floppy disk configuration check

PATCH Applied Kasai Takanori 2 participants 2 messages Nov 16, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix of floppy disk configuration check

Hi all,

We were testing on VTx domain.
The error occurs as follows if the floppy disk is specified.

config should like:
fda = '/dev/sdb'

# xm create -f test.conf
Error: Floppy file /dev/sdb does not exist.
                  ^^^^^^^^
                  => USB Floppy device

I think that it is problem in the interpretation part of the floppy disk definition. This patch fixes it.

Best regards,
Takanori Kasai

# HG changeset patch
# User [email protected]
# Node ID b3e4d6c6cf4e3ae251f8108b4805bda581976b3b # Parent 6e22ba7217201f3c3d7219d824f7aa80cd431c36 Fix of floppy disk configuration check

tools/python/xen/xend/image.py +1 -1
diff -r 6e22ba721720 -r b3e4d6c6cf4e tools/python/xen/xend/image.py
@@ -328,7 +328,7 @@ class HVMImageHandler(ImageHandler):
 
             if a in ['fda', 'fdb' ]:
                 if v:
-                    if not os.path.isfile(v):
+                    if not os.path.isabs(v):
                         raise VmError("Floppy file %s does not exist." % v)
             log.debug("args: %s, val: %s" % (a,v))
 

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

Applied
#1 lore raw
Quoted 14 lines · Kasai Takanori

Hi all,

We were testing on VTx domain.
The error occurs as follows if the floppy disk is specified.

config should like:
fda = '/dev/sdb'

# xm create -f test.conf
Error: Floppy file /dev/sdb does not exist.
                  ^^^^^^^^
                  => USB Floppy device
Quoted 3 lines

I think that it is problem in the interpretation part of the floppy disk definition.
This patch fixes it.

Applied, thank you.

Ewan.