Skip to contentSkip to conversation

: Use kmemdup in net/ipv4/devinet.c

PATCH In review Arnaldo Carvalho de Melo 1 participant 1 message Nov 17, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 4/10 : Use kmemdup in net/ipv4/devinet.c

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/devinet.o.before /tmp/devinet.o.after /pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/devinet.c:
devinet_sysctl_register | -38
1 function changed, 38 bytes removed
[acme@newtoy net-2.6.20]$

---
 net/ipv4/devinet.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
net/ipv4/devinet.c +2 -2
index a1b356c..2fd8991 100644
@@ -1564,12 +1564,12 @@ static void devinet_sysctl_register(stru
 {
 	int i;
 	struct net_device *dev = in_dev ? in_dev->dev : NULL;
-	struct devinet_sysctl_table *t = kmalloc(sizeof(*t), GFP_KERNEL);
+	struct devinet_sysctl_table *t = kmemdup(&devinet_sysctl, sizeof(*t),
+						 GFP_KERNEL);
 	char *dev_name = NULL;
 
 	if (!t)
 		return;
-	memcpy(t, &devinet_sysctl, sizeof(*t));
 	for (i = 0; i < ARRAY_SIZE(t->devinet_vars) - 1; i++) {
 		t->devinet_vars[i].data += (char *)p - (char *)&ipv4_devconf;
 		t->devinet_vars[i].de = NULL;
Signature · 1 line
1.4.2.1.g3d5c