Skip to contentSkip to conversation

: Use kmemdup

PATCH In review Arnaldo Carvalho de Melo 1 participant 1 message Nov 17, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 8/10 : Use kmemdup

Code diff stats:

[acme@newtoy net-2.6.20]$ codiff /tmp/decnet.ko.before /tmp/decnet.ko.after /pub/scm/linux/kernel/git/acme/net-2.6.20/net/decnet/dn_dev.c:
dn_dev_sysctl_register | -51
1 function changed, 51 bytes removed
[acme@newtoy net-2.6.20]$

---
 net/decnet/dn_dev.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
net/decnet/dn_dev.c +1 -3
index 01861fe..5b451e1 100644
@@ -255,12 +255,10 @@ static void dn_dev_sysctl_register(struc
 	struct dn_dev_sysctl_table *t;
 	int i;
 
-	t = kmalloc(sizeof(*t), GFP_KERNEL);
+	t = kmemdup(&dn_dev_sysctl, sizeof(*t), GFP_KERNEL);
 	if (t == NULL)
 		return;
 
-	memcpy(t, &dn_dev_sysctl, sizeof(*t));
-
 	for(i = 0; i < ARRAY_SIZE(t->dn_dev_vars) - 1; i++) {
 		long offset = (long)t->dn_dev_vars[i].data;
 		t->dn_dev_vars[i].data = ((char *)parms) + offset;
Signature · 1 line
1.4.2.1.g3d5c