make sound/core/control.c:snd_ctl_new() static
Subsystems (2)
RFC PATCH 1/1 make sound/core/control.c:snd_ctl_new() static
Now that everyone uses snd_ctl_new1() and noone is using snd_ctl_new() anymore, we can make it static.
---
Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl | 10 ---------- include/sound/control.h | 1 - sound/core/control.c | 5 ++--- 3 files changed, 2 insertions(+), 14 deletions(-)
Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl renamed from Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl.old +0 -10
@@ -3691,16 +3691,6 @@ </para> <para> - Here, the chip instance is retrieved via - <function>snd_kcontrol_chip()</function> macro. This macro - just accesses to kcontrol->private_data. The - kcontrol->private_data field is - given as the argument of <function>snd_ctl_new()</function> - (see the later subsection - <link linkend="control-interface-constructor"><citetitle>Constructor</citetitle></link>). - </para> - - <para> The <structfield>value</structfield> field is depending on the type of control as well as on info callback. For example, the sb driver uses this field to store the register offset,
include/sound/control.h renamed from include/sound/control.h.old +0 -1
@@ -108,7 +108,6 @@void snd_ctl_notify (struct snd_card * card,unsigned int mask,struct snd_ctl_elem_id * id); -struct snd_kcontrol *snd_ctl_new (struct snd_kcontrol * kcontrol,unsigned int access);struct snd_kcontrol *snd_ctl_new1 (const struct snd_kcontrol_new * kcontrolnew,void * private_data);void snd_ctl_free_one (struct snd_kcontrol * kcontrol);int snd_ctl_add (struct snd_card * card,struct snd_kcontrol * kcontrol);
sound/core/control.c renamed from sound/core/control.c.old +2 -3
@@ -183,7 +183,8 @@* * Returns the pointer of the new instance, or NULL on failure. */ -struct snd_kcontrol *snd_ctl_new (struct snd_kcontrol *control,unsigned int access) +static struct snd_kcontrol *snd_ctl_new (struct snd_kcontrol *control, +unsigned int access) {struct snd_kcontrol *kctl;unsigned int idx;
@@ -201,8 +202,6 @@return kctl; } -EXPORT_SYMBOL (snd_ctl_new); -/** * snd_ctl_new1 - create a control instance from the template * @ncontrol: the initialization record
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
At Fri, 17 Nov 2006 18:02:26 +0100,
Quoted 5 lines · Adrian Bunk
Now that everyone uses
snd_ctl_new1()and noone is usingsnd_ctl_new()anymore, we can make it static.Signed-off-by Adrian Bunk <[email protected]>
This makes sense. I merged it to ALSA tree.
Thanks.
Takashi
Quoted 61 lines
---
Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl | 10 ---------- include/sound/control.h | 1 - sound/core/control.c | 5 ++--- 3 files changed, 2 insertions(+), 14 deletions(-)Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl renamed from Documentation/sound/alsa/DocBook/writing-an-alsa-driver.tmpl.old +0
-10@@ -3691,16 +3691,6 @@ </para> <para> - Here, the chip instance is retrieved via - <function>snd_kcontrol_chip()</function> macro. This macro - just accesses to kcontrol->private_data. The - kcontrol->private_data field is - given as the argument of <function>snd_ctl_new()</function> - (see the later subsection - <link linkend="control-interface-constructor"><citetitle>Constructor</citetitle></link>). - </para> - - <para> The <structfield>value</structfield> field is depending on the type of control as well as on info callback. For example, the sb driver uses this field to store the register offset,include/sound/control.h renamed from include/sound/control.h.old +0
-1@@ -108,7 +108,6 @@void snd_ctl_notify (struct snd_card * card,unsigned int mask,struct snd_ctl_elem_id * id); -struct snd_kcontrol *snd_ctl_new (struct snd_kcontrol * kcontrol,unsigned int access);struct snd_kcontrol *snd_ctl_new1 (const struct snd_kcontrol_new * kcontrolnew,void * private_data);void snd_ctl_free_one (struct snd_kcontrol * kcontrol);int snd_ctl_add (struct snd_card * card,struct snd_kcontrol * kcontrol);sound/core/control.c renamed from sound/core/control.c.old +2
-4@@ -183,7 +183,8 @@* * Returns the pointer of the new instance, or NULL on failure. */ -struct snd_kcontrol *snd_ctl_new (struct snd_kcontrol *control,unsigned int access) +static struct snd_kcontrol *snd_ctl_new (struct snd_kcontrol *control, +unsigned int access) {struct snd_kcontrol *kctl;unsigned int idx;@@ -201,8 +202,6 @@return kctl; } -EXPORT_SYMBOL (snd_ctl_new); -/** * snd_ctl_new1 - create a control instance from the template * @ncontrol: the initialization record -------------------------------------------------------------------------
Quoted 9 lines
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Alsa-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/alsa-devel
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV