Skip to contentSkip to conversation

I2O: handle __copy_from_user

PATCH New Randy Dunlap 1 participant 1 message Nov 18, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 I2O: handle __copy_from_user

From: Randy Dunlap <[email protected]>

Handle __copy_from_user() return value.

Noticed by inspection, not from build warning.

---
 drivers/message/i2o/i2o_config.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/message/i2o/i2o_config.c +5 -1
@@ -265,7 +265,11 @@ static int i2o_cfg_swdl(unsigned long ar
 		return -ENOMEM;
 	}
 
-	__copy_from_user(buffer.virt, kxfer.buf, fragsize);
+	if (__copy_from_user(buffer.virt, kxfer.buf, fragsize)) {
+		i2o_msg_nop(c, msg);
+		i2o_dma_free(&c->pdev->dev, &buffer);
+		return -EFAULT;
+	}
 
 	msg->u.head[0] = cpu_to_le32(NINE_WORD_MSG_SIZE | SGL_OFFSET_7);
 	msg->u.head[1] =

---