Skip to contentSkip to conversation

: Sub-policies broke policy events

PATCH Applied jamal 3 participants 3 messages Nov 17, 2006 – Nov 19, 2006

Subsystems (3)
lore
Share & tools
lore

jamal

author
#0 lore raw

PATCH 1/1 : Sub-policies broke policy events

Found the cause of my problems.
Dave, this is against Linus tree because it is bug fix.

Nakamura-san please ACK.

cheers,
jamal

[XFRM]: Sub-policies broke policy events
XFRM policy events are broken when sub-policy feature is turned on. A simple test to verify this:
run ip xfrm mon on one window and add then delete a policy on another window ..

---
commit b53ec68c276ac1d879759de130620a72254cb969
tree b91ed5cf9090478bc49bd7414be6dd295352ff2b
parent 1b9bb3c14c60324b54645ffefbe6d270f9fd191c
author Jamal Hadi Salim <[email protected]> Fri, 17 Nov 2006 08:13:16 -0500 committer Jamal Hadi Salim <hadi@jzny2.(none)> Fri, 17 Nov 2006 08:13:16 -0500

 net/xfrm/xfrm_user.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
net/xfrm/xfrm_user.c +3 -0
index b43e764..2dae1c1 100644
@@ -2060,6 +2060,9 @@ static int xfrm_notify_policy(struct xfr
 		len += RTA_SPACE(headlen);
 		headlen = sizeof(*id);
 	}
+#ifdef CONFIG_XFRM_SUB_POLICY
+	len += RTA_SPACE(sizeof(struct xfrm_userpolicy_type));
+#endif
 	len += NLMSG_SPACE(headlen);
 
 	skb = alloc_skb(len, GFP_ATOMIC);
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · On Fri, 17 Nov 2006 08:34:44 -0500 jamal <[email protected]> wrote:

Found the cause of my problems.
Dave, this is against Linus tree because it is bug fix.

Nakamura-san please ACK.

cheers,
jamal

It looks fine to me. Thanks, Jamal.

Quoted 9 lines

[XFRM]: Sub-policies broke policy events
XFRM policy events are broken when sub-policy feature is turned on. A simple test to verify this:
run ip xfrm mon on one window and add then delete a policy on another window ..

---

Signature · 1 line
Masahide NAKAMURA
maintainer Applied
#2 lore raw

From: Masahide NAKAMURA <[email protected]>
Date: Sat, 18 Nov 2006 17:51:59 +0900

Quoted 9 lines
Quoted 6 lines · On Fri, 17 Nov 2006 08:34:44 -0500 jamal <[email protected]> wrote:

Found the cause of my problems.
Dave, this is against Linus tree because it is bug fix.

Nakamura-san please ACK.

Quoted 7 lines
Quoted 2 lines

cheers,
jamal

It looks fine to me. Thanks, Jamal.

Applied, thanks everyone.