Skip to contentSkip to conversation

Siemens SX1: sound cleanups

PATCH Pavel Machek 5 participants 10 messages Nov 19, 2006 – Nov 24, 2006 Sound

lore
Share & tools
lore
#0 lore raw

Hi!

These are cleanups for codingstyle in sound parts of siemens sx1. They should not change any code. Please apply,

Pavel

sound/arm/omap/omap-alsa-sx1-mixer.c +65 -85
index 8ca4c95..b036b3b 100644
@@ -29,41 +29,34 @@ #define M_DPRINTK(ARGS...)  		/* nop */
 
 static int current_playback_target	= PLAYBACK_TARGET_LOUDSPEAKER;
 static int current_rec_src 		= REC_SRC_SINGLE_ENDED_MICIN_HED;
-static int current_volume 		= 0;	//current volume, we cant read it
-static int current_fm_volume 		= 0;	//current FM radio volume, we cant read it
+static int current_volume 		= 0;	/* current volume, we cant read it */
+static int current_fm_volume 		= 0;	/* current FM radio volume, we cant read it */
 
-/* TODO
- * For selecting SX1 recourd source.
+/* 
+ * Select SX1 recording source.
  */
 static void set_record_source(int val)
 {
-	// TODO	Recording is done on McBSP2	and Mic only
+	/* TODO Recording is done on McBSP2 and Mic only */
 	current_rec_src	= val;
 }
 
-/*
- * Converts the Alsa mixer volume (0 - 100) to SX1
- * (0 - 9) volume.
- */
-int set_mixer_volume(int mixerVol)
+int set_mixer_volume(int mixer_vol)
 {
-	int retVal;
+	/* FIXME: Alsa has mixer_vol in 0-100 range, while SX1 needs 0-9 range */
 
-	if ((mixerVol < 0) ||
-	    (mixerVol > 9) ){
-		printk(KERN_ERR "Trying a bad mixer volume (%d)!\n", mixerVol);
+	if ((mixer_vol < 0) || (mixer_vol > 9)) {
+		printk(KERN_ERR "Trying a bad mixer volume (%d)!\n", mixer_vol);
 		return -EPERM;
 	}
-	current_volume = mixerVol;	// set current volume, we cant read it
-	M_DPRINTK("mixer volume = %d\n", mixerVol);
+	current_volume = mixer_vol;	/* set current volume, we cant read it */
 
-	retVal	= cn_sx1snd_send(DAC_VOLUME_UPDATE, mixerVol, 0 );
-	return retVal;
+	return cn_sx1snd_send(DAC_VOLUME_UPDATE, mixer_vol, 0);
 }
 
 void set_loudspeaker_to_playback_target(void)
 {
-	// TODO
+	/* TODO */
 	cn_sx1snd_send(DAC_SETAUDIODEVICE, SX1_DEVICE_SPEAKER, 0);
 
 	current_playback_target	= PLAYBACK_TARGET_LOUDSPEAKER;
@@ -71,7 +64,7 @@ void set_loudspeaker_to_playback_target(
 
 void set_headphone_to_playback_target(void)
 {
-	// TODO
+	/* TODO */
 	cn_sx1snd_send(DAC_SETAUDIODEVICE, SX1_DEVICE_HEADPHONE, 0);
 
 	current_playback_target	= PLAYBACK_TARGET_HEADPHONE;
@@ -79,7 +72,7 @@ void set_headphone_to_playback_target(vo
 
 void set_telephone_to_playback_target(void)
 {
-	// TODO
+	/* TODO */
 	cn_sx1snd_send(DAC_SETAUDIODEVICE, SX1_DEVICE_PHONE, 0);
 
 	current_playback_target	= PLAYBACK_TARGET_CELLPHONE;
@@ -93,26 +86,21 @@ static void set_telephone_to_record_sour
 void init_playback_targets(void)
 {
 	set_loudspeaker_to_playback_target();
-
 	set_mixer_volume(DEFAULT_OUTPUT_VOLUME);
 }
 
 /*
- * Initializes SX1 recourd source (to mic) and playback target (to loudspeaker)
+ * Initializes SX1 record source (to mic) and playback target (to loudspeaker)
  */
 void snd_omap_init_mixer(void)
 {
-	FN_IN;
-
-	/* Select headset to record source (MIC_INHED)*/
+	/* Select headset to record source */
 	set_record_source(REC_SRC_SINGLE_ENDED_MICIN_HED);
 	/* Init loudspeaker as a default playback target*/
 	init_playback_targets();
-
-	FN_OUT(0);
 }
 
-/*--------------------------------------------------------------------------------------------*/
+/* ---------------------------------------------------------------------------------------- */
 static int __pcm_playback_target_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t *uinfo)
 {
 	static char *texts[PLAYBACK_TARGET_COUNT] = {
@@ -125,8 +113,8 @@ static int __pcm_playback_target_info(sn
 	if (uinfo->value.enumerated.item > PLAYBACK_TARGET_COUNT - 1) {
         	uinfo->value.enumerated.item = PLAYBACK_TARGET_COUNT - 1;
 	}
-	strcpy(uinfo->value.enumerated.name,
-       	texts[uinfo->value.enumerated.item]);
+	strcpy(uinfo->value.enumerated.name, 
+	       texts[uinfo->value.enumerated.item]);
 	return 0;
 }
 
@@ -138,29 +126,27 @@ static int __pcm_playback_target_get(snd
 
 static int __pcm_playback_target_put(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
 {
-	int	retVal;
-	int	curVal;
+	int ret_val = 0;
+	int cur_val = ucontrol->value.integer.value[0];
 
-	retVal	= 0;
-	curVal	= ucontrol->value.integer.value[0];
-	if ((curVal >= 0) &&
-	    (curVal < PLAYBACK_TARGET_COUNT) &&
-	    (curVal != current_playback_target)) {
-		if (curVal == PLAYBACK_TARGET_LOUDSPEAKER) {
+	if ((cur_val >= 0) &&
+	    (cur_val < PLAYBACK_TARGET_COUNT) &&
+	    (cur_val != current_playback_target)) {
+		if (cur_val == PLAYBACK_TARGET_LOUDSPEAKER) {
 			set_record_source(REC_SRC_SINGLE_ENDED_MICIN_HED);
 			set_loudspeaker_to_playback_target();
  		}
-		else if (curVal == PLAYBACK_TARGET_HEADPHONE) {
+		else if (cur_val == PLAYBACK_TARGET_HEADPHONE) {
 			set_record_source(REC_SRC_SINGLE_ENDED_MICIN_HND);
  			set_headphone_to_playback_target();
  		}
-		else if (curVal == PLAYBACK_TARGET_CELLPHONE) {
+		else if (cur_val == PLAYBACK_TARGET_CELLPHONE) {
 			set_telephone_to_record_source();
 			set_telephone_to_playback_target();
 		}
-		retVal	= 1;
+		ret_val	= 1;
 	}
-	return retVal;
+	return ret_val;
 }
 
 /*--------------------------------------------------------------------------------------------*/
@@ -175,14 +161,11 @@ static int __pcm_playback_volume_info(sn
 
 /*
  * Alsa mixer interface function for getting the volume read from the SX1 in a
- * 0 -100 alsa mixer format.
+ * 0-100 alsa mixer format.
  */
 static int __pcm_playback_volume_get(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
 {
-
-	ucontrol->value.integer.value[0]	= current_volume;
-
-	M_DPRINTK("mixer volume = %ld\n", current_volume);
+	ucontrol->value.integer.value[0] = current_volume;
 	return 0;
 }
 
@@ -202,17 +185,17 @@ static int __pcm_playback_switch_info(sn
 
 static int __pcm_playback_switch_get(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
 {
-	ucontrol->value.integer.value[0]	= 1;
+	ucontrol->value.integer.value[0] = 1;
 	return 0;
 }
 
 static int __pcm_playback_switch_put(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
 {
-//	return dac_gain_control_unmute(ucontrol->value.integer.value[0],
-//					ucontrol->value.integer.value[1]);
 	return 0;
 }
-/*--------------------------------------------------------------------------------------------*/
+
+/* -------------------------------------------------------------------------------------------- */
+
 static int __headset_playback_volume_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t *uinfo)
 {
 	uinfo->type			= SNDRV_CTL_ELEM_TYPE_INTEGER;
@@ -225,8 +208,6 @@ static int __headset_playback_volume_inf
 static int __headset_playback_volume_get(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
 {
 	ucontrol->value.integer.value[0]	= current_volume;
-
-	M_DPRINTK("mixer volume returned = %ld\n", ucontrol->value.integer.value[0]);
 	return 0;
 }
 
@@ -246,19 +227,21 @@ static int __headset_playback_switch_inf
 
 static int __headset_playback_switch_get(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
 {
-	ucontrol->value.integer.value[0]	= 1;
+	ucontrol->value.integer.value[0] = 1;
 	return 0;
 }
 
 static int __headset_playback_switch_put(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
 {
-	// mute/unmute headset
-//	return adc_pga_unmute_control(ucontrol->value.integer.value[0],
-//				TSC2101_HEADSET_GAIN_CTRL,
-//				15);
+	/* mute/unmute headset */
+#if 0
+	return adc_pga_unmute_control(ucontrol->value.integer.value[0],
+				TSC2101_HEADSET_GAIN_CTRL,
+				15);
+#endif
 	return 0;
 }
-/*--------------------------------------------------------------------------------------------*/
+/* -------------------------------------------------------------------------------------------- */
 static int __fmradio_playback_volume_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t *uinfo)
 {
 	uinfo->type			= SNDRV_CTL_ELEM_TYPE_INTEGER;
@@ -270,9 +253,7 @@ static int __fmradio_playback_volume_inf
 
 static int __fmradio_playback_volume_get(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
 {
-	ucontrol->value.integer.value[0]	= current_fm_volume;
-
-	M_DPRINTK("mixer volume returned = %ld\n", ucontrol->value.integer.value[0]);
+	ucontrol->value.integer.value[0] = current_fm_volume;
 	return 0;
 }
 
@@ -294,21 +275,21 @@ static int __fmradio_playback_switch_inf
 
 static int __fmradio_playback_switch_get(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
 {
-	ucontrol->value.integer.value[0]	= 1;
+	ucontrol->value.integer.value[0] = 1;
 	return 0;
 }
 
 static int __fmradio_playback_switch_put(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
 {
-	// mute/unmute FM radio
-	if(ucontrol->value.integer.value[0])
+	/* mute/unmute FM radio */
+	if (ucontrol->value.integer.value[0])
 		cn_sx1snd_send(DAC_FMRADIO_OPEN, current_fm_volume, 0);
 	else
 		cn_sx1snd_send(DAC_FMRADIO_CLOSE, 0, 0);
 
 	return 0;
 }
-/*--------------------------------------------------------------------------------------------*/
+/* -------------------------------------------------------------------------------------------- */
 static int __cellphone_input_switch_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t *uinfo)
 {
 	uinfo->type 			= SNDRV_CTL_ELEM_TYPE_BOOLEAN;
@@ -320,18 +301,19 @@ static int __cellphone_input_switch_info
 
 static int __cellphone_input_switch_get(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
 {
-	ucontrol->value.integer.value[0]	= 1;
+	ucontrol->value.integer.value[0] = 1;
 	return 0;
 }
 
 static int __cellphone_input_switch_put(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
 {
-//	return adc_pga_unmute_control(ucontrol->value.integer.value[0],
-//				TSC2101_BUZZER_GAIN_CTRL,
-//				15);
+#if 0
+	return adc_pga_unmute_control(ucontrol->value.integer.value[0],
+				TSC2101_BUZZER_GAIN_CTRL, 15);
+#endif
 	return 0;
 }
-/*--------------------------------------------------------------------------------------------*/
+/* -------------------------------------------------------------------------------------------- */
 
 static int __buzzer_input_switch_info(snd_kcontrol_t *kcontrol, snd_ctl_elem_info_t *uinfo)
 {
@@ -344,15 +326,16 @@ static int __buzzer_input_switch_info(sn
 
 static int __buzzer_input_switch_get(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
 {
-	ucontrol->value.integer.value[0]	= 1;
+	ucontrol->value.integer.value[0] = 1;
 	return 0;
 }
 
 static int __buzzer_input_switch_put(snd_kcontrol_t *kcontrol, snd_ctl_elem_value_t *ucontrol)
 {
-//	return adc_pga_unmute_control(ucontrol->value.integer.value[0],
-//				TSC2101_BUZZER_GAIN_CTRL,
-//				6);
+#if 0
+	return adc_pga_unmute_control(ucontrol->value.integer.value[0],
+				TSC2101_BUZZER_GAIN_CTRL, 6);
+#endif
 	return 0;
 }
 /*--------------------------------------------------------------------------------------------*/
@@ -434,7 +417,6 @@ static snd_kcontrol_new_t egold_control[
 };
 
 #ifdef CONFIG_PM
-
 void snd_omap_suspend_mixer(void)
 {
 }
@@ -447,18 +429,16 @@ #endif
 
 int snd_omap_mixer(struct snd_card_omap_codec *egold)
 {
-	int i=0;
-	int err=0;
+	int i = 0;
+	int err = 0;
 
-	if (!egold) {
+	if (!egold)
 		return -EINVAL;
-	}
+
 	for (i=0; i < ARRAY_SIZE(egold_control); i++) {
-		if ((err = snd_ctl_add(egold->card,
-				snd_ctl_new1(&egold_control[i],
-				egold->card))) < 0) {
+		err = snd_ctl_add(egold->card, snd_ctl_new1(&egold_control[i], egold->card));
+		if (err < 0)
 			return err;
-		}
 	}
 	return 0;
 }
sound/arm/omap/omap-alsa-sx1-mixer.h +5 -5
index e67f48a..02b8b6a 100644
@@ -30,8 +30,8 @@ #define PLAYBACK_TARGET_CELLPHONE	0x02
 
 /* following are used for register 03h Mixer PGA control bits D7-D5 for selecting record source */
 #define REC_SRC_TARGET_COUNT		0x08
-#define REC_SRC_SINGLE_ENDED_MICIN_HED	0x00	// oss code referred to MIXER_LINE
-#define REC_SRC_SINGLE_ENDED_MICIN_HND	0x01	// oss code referred to MIXER_MIC
+#define REC_SRC_SINGLE_ENDED_MICIN_HED	0x00	/* oss code referred to MIXER_LINE */
+#define REC_SRC_SINGLE_ENDED_MICIN_HND	0x01	/* oss code referred to MIXER_MIC */
 #define REC_SRC_SINGLE_ENDED_AUX1	0x02
 #define REC_SRC_SINGLE_ENDED_AUX2	0x03
 #define REC_SRC_MICIN_HED_AND_AUX1	0x04
@@ -39,7 +39,7 @@ #define REC_SRC_MICIN_HED_AND_AUX2	0x05
 #define REC_SRC_MICIN_HND_AND_AUX1	0x06
 #define REC_SRC_MICIN_HND_AND_AUX2	0x07
 
-#define DEFAULT_OUTPUT_VOLUME		5	// default output volume to dac dgc
-#define DEFAULT_INPUT_VOLUME		2	// default record volume
+#define DEFAULT_OUTPUT_VOLUME		5	/* default output volume to dac dgc */
+#define DEFAULT_INPUT_VOLUME		2	/* default record volume */
 
-#endif /*OMAPALSATSC2101MIXER_H_*/
+#endif
sound/arm/omap/omap-alsa-sx1.c +53 -63

223 lines not on this page · raw message

sound/arm/omap/omap-alsa-sx1.h +13 -15
index fdf55ee..34e26fc 100644
@@ -27,14 +27,14 @@ #define DEFAULT_BITPERSAMPLE		16
 #endif
 
 #define DEFAULT_SAMPLE_RATE		44100
-// fw15: 18356000
+/* fw15: 18356000 */
 #define CODEC_CLOCK 			18359000
-// McBSP for playing music
+/* McBSP for playing music */
 #define AUDIO_MCBSP        		OMAP_MCBSP1
-// McBSP for record/play audio from phone and mic
+/* McBSP for record/play audio from phone and mic */
 #define AUDIO_MCBSP_PCM    		OMAP_MCBSP2
-// gpio pin for enable/disable clock
-#define OSC_EN					2
+/* gpio pin for enable/disable clock */
+#define OSC_EN				2
 
 /*
  * Defines codec specific functions pointers that can be used from the
@@ -49,25 +49,25 @@ int egold_get_default_samplerate(void);
 
 /* Send IPC message to sound server */
 extern int cn_sx1snd_send(unsigned int cmd, unsigned int arg1, unsigned int arg2);
-// cmd for IPC_GROUP_DAC
+/* cmd for IPC_GROUP_DAC */
 #define DAC_VOLUME_UPDATE		0
 #define DAC_SETAUDIODEVICE		1
 #define DAC_OPEN_RING			2
 #define DAC_OPEN_DEFAULT		3
-#define DAC_CLOSE				4
+#define DAC_CLOSE			4
 #define DAC_FMRADIO_OPEN		5
 #define DAC_FMRADIO_CLOSE		6
 #define DAC_PLAYTONE			7
-// cmd for IPC_GROUP_PCM
-#define PCM_PLAY				(0+8)
+/* cmd for IPC_GROUP_PCM */
+#define PCM_PLAY			(0+8)
 #define PCM_RECORD			(1+8)
-#define PCM_CLOSE				(2+8)
+#define PCM_CLOSE			(2+8)
 
-// for DAC_SETAUDIODEVICE
+/* for DAC_SETAUDIODEVICE */
 #define SX1_DEVICE_SPEAKER		0
 #define SX1_DEVICE_HEADPHONE		4
 #define SX1_DEVICE_PHONE		3
-// frequencies for MdaDacOpenDefaultL,  MdaDacOpenRingL
+/* frequencies for MdaDacOpenDefaultL,  MdaDacOpenRingL */
 #define FRQ_8000        0
 #define FRQ_11025       1
 #define FRQ_12000       2
@@ -78,6 +78,4 @@ #define FRQ_32000       6
 #define FRQ_44100       7
 #define FRQ_48000       8
 
- /* Netlink socket defs for connection with userspace MUX */
-
-#endif /*OMAP_ALSA_SX1_H_*/
+#endif
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#2 lore raw
Quoted 10 lines · Lee Revell
Quoted 5 lines · Pavel Machek
sound/arm/omap/omap-alsa-sx1-mixer.c +2 -1
+int set_mixer_volume(int mixer_vol)
 {
-       int retVal;
+       /* FIXME: Alsa has mixer_vol in 0-100 range, while SX1 needs

0-9 range */

Untrue. ALSA uses whatever range you define in the info callback for the mixer element. I guess it just defaults to 0-100 if you don't set it.

Thanks, fixed.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#3 lore raw
In reply to Pavel Machek

At Sun, 19 Nov 2006 12:49:38 +0100,

Quoted 7 lines · Pavel Machek

Hi!

These are cleanups for codingstyle in sound parts of siemens sx1. They should not change any code. Please apply,

Pavel

Which tree does include these drivers?
I've never seen nor review it...

Takashi

#4 lore raw
Quoted 5 lines · Takashi Iwai

At Sun, 19 Nov 2006 12:49:38 +0100,

Quoted 3 lines · Pavel Machek

Hi!

Quoted 7 lines
Quoted 4 lines

These are cleanups for codingstyle in sound parts of siemens sx1. They should not change any code. Please apply,

Pavel

Which tree does include these drivers?
I've never seen nor review it...

It's Linux Texas Instruments OMAP processors tree, hosted at following links:

http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=log

OR mirror copy is also available to view at

http://www.kernel.org/git/

You have not seen those drivers, because we have _not_ yet submitted ALSA drivers for aic23 and ts2102 to upstream.

Pavel, better submit those -omap tree based changes to dedicated linux-omap-open-source mailing list instead. Please visit
http://linux.omap.com Thanx.

---Komal Shah
http://komalshah.blogspot.com

#5 lore raw
Quoted 17 lines · Komal Shah
Quoted 5 lines · Takashi Iwai

At Sun, 19 Nov 2006 12:49:38 +0100,

Quoted 3 lines · Pavel Machek

Hi!

Quoted 7 lines
Quoted 4 lines

These are cleanups for codingstyle in sound parts of siemens sx1. They should not change any code. Please apply,

Pavel

Which tree does include these drivers?
I've never seen nor review it...

It's Linux Texas Instruments OMAP processors tree, hosted at following links:

Quoted 8 lines

http://source.mvista.com/git/gitweb.cgi?p=linux-omap-2.6.git;a=log

OR mirror copy is also available to view at

http://www.kernel.org/git/

You have not seen those drivers, because we have _not_ yet submitted ALSA drivers for aic23 and ts2102 to upstream.

Yeah, we should clean-up and those for sending to alsa list for merging.

Tony

#6 lore raw
In reply to Takashi Iwai
Quoted 10 lines · Takashi Iwai

At Sun, 19 Nov 2006 12:49:38 +0100,

Quoted 5 lines · Pavel Machek

Hi!

These are cleanups for codingstyle in sound parts of siemens sx1. They should not change any code. Please apply,

Which tree does include these drivers?
I've never seen nor review it...

I'm just now sending cleanups to Vladimir; he's the person writing those. His tree is only available as patches.

I thought I'd push them through omap tree, but if alsa wants to take them instead, I have no problem with that.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#7 lore raw

At Tue, 21 Nov 2006 12:48:11 +0100,

Quoted 10 lines · Pavel Machek
Quoted 8 lines · Takashi Iwai

At Sun, 19 Nov 2006 12:49:38 +0100,

Quoted 5 lines · Pavel Machek

Hi!

These are cleanups for codingstyle in sound parts of siemens sx1. They should not change any code. Please apply,

Quoted 8 lines
Quoted 2 lines

Which tree does include these drivers?
I've never seen nor review it...

I'm just now sending cleanups to Vladimir; he's the person writing those. His tree is only available as patches.

I thought I'd push them through omap tree, but if alsa wants to take them instead, I have no problem with that.

I don't care which tree contains the driver, too.

I was just concerned by that the driver code hasn't been reviewed by sound subsystem developers at all.

Takashi

#8 lore raw
Quoted 18 lines · Takashi Iwai

At Tue, 21 Nov 2006 12:48:11 +0100,

Quoted 16 lines · Pavel Machek
Quoted 10 lines · Takashi Iwai

At Sun, 19 Nov 2006 12:49:38 +0100,

Quoted 5 lines · Pavel Machek

Hi!

These are cleanups for codingstyle in sound parts of siemens sx1. They should not change any code. Please apply,

Which tree does include these drivers?
I've never seen nor review it...

I'm just now sending cleanups to Vladimir; he's the person writing those. His tree is only available as patches.

Quoted 7 lines
Quoted 2 lines

I thought I'd push them through omap tree, but if alsa wants to take them instead, I have no problem with that.

I don't care which tree contains the driver, too.

I was just concerned by that the driver code hasn't been reviewed by sound subsystem developers at all.

It is not in _that_ stage, yet. We are currently cleaning it for submission.

Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#9 lore raw

At Tue, 21 Nov 2006 12:56:19 +0100,

Quoted 23 lines · Pavel Machek
Quoted 21 lines · Takashi Iwai

At Tue, 21 Nov 2006 12:48:11 +0100,

Quoted 18 lines · Pavel Machek
Quoted 10 lines · Takashi Iwai

At Sun, 19 Nov 2006 12:49:38 +0100,

Quoted 5 lines · Pavel Machek

Hi!

These are cleanups for codingstyle in sound parts of siemens sx1. They should not change any code. Please apply,

Which tree does include these drivers?
I've never seen nor review it...

I'm just now sending cleanups to Vladimir; he's the person writing those. His tree is only available as patches.

I thought I'd push them through omap tree, but if alsa wants to take them instead, I have no problem with that.

Quoted 7 lines
Quoted 4 lines

I don't care which tree contains the driver, too.

I was just concerned by that the driver code hasn't been reviewed by sound subsystem developers at all.

It is not in _that_ stage, yet. We are currently cleaning it for submission.

Yeah, that's why I wrote "I _was_ concerned" :)

Takashi