Skip to contentSkip to conversation

agp-amd64: section mismatches with HOTPLUG=n

PATCH New Randy Dunlap 1 participant 1 message Nov 20, 2006 Agpgart driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 agp-amd64: section mismatches with HOTPLUG=n

From: Randy Dunlap <[email protected]>

When CONFIG_HOTPLUG=n, agp_amd64_resume() calls nforce3_agp_init(), which is __devinit == __init, so has been discarded and is not usable for resume.

WARNING: drivers/char/agp/amd64-agp.o - Section mismatch: reference to .init.text: from .text between 'agp_amd64_resume' (at offset 0x249) and 'amd64_tlbflush'

---
 drivers/char/agp/amd64-agp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/agp/amd64-agp.c +1 -1
@@ -459,7 +459,7 @@ static const struct aper_size_info_32 nf
 
 /* Handle shadow device of the Nvidia NForce3 */
 /* CHECK-ME original 2.4 version set up some IORRs. Check if that is needed. */
-static int __devinit nforce3_agp_init(struct pci_dev *pdev)
+static int nforce3_agp_init(struct pci_dev *pdev)
 {
 	u32 tmp, apbase, apbar, aplimit;
 	struct pci_dev *dev1;

---