Skip to contentSkip to conversation

make fs/proc/base.c:proc_pid_instantiate() static

PATCH In review Adrian Bunk 2 participants 2 messages Nov 20, 2006 Proc filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make fs/proc/base.c:proc_pid_instantiate() static

This patch makes the needlessly global proc_pid_instantiate() static.

fs/proc/base.c renamed from fs/proc/base.c.old +3 -2
@@ -1946,8 +1946,9 @@
 	return;
 }
 
-struct dentry *proc_pid_instantiate(struct inode *dir,
-	struct dentry * dentry, struct task_struct *task, void *ptr)
+static struct dentry *proc_pid_instantiate(struct inode *dir,
+					   struct dentry * dentry,
+					   struct task_struct *task, void *ptr)
 {
 	struct dentry *error = ERR_PTR(-ENOENT);
 	struct inode *inode;
Acked-by on v1 1/1
#1 lore raw
Quoted 1 line · Adrian Bunk

This patch makes the needlessly global proc_pid_instantiate() static.

Looks good to me.

Quoted 16 lines
fs/proc/base.c renamed from fs/proc/base.c.old 2006-11-20 02:08:33.000000000 +0100 +3 -2
@@ -1946,8 +1946,9 @@
 	return;
 }
 
-struct dentry *proc_pid_instantiate(struct inode *dir,
-	struct dentry * dentry, struct task_struct *task, void *ptr)
+static struct dentry *proc_pid_instantiate(struct inode *dir,
+					   struct dentry * dentry,
+					   struct task_struct *task, void *ptr)
 {
 	struct dentry *error = ERR_PTR(-ENOENT);
 	struct inode *inode;