Skip to contentSkip to conversation

: Tidy up skb_entail

PATCH In review Arnaldo Carvalho de Melo 1 participant 1 message Nov 20, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/9 : Tidy up skb_entail

Heck, it even saves us some few bytes:

[acme@newtoy net-2.6.20]$ codiff -f /tmp/tcp.o.before ../OUTPUT/qemu/net-2.6.20/net/ipv4/tcp.o /pub/scm/linux/kernel/git/acme/net-2.6.20/net/ipv4/tcp.c:

  tcp_sendpage |   -7
  tcp_sendmsg  |   -5

2 functions changed, 12 bytes removed
[acme@newtoy net-2.6.20]$

---
 net/ipv4/tcp.c |   11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)
net/ipv4/tcp.c +6 -5
index 168f9de..a6b2289 100644
@@ -463,11 +463,12 @@ static inline int forced_push(struct tcp
 static inline void skb_entail(struct sock *sk, struct tcp_sock *tp,
 			      struct sk_buff *skb)
 {
-	skb->csum = 0;
-	TCP_SKB_CB(skb)->seq = tp->write_seq;
-	TCP_SKB_CB(skb)->end_seq = tp->write_seq;
-	TCP_SKB_CB(skb)->flags = TCPCB_FLAG_ACK;
-	TCP_SKB_CB(skb)->sacked = 0;
+	struct tcp_skb_cb *tcb = TCP_SKB_CB(skb);
+
+	skb->csum    = 0;
+	tcb->seq     = tcb->end_seq = tp->write_seq;
+	tcb->flags   = TCPCB_FLAG_ACK;
+	tcb->sacked  = 0;
 	skb_header_release(skb);
 	__skb_queue_tail(&sk->sk_write_queue, skb);
 	sk_charge_skb(sk, skb);
Signature · 1 line
1.4.2.1.g3d5c