: Use kmemdup where applicable
Subsystems (2)
PATCH 6/11 : Use kmemdup where applicable
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
--- net/irda/iriap.c | 3 +-- net/irda/irias_object.c | 4 +--- net/irda/irlmp.c | 4 +--- net/irda/irqueue.c | 3 +-- 4 files changed, 4 insertions(+), 10 deletions(-)
net/irda/iriap.c +1 -2
@@ -172,7 +172,7 @@ struct iriap_cb *iriap_open(__u8 slsap_sIRDA_DEBUG (2 ,"%s()\n" , __FUNCTION__); - self =kmalloc (sizeof (struct iriap_cb ),GFP_ATOMIC ); + self =kzalloc (sizeof (*self),GFP_ATOMIC );if (!self) {IRDA_WARNING ("%s: Unable to kmalloc!\n" , __FUNCTION__);return NULL ;
@@ -181,7 +181,6 @@ struct iriap_cb *iriap_open(__u8 slsap_s/* * Initialize instance */ -memset (self,0 ,sizeof (struct iriap_cb )); self->magic =IAS_MAGIC ; self->mode = mode;
net/irda/irias_object.c +1 -3
@@ -501,13 +501,12 @@ struct ias_value *irias_new_octseq_value len =IAS_MAX_OCTET_STRING ; value->len = len; - value->t.oct_seq =kmalloc (len,GFP_ATOMIC ); + value->t.oct_seq =kmemdup (octseq, len,GFP_ATOMIC );if (value->t.oct_seq ==NULL ){IRDA_WARNING ("%s: Unable to kmalloc!\n" , __FUNCTION__);kfree (value);return NULL ; } -memcpy (value->t.oct_seq, octseq , len);return value; }
@@ -522,7 +521,6 @@ struct ias_value *irias_new_missing_valu } value->type =IAS_MISSING ; - value->len =0 ;return value; }
net/irda/irlmp.c +1 -3
@@ -641,15 +641,13 @@ struct lsap_cb *irlmp_dup(struct lsap_cb }/* Allocate a new instance */ - new =kmalloc (sizeof (struct lsap_cb ),GFP_ATOMIC ); + new =kmemdup (orig,sizeof (*new),GFP_ATOMIC );if (!new) {IRDA_DEBUG (0 ,"%s(), unable to kmalloc\n" , __FUNCTION__);spin_unlock_irqrestore (&irlmp->unconnected_lsaps->hb_spinlock, flags);return NULL ; } -/* Dup */ -memcpy (new, orig,sizeof (struct lsap_cb ));/* new->lap = orig->lap; => done in the memcpy() */ /* new->slsap_sel = orig->slsap_sel; => done in the memcpy() */ new->conn_skb =NULL ;
net/irda/irqueue.c +1 -2
@@ -356,14 +356,13 @@ hashbin_t *hashbin_new(int type)/* * Allocate new hashbin */ - hashbin =kmalloc (sizeof (hashbin_t),GFP_ATOMIC ); + hashbin =kzalloc (sizeof (*hashbin),GFP_ATOMIC );if (!hashbin)return NULL ;/* * Initialize structure */ -memset (hashbin,0 ,sizeof (hashbin_t)); hashbin->hb_type = type; hashbin->magic =HB_MAGIC ;//hashbin->hb_current = NULL;
Signature · 1 line
1.4.2.1.g3d5c