Skip to contentSkip to conversation

allow the highest frequency if bios think so.

PATCH In review Bruno Ducrot 3 participants 5 messages Nov 21, 2006 – Nov 29, 2006 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 allow the highest frequency if bios think so.

Hi all,

processor_perflib.c::acpi_processor_ppc_notifier() check if the value returned by the processor's _PPC method is 0 and return failed if so. This is wrong since 0 indicate that the bios think the processor can go to the highest frequency. This patch for example fix the HP NX 6125 to allow its highest frequency to be available.

drivers/acpi/processor_perflib.c +0 -2
@@ -83,8 +83,6 @@ static int acpi_processor_ppc_notifier(s
 		goto out;
 
 	ppc = (unsigned int)pr->performance_platform_limit;
-	if (!ppc)
-		goto out;
 
 	if (ppc > pr->performance->state_count)
 		goto out;
Signature · 4 lines
Bruno Ducrot

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.
#1 lore raw
Quoted 5 lines · Bruno Ducrot

Hi all,

processor_perflib.c::acpi_processor_ppc_notifier() check if the value returned by the processor's _PPC method is 0 and return failed if so. This is wrong since 0 indicate that the bios think the processor can

go

Quoted 1 line

to the highest frequency. This patch for example fix the HP NX 6125

to

Quoted 1 line

allow its highest frequency to be available.

I don't know about the HP NX 6125, but on my nc 6320, you have to rmmod psmouse before you shutdown or reboot the computer, otherwise something upsets the BIOS and it won't run at full speed on next boot up.

Can't hurt to give it a try. The other method to get it working again is to remove the AC adaptor and the battery for a few seconds, then re-insert and power up.

Bootup time is also much faster if the psmouse was rmmod'd before shutdown, or the power was completely removed as above.

Weired indeed!

Peter Clifton

#2 lore raw
Quoted 6 lines · Peter Clifton
Quoted 5 lines · Bruno Ducrot

Hi all,

processor_perflib.c::acpi_processor_ppc_notifier() check if the value returned by the processor's _PPC method is 0 and return failed if so. This is wrong since 0 indicate that the bios think the processor can

Quoted 8 lines

go

Quoted 1 line

to the highest frequency. This patch for example fix the HP NX 6125

to

Quoted 1 line

allow its highest frequency to be available.

I don't know about the HP NX 6125, but on my nc 6320, you have to rmmod psmouse before you shutdown or reboot the computer, otherwise something upsets the BIOS and it won't run at full speed on next boot up.

The proposed patch fix exactly this one on the HP NX 6125.

Quoted 6 lines

Can't hurt to give it a try. The other method to get it working again is to remove the AC adaptor and the battery for a few seconds, then re-insert and power up.

Bootup time is also much faster if the psmouse was rmmod'd before shutdown, or the power was completely removed as above.

Can't tell for this bootup time issue though.

Signature · 4 lines
Bruno Ducrot

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.
#3 lore raw
In reply to Peter Clifton

Peter Clifton napisał(a):

Quoted 8 lines

I don't know about the HP NX 6125, but on my nc 6320, you have to rmmod psmouse before you shutdown or reboot the computer, otherwise something upsets the BIOS and it won't run at full speed on next boot up.

Can't hurt to give it a try. The other method to get it working again is to remove the AC adaptor and the battery for a few seconds, then re-insert and power up.

Quoted 6 lines

Bootup time is also much faster if the psmouse was rmmod'd before shutdown, or the power was completely removed as above.

Weired indeed!

Peter Clifton

The same problem in NX 6310 and - probably - other NX models. When I forgot remove psmouse sometimes I saw psmouse CRC32 error (or something similar) after ACPI called power off (at the last moment when power off). Sorry, it's to fast, so I can't check what is happen.

Signature · 4 lines
Maciej Rutecki <[email protected]>
http://www.unixy.pl
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/wiki/)
#4 lore raw
In reply to Bruno Ducrot
Quoted 13 lines · Bruno Ducrot

Hi all,

processor_perflib.c::acpi_processor_ppc_notifier() check if the value returned by the processor's _PPC method is 0 and return failed if so. This is wrong since 0 indicate that the bios think the processor can go to the highest frequency. This patch for example fix the HP NX 6125 to allow its highest frequency to be available.

drivers/acpi/processor_perflib.c static int acpi_processor_ppc_notifier(s · line 87

Quoted 7 lines
drivers/acpi/processor_perflib.c +0 -2
@@ -83,8 +83,6 @@ static int acpi_processor_ppc_notifier(s
 		goto out;
 
 	ppc = (unsigned int)pr->performance_platform_limit;
-	if (!ppc)
-		goto out;
 
 	if (ppc > pr->performance->state_count)

BTW I'm wondering if this check should be :

	if (ppc >= pr->performance->state_count)
Quoted 1 line
drivers/acpi/processor_perflib.c +0 -0
 		goto out;
Signature · 4 lines
Bruno Ducrot

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.