Skip to contentSkip to conversation

CISS: require same SCSI module support

PATCH In review Randy Dunlap 2 participants 2 messages Nov 21, 2006

Subsystems (2)
SCSI Block layer
lore
Share & tools
lore

Randy Dunlap

author
#0 lore raw

PATCH 1/1 CISS: require same SCSI module support

From: Randy Dunlap <[email protected]>

Building CCISS SCSI tape support in-kernel when SCSI=m causes build errors, so require SCSI support to be =y or same as CCISS SCSI tape support.

drivers/built-in.o: In function `cciss_remove_one':
cciss.c:(.text+0x79d4c): undefined reference to scsi_remove_host' cciss.c:(.text+0x79d55): undefined reference to scsi_host_put' drivers/built-in.o: In function `cciss_update_non_disk_devices':
cciss.c:(.text+0x7bb54): undefined reference to scsi_device_type' cciss.c:(.text+0x7bcc8): undefined reference to scsi_device_type' cciss.c:(.text+0x7be81): undefined reference to scsi_device_type' cciss.c:(.text+0x7bf81): undefined reference to scsi_device_type' drivers/built-in.o: In function `cciss_proc_write':
cciss.c:(.text+0x7c175): undefined reference to scsi_host_alloc' cciss.c:(.text+0x7c1ed): undefined reference to scsi_add_host' cciss.c:(.text+0x7c1f9): undefined reference to scsi_scan_host' cciss.c:(.text+0x7c206): undefined reference to scsi_host_put'
make: *** [.tmp_vmlinux1] Error 1

Signed-off-by Randy Dunlap <[email protected]>
---
 drivers/block/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/block/Kconfig +2 -1
@@ -168,7 +168,8 @@ config BLK_CPQ_CISS_DA
 
 config CISS_SCSI_TAPE
 	bool "SCSI tape drive support for Smart Array 5xxx"
-	depends on BLK_CPQ_CISS_DA && SCSI && PROC_FS
+	depends on BLK_CPQ_CISS_DA && PROC_FS
+	depends on SCSI=y || SCSI=BLK_CPQ_CISS_DA
 	help
 	  When enabled (Y), this option allows SCSI tape drives and SCSI medium
 	  changers (tape robots) to be accessed via a Compaq 5xxx array

---

Acked-by on v1 1/1
#1 lore raw
Quoted 30 lines

-----Original Message-----
From: Randy Dunlap [mailto:[email protected]]
Sent: Tuesday, November 21, 2006 1:06 PM
To: scsi
Cc: Miller, Mike (OS Dev); ISS StorageDev; akpm
Subject: [PATCH] CISS: require same SCSI module support

From: Randy Dunlap <[email protected]>

Building CCISS SCSI tape support in-kernel when SCSI=m causes build errors, so require SCSI support to be =y or same as CCISS SCSI tape support.

drivers/built-in.o: In function `cciss_remove_one':
cciss.c:(.text+0x79d4c): undefined reference to scsi_remove_host' cciss.c:(.text+0x79d55): undefined reference to scsi_host_put' drivers/built-in.o: In function `cciss_update_non_disk_devices':
cciss.c:(.text+0x7bb54): undefined reference to scsi_device_type' cciss.c:(.text+0x7bcc8): undefined reference to scsi_device_type' cciss.c:(.text+0x7be81): undefined reference to scsi_device_type' cciss.c:(.text+0x7bf81): undefined reference to scsi_device_type' drivers/built-in.o: In function `cciss_proc_write':
cciss.c:(.text+0x7c175): undefined reference to scsi_host_alloc' cciss.c:(.text+0x7c1ed): undefined reference to scsi_add_host' cciss.c:(.text+0x7c1f9): undefined reference to scsi_scan_host' cciss.c:(.text+0x7c206): undefined reference to scsi_host_put'
make: *** [.tmp_vmlinux1] Error 1

Quoted 1 line
Signed-off-by Randy Dunlap <[email protected]>
Acked-by Mike Miller <[email protected]>
Quoted 21 lines
---
 drivers/block/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/block/Kconfig +2 -1
@@ -168,7 +168,8 @@ config BLK_CPQ_CISS_DA
 
 config CISS_SCSI_TAPE
 	bool "SCSI tape drive support for Smart Array 5xxx"
-	depends on BLK_CPQ_CISS_DA && SCSI && PROC_FS
+	depends on BLK_CPQ_CISS_DA && PROC_FS
+	depends on SCSI=y || SCSI=BLK_CPQ_CISS_DA
 	help
 	  When enabled (Y), this option allows SCSI tape drives

and SCSI medium
changers (tape robots) to be accessed via a Compaq 5xxx array

---