Skip to contentSkip to conversation

X86_genericarch needs SMP?

PATCH In review Randy Dunlap 2 participants 2 messages Nov 22, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 X86_genericarch needs SMP?

From: Randy Dunlap <[email protected]>

With
CONFIG_SMP=n, CONFIG_X86_GENERICARCH=y
(and CONFIG_X86_SUMMIT=n), kernel build gets:

arch/i386/mach-generic/built-in.o: In function `apicid_to_node':
summit.c:(.text+0x54): undefined reference to `apicid_2_node'

so should X86_GENERICARCH depend on SMP?
or should there be more ifdefs in the source files?

---
 arch/i386/Kconfig |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
arch/i386/Kconfig +3 -2
@@ -165,8 +165,9 @@ config X86_VISWS
 	  and vice versa. See <file:Documentation/sgi-visws.txt> for details.
 
 config X86_GENERICARCH
-       bool "Generic architecture (Summit, bigsmp, ES7000, default)"
-       help
+	bool "Generic architecture (Summit, bigsmp, ES7000, default)"
+	depends on SMP
+	help
           This option compiles in the Summit, bigsmp, ES7000, default subarchitectures.
 	  It is intended for a generic binary kernel.
 	  If you want a NUMA kernel, select ACPI.   We need SRAT for NUMA.

---

#1 lore raw
Quoted 11 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

With
CONFIG_SMP=n, CONFIG_X86_GENERICARCH=y
(and CONFIG_X86_SUMMIT=n), kernel build gets:

arch/i386/mach-generic/built-in.o: In function `apicid_to_node':
summit.c:(.text+0x54): undefined reference to `apicid_2_node'

so should X86_GENERICARCH depend on SMP?
or should there be more ifdefs in the source files?

I already fixed that here in a different way, but the patch didn't make it to Linus yet.

-Andi