arch/x86_64/kernel/pci-calgary.c(600): remark #593: variable "bbar" was set but
Hello there,
I just tried to compile Linux kernel 2.6.18.3 with the Intel C C compiler.
The compiler said
arch/x86_64/kernel/pci-calgary.c(600): remark #593: variable "bbar" was set but never used arch/x86_64/kernel/pci-calgary.c(601): remark #593: variable "busnum" was set but never used
The source code is
void __iomem *bbar;
unsigned char busnum;
I have checked the source code and I agree with the compiler. Suggest delete local variables.
Regards
David Binderman
_________________________________________________________________
Be the first to hear what's new at MSN - sign up to our free newsletters! http://www.msn.co.uk/newsletters
PATCH 1/1 Calgary: remove unused vars
Quoted 13 lines · d binderman
Hello there,
I just tried to compile Linux kernel 2.6.18.3 with the Intel C C compiler.
The compiler said
arch/x86_64/kernel/pci-calgary.c(600): remark #593: variable "bbar" was set but never used
arch/x86_64/kernel/pci-calgary.c(601): remark #593: variable "busnum" was set but never used
Quoted 7 lines
The source code is
void __iomem *bbar; unsigned char busnum;I have checked the source code and I agree with the compiler. Suggest delete local variables.
Thanks, I agree. Andi, please apply.
[PATCH x86-64] Calgary: remove unused vars
Spotted by d binderman <[email protected]>.
arch/x86_64/kernel/pci-calgary.c +0 -5
@@ -653,13 +653,8 @@ static void __init calgary_reserve_regiostatic void __init calgary_reserve_regions (struct pci_dev *dev) {unsigned int npages; -void __iomem *bbar; -unsigned char busnum;u64 start;struct iommu_table *tbl = dev->sysdata; - - bbar = tbl->bbar; - busnum = dev->bus->number;/* reserve bad_dma_address in case it's a legal address */ iommu_range_reserve (tbl, bad_dma_address,1 );