Skip to contentSkip to conversation

e1000: fix initialization irqs

PATCH In review Dmitry Mishin 2 participants 4 messages Nov 22, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 e1000: fix initialization irqs

In case of irqpoll boot option set, e1000 may oops due to:
1) e1000 register it's handler with e1000_request_irq
2) spurious interrupt happens
3) kernel tries to handle this interrupt with all available descs
4) e1000_intr is called and oops due to not initialized clean_rx handler, because e1000_up is not called yet.

Solution is to initialize driver before handler registration.

---
 e1000_main.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

---

drivers/net/e1000/e1000_main.c renamed from drivers/net/e1000/e1000_main.c.e1000 +5 -4
@@ -1206,14 +1206,15 @@ e1000_open(struct net_device *netdev)
 	if ((err = e1000_setup_all_rx_resources(adapter)))
 		goto err_setup_rx;
 
-	err = e1000_request_irq(adapter);
-	if (err)
-		goto err_up;
-
 	e1000_power_up_phy(adapter);
 
 	if ((err = e1000_up(adapter)))
 		goto err_up;
+
+	err = e1000_request_irq(adapter);
+	if (err)
+		goto err_up;
+
 	adapter->mng_vlan_id = E1000_MNG_VLAN_NONE;
 	if ((adapter->hw.mng_cookie.status &
 			  E1000_MNG_DHCP_COOKIE_STATUS_VLAN_SUPPORT)) {
#1 lore raw
Quoted 7 lines · Dmitry Mishin

In case of irqpoll boot option set, e1000 may oops due to:
1) e1000 register it's handler with e1000_request_irq
2) spurious interrupt happens
3) kernel tries to handle this interrupt with all available descs
4) e1000_intr is called and oops due to not initialized clean_rx handler, because e1000_up is not called yet.

Solution is to initialize driver before handler registration.

I'm not so sure of that. even if we request our irq's to be routed it does not mean that we told the NIC to send them. It would suggest that you might be haunted by the MSI interrupts not working 100% correctly on some non-intel platform.

Now you're telling the NIC to send interrupts before we routed them I think.

If we _up() before we even have an interrupt, even more bad things could happen.

What is the reason you wrote this workaround?

Auke

Quoted 35 lines
---
 e1000_main.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

---

drivers/net/e1000/e1000_main.c renamed from drivers/net/e1000/e1000_main.c.e1000 +5 -5
@@ -1206,14 +1206,15 @@ e1000_open(struct net_device *netdev)
 	if ((err = e1000_setup_all_rx_resources(adapter)))
 		goto err_setup_rx;
 
-	err = e1000_request_irq(adapter);
-	if (err)
-		goto err_up;
-
 	e1000_power_up_phy(adapter);
 
 	if ((err = e1000_up(adapter)))
 		goto err_up;
+
+	err = e1000_request_irq(adapter);
+	if (err)
+		goto err_up;
+
 	adapter->mng_vlan_id = E1000_MNG_VLAN_NONE;
 	if ((adapter->hw.mng_cookie.status &
 			  E1000_MNG_DHCP_COOKIE_STATUS_VLAN_SUPPORT)) {
-

To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 14 lines · Auke Kok
Quoted 8 lines · Dmitry Mishin

In case of irqpoll boot option set, e1000 may oops due to:
1) e1000 register it's handler with e1000_request_irq
2) spurious interrupt happens
3) kernel tries to handle this interrupt with all available descs
4) e1000_intr is called and oops due to not initialized clean_rx handler, because e1000_up is not called yet.

Solution is to initialize driver before handler registration.

I'm not so sure of that. even if we request our irq's to be routed it does not mean that we told the NIC to send them. It would suggest that you might be haunted by the MSI interrupts not working 100% correctly on some non-intel platform.

Quoted 5 lines

Now you're telling the NIC to send interrupts before we routed them I think.

If we _up() before we even have an interrupt, even more bad things could happen.

What is the reason you wrote this workaround?

The reason is simple, we've got this oops due to misrouted interrupts, misrouted_irq() function. This workaround helps us, please, advice how to fix it or fix it yourself.

Quoted 43 lines

Auke

Quoted 32 lines
---
 e1000_main.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

---

drivers/net/e1000/e1000_main.c renamed from drivers/net/e1000/e1000_main.c.e1000 +5 -5
@@ -1206,14 +1206,15 @@ e1000_open(struct net_device *netdev)
 	if ((err = e1000_setup_all_rx_resources(adapter)))
 		goto err_setup_rx;
 
-	err = e1000_request_irq(adapter);
-	if (err)
-		goto err_up;
-
 	e1000_power_up_phy(adapter);
 
 	if ((err = e1000_up(adapter)))
 		goto err_up;
+
+	err = e1000_request_irq(adapter);
+	if (err)
+		goto err_up;
+
 	adapter->mng_vlan_id = E1000_MNG_VLAN_NONE;
 	if ((adapter->hw.mng_cookie.status &
 			  E1000_MNG_DHCP_COOKIE_STATUS_VLAN_SUPPORT)) {
-
Quoted 3 lines

To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

-
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines
Thanks,
Dmitry.
#3 lore raw
Quoted 8 lines · Dmitry Mishin
Quoted 5 lines · Auke Kok

Now you're telling the NIC to send interrupts before we routed them I think.

If we _up() before we even have an interrupt, even more bad things could happen.

What is the reason you wrote this workaround?

The reason is simple, we've got this oops due to misrouted interrupts, misrouted_irq() function. This workaround helps us, please, advice how to fix it or fix it yourself.

without knowing all the parameters that are involved, I cannot make an informed fix at all. I need to see the oops, a full dmesg dump, lspci -vv, and possibly more (preferably both before and after the OOPS).

If you can provide those then that would really help a lot, especially since the "fix" you provide introduces a great number of trap doors and other undetermined behaviour.

Cheers,

Auke