Skip to contentSkip to conversation

i2c-i801: SMBus patch for Intel ICH9

PATCH In review Jason Gaston 3 participants 4 messages Nov 22, 2006 – Nov 23, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i2c-i801: SMBus patch for Intel ICH9

This updated patch adds the Intel ICH9 LPC and SMBus Controller DID's. This patch relies on the irq ICH9 patch to pci_ids.h.

drivers/i2c/busses/i2c-i801.c renamed from drivers/i2c/busses/i2c-i801.c.orig +2 -0
@@ -33,6 +33,7 @@
     ICH7		27DA
     ESB2		269B
     ICH8		283E
+    ICH9		2930
     This driver supports several versions of Intel's I/O Controller Hubs (ICH).
     For SMBus support, they are similar to the PIIX4 and are part
     of Intel's '810' and other chipsets.
@@ -457,6 +458,7 @@
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_17) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB2_17) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH8_5) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH9_6) },
 	{ 0, }
 };
 
drivers/i2c/busses/Kconfig renamed from drivers/i2c/busses/Kconfig.orig +1 -0
@@ -125,6 +125,7 @@
 	    ICH7
 	    ESB2
 	    ICH8
+	    ICH9
 
 	  This driver can also be built as a module.  If so, the module
 	  will be called i2c-i801.
#1 lore raw

Hi Jason,

Quoted 2 lines · Jason Gaston

This updated patch adds the Intel ICH9 LPC and SMBus Controller DID's. This patch relies on the irq ICH9 patch to pci_ids.h.

Looks good. Care to also update Documentation/i2c/busses/i2c-i801? I see it misses at least the ICH8 and ESB2 as well.

I would also appreciate an update to lm_sensors' sensors-detect script, if you could send a patch to the sensors list.

Quoted 23 lines
drivers/i2c/busses/i2c-i801.c renamed from drivers/i2c/busses/i2c-i801.c.orig +2 -0
@@ -33,6 +33,7 @@
     ICH7		27DA
     ESB2		269B
     ICH8		283E
+    ICH9		2930
     This driver supports several versions of Intel's I/O Controller Hubs (ICH).
     For SMBus support, they are similar to the PIIX4 and are part
     of Intel's '810' and other chipsets.
@@ -457,6 +458,7 @@
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH7_17) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ESB2_17) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH8_5) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH9_6) },
 	{ 0, }
 };
 

drivers/i2c/busses/Kconfig line 131

Quoted 7 lines
drivers/i2c/busses/Kconfig renamed from drivers/i2c/busses/Kconfig.orig +1 -0
@@ -125,6 +125,7 @@
 	    ICH7
 	    ESB2
 	    ICH8
+	    ICH9
 
 	  This driver can also be built as a module.  If so, the module
 	  will be called i2c-i801.

Thanks,

Signature · 1 line
Jean Delvare
#2 lore raw
Quoted 11 lines · Jean Delvare

Hi Jason,

Quoted 2 lines · Jason Gaston

This updated patch adds the Intel ICH9 LPC and SMBus Controller DID's. This patch relies on the irq ICH9 patch to pci_ids.h.

Looks good. Care to also update Documentation/i2c/busses/i2c-i801? I see it misses at least the ICH8 and ESB2 as well.

I would also appreciate an update to lm_sensors' sensors-detect script, if you could send a patch to the sensors list.

hmmm couldn't the sensors-detect script just at runtime look at the pci tables in the modules? that way no need to duplicate/update all of this in multiple places...

Signature · 2 lines
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org
#3 lore raw

Hi Arjan,

Quoted 8 lines · Arjan van de Ven
Quoted 7 lines · Jean Delvare
Quoted 2 lines · Jason Gaston

This updated patch adds the Intel ICH9 LPC and SMBus Controller DID's. This patch relies on the irq ICH9 patch to pci_ids.h.

Looks good. Care to also update Documentation/i2c/busses/i2c-i801? I see it misses at least the ICH8 and ESB2 as well.

Quoted 7 lines
Quoted 2 lines

I would also appreciate an update to lm_sensors' sensors-detect script, if you could send a patch to the sensors list.

hmmm couldn't the sensors-detect script just at runtime look at the pci tables in the modules? that way no need to duplicate/update all of this in multiple places...

Not really. It is important that sensors-detect knows about chips which are not supported by the running kernel. That way, we can tell the users to try the latest version of sensors-detect when they report that hardware monitoring doesn't work out of the box, and from the output, we can tell them which kernel they need to upgrade to. If sensors-detect reads the list of supported devices from the kernel, instead of having its own, it will no longer work, by definition.

Additionally, sensors-detect is still supposed to support 2.4 kernels, and I don't think 2.4 drivers advertise the list of devices they support.

What we could do, on the other hand, is check the detected device ID against the list the running kernel driver supports, to let the user know that his/her chip is not supported by his/her kernel. Care to provide a patch adding this functionality to sensors-detect?

Thanks,

Signature · 1 line
Jean Delvare