Skip to contentSkip to conversation

Fix bug where early_node_map[] is not sorted before use

PATCH New Mel Gorman 1 participant 1 message Nov 23, 2006

Subsystems (2)
lore
Share & tools
lore

Mel Gorman

author
#0 lore raw

PATCH 1/1 Fix bug where early_node_map[] is not sorted before use

With reference to this bug;

Quoted 6 lines

Subject : x86_64: Bad page state in process 'swapper'
References : http://lkml.org/lkml/2006/11/10/135

             http://lkml.org/lkml/2006/11/10/208

Submitter : Andre Noll <[email protected]>

Status : problem is being debugged

The problem was within architecture-independent zone-sizing and exposed by a particular SRAT table on x86_64.

find_min_pfn_for_node() and find_min_pfn_with_active_regions() both depend on a sorted early_node_map[] to find the correct values. However, sort_node_map() is being called after find_min_pfn_with_active_regions() in free_area_init_nodes(). In most cases, this is ok, but on an x86_64, the SRAT table caused the E820 ranges to be registered out of order. This gave the wrong values for the min PFN range resulting in some pages not being initialised.

This patch sorts the early_node_map in find_min_pfn_for_node(). It is a critical fix for 2.6.19.

mm/page_alloc.c +3 -3
diff -rup linux-2.6.19-rc6-clean/mm/page_alloc.c linux-2.6.19-rc6-sort_in_find_min/mm/page_alloc.c
@@ -2612,6 +2612,9 @@ unsigned long __init find_min_pfn_for_no
 {
 	int i;
 
+	/* Regions in the early_node_map can be in any order */
+	sort_node_map();
+
 	/* Assuming a sorted map, the first range found has the starting pfn */
 	for_each_active_range_index_in_nid(i, nid)
 		return early_node_map[i].start_pfn;
@@ -2680,9 +2683,6 @@ void __init free_area_init_nodes(unsigne
 			max(max_zone_pfn[i], arch_zone_lowest_possible_pfn[i]);
 	}
 
-	/* Regions in the early_node_map can be in any order */
-	sort_node_map();
-
 	/* Print out the zone ranges */
 	printk("Zone PFN ranges:\n");
 	for (i = 0; i < MAX_NR_ZONES; i++)
Signature · 4 lines
-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab