Masking bug in 6pack driver
Subsystems (2)
Looks like a broken masking to me, binary not is used where bitwise not was intended.
Signed-off-by Jean Delvare <[email protected]>
Signed-off-by Ralf Baechle <[email protected]>
--- drivers/net/hamradio/6pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/hamradio/6pack.c +1 -1
@@ -915,7 +915,7 @@ static void decode_prio_command(struct sprintk (KERN_DEBUG "6pack: protocol violation\n" ); else sp->status = 0; - cmd &= !SIXP_RX_DCD_MASK ; + cmd &= ~SIXP_RX_DCD_MASK ; } sp->status = cmd &SIXP_PRIO_DATA_MASK ; }else {/* output watchdog char if idle */
From: Ralf Baechle <[email protected]>
Date: Thu, 23 Nov 2006 18:30:23 +0000
Quoted 5 lines
Looks like a broken masking to me, binary not is used where bitwise not was intended.
Signed-off-by Jean Delvare <[email protected]>Signed-off-by Ralf Baechle <[email protected]>
Jeff, I've got this one.
Applied, thanks a lot!