Skip to contentSkip to conversation

Provide dummy hard_irq_enable/disable() for PPC32

PATCH In review Michael Ellerman 2 participants 2 messages Nov 26, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Provide dummy hard_irq_enable/disable() for PPC32

To allow arch/powerpc/kernel/crash.c to build on 32-bit we need a definition of hard_irq_disable(). 32-bit doesn't support the lazy interrupt disabling mechanism, so on 32-bit hard_irq_disable() is simply local_irq_disable(). Add a definition for hard_irq_enable() just for completeness.

This allows (KEXEC=y && PPC32=y) to build again. Broken since d04c56f73c30a5e593202ecfcf25ed43d42363a2.

---
Paulus,

if this is OK by you, I think it should probably go in for 2.6.19.

---
 include/asm-powerpc/hw_irq.h |    3 +++
 1 file changed, 3 insertions(+)
include/asm-powerpc/hw_irq.h +3 -0
Index: powerpc/include/asm-powerpc/hw_irq.h
===================================================================
@@ -92,6 +92,9 @@ static inline void local_irq_save_ptr(un
 #define local_irq_save(flags)	local_irq_save_ptr(&flags)
 #define irqs_disabled()		((mfmsr() & MSR_EE) == 0)
 
+#define hard_irq_enable()	local_irq_enable()
+#define hard_irq_disable()	local_irq_disable()
+
 #endif /* CONFIG_PPC64 */
 
 #define mask_irq(irq)						\
#1 lore raw
Quoted 6 lines · Michael Ellerman

To allow arch/powerpc/kernel/crash.c to build on 32-bit we need a definition of hard_irq_disable(). 32-bit doesn't support the lazy interrupt disabling mechanism, so on 32-bit hard_irq_disable() is simply local_irq_disable(). Add a definition for hard_irq_enable() just for completeness.

Quoted 8 lines

This allows (KEXEC=y && PPC32=y) to build again. Broken since d04c56f73c30a5e593202ecfcf25ed43d42363a2.

---
Paulus,

if this is OK by you, I think it should probably go in for 2.6.19.

d04c56f73c30a5e593202ecfcf25ed43d42363a2 is not in Linus' tree currently, so no need to fix it in 2.6.19 I would say...

Signature · 3 lines
Rutger Nijlunsing ---------------------------------- eludias ed dse.nl
never attribute to a conspiracy which can be explained by incompetence
----------------------------------------------------------------------