Skip to contentSkip to conversation

touch softlockup during

PATCH Dave Jones 2 participants 3 messages Nov 26, 2006

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

Sometimes the soft watchdog fires after we're done oopsing.
See http://projects.info-pull.com/mokb/MOKB-25-11-2006.html for an example.

arch/i386/kernel/traps.c renamed from arch/i386/kernel/traps.c~ +1 -0
@@ -243,6 +243,7 @@ void dump_trace(struct task_struct *task
 		stack = (unsigned long*)context->previous_esp;
 		if (!stack)
 			break;
+		touch_softlockup_watchdog();
 	}
 }
 EXPORT_SYMBOL(dump_trace);
Signature · 1 line
http://www.codemonkey.org.uk
#1 lore raw

arch/i386/kernel/traps.c void dump_trace(struct task_struct *task · line 246

Quoted 12 lines · Dave Jones

Sometimes the soft watchdog fires after we're done oopsing.
See http://projects.info-pull.com/mokb/MOKB-25-11-2006.html for an example.

arch/i386/kernel/traps.c renamed from arch/i386/kernel/traps.c~ +1 -0
@@ -243,6 +243,7 @@ void dump_trace(struct task_struct *task
 		stack = (unsigned long*)context->previous_esp;
 		if (!stack)
 			break;
+		touch_softlockup_watchdog();

These should be all touch_nmi_watchdog() (which does touch the soft watchdog too)

-Andi

author
#2 lore raw

Re: touch softlockup during stack unwinding.

Sometimes the soft watchdog fires after we're done oopsing.
See http://projects.info-pull.com/mokb/MOKB-25-11-2006.html for an example. The NMI watchdog could also fire, so tickle both watchdogs.

arch/i386/kernel/traps.c renamed from arch/i386/kernel/traps.c~ +2 -0
@@ -29,6 +29,7 @@
 #include <linux/kexec.h>
 #include <linux/unwind.h>
 #include <linux/uaccess.h>
+#include <linux/nmi.h>
 
 #ifdef CONFIG_EISA
 #include <linux/ioport.h>
@@ -247,6 +247,7 @@ void dump_trace(struct task_struct *task
 		stack = (unsigned long*)context->previous_esp;
 		if (!stack)
 			break;
+		touch_nmi_watchdog();
 	}
 }
 EXPORT_SYMBOL(dump_trace);
Signature · 1 line
http://www.codemonkey.org.uk