Skip to contentSkip to conversation

sctp: fix crypto_alloc_hash() error check

PATCH New Akinobu Mita 1 participant 1 message Nov 27, 2006

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sctp: fix crypto_alloc_hash() error check

The return value of crypto_alloc_hash() should be checked by IS_ERR().

---
 net/sctp/socket.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
net/sctp/socket.c +2 -2
Index: work-fault-inject/net/sctp/socket.c
===================================================================
@@ -4885,8 +4885,8 @@ int sctp_inet_listen(struct socket *sock
 	/* Allocate HMAC for generating cookie. */
 	if (sctp_hmac_alg) {
 		tfm = crypto_alloc_hash(sctp_hmac_alg, 0, CRYPTO_ALG_ASYNC);
-		if (!tfm) {
-			err = -ENOSYS;
+		if (IS_ERR(tfm)) {
+			err = PTR_ERR(tfm);
 			goto out;
 		}
 	}