spi: check platform_device_register_simple() error
PATCH 1/1 spi: check platform_device_register_simple() error
This patch checks the return value of platform_device_register_simple().
--- drivers/spi/spi_butterfly.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/spi/spi_butterfly.c +2 -0
@@ -250,6 +250,8 @@ static void butterfly_attach(struct parp* setting up a platform device like this is an ugly kluge... */ pdev =platform_device_register_simple ("butterfly" ,-1 ,NULL ,0 ); +if (IS_ERR (pdev)) +return ; master =spi_alloc_master (&pdev->dev,sizeof *pp);if (!master) {
Quoted 4 lines · Akinobu Mita
This patch checks the return value of
platform_device_register_simple().Cc David Brownell <[email protected]>Signed-off-by Akinobu Mita <[email protected]>
... thanks, good catch.
Quoted 19 lines
--- drivers/spi/spi_butterfly.c | 2 ++ 1 file changed, 2 insertions(+)Index:
work-fault-inject/drivers/spi/spi_butterfly.c
===================================================================drivers/spi/spi_butterfly.c +2
-0@@ -250,6 +250,8 @@ static void butterfly_attach(struct parp* setting up a platform device like this is an ugly kluge... */ pdev =platform_device_register_simple ("butterfly" ,-1 ,NULL ,0 ); +if (IS_ERR (pdev)) +return ; master =spi_alloc_master (&pdev->dev,sizeof *pp);if (!master) {
Quoted 14 lines · On Mon, 27 Nov 2006 14:09:15 +0900 Akinobu Mita <[email protected]> wrote:
This patch checks the return value of
platform_device_register_simple().Cc David Brownell <[email protected]>Signed-off-by Akinobu Mita <[email protected]>--- drivers/spi/spi_butterfly.c | 2 ++ 1 file changed, 2 insertions(+)Index:
work-fault-inject/drivers/spi/spi_butterfly.c
===================================================================
drivers/spi/spi_butterfly.c static void butterfly_attach(struct parp · line 254
Quoted 5 lines
drivers/spi/spi_butterfly.c +2
-0@@ -250,6 +250,8 @@ static void butterfly_attach(struct parp* setting up a platform device like this is an ugly kluge... */ pdev =platform_device_register_simple ("butterfly" ,-1 ,NULL ,0 ); +if (IS_ERR (pdev)) +return ;
It'd be nice to at least print some (non-debug) message rather than simply mysteriously failing.
It'd be nicer if parport_driver.attach() didn't return void. Ho hum.