Skip to contentSkip to conversation

use msleep_interruptable() instead of ssleep() aka msleep()

PATCH Applied Horms 3 participants 4 messages Nov 28, 2006 – Dec 11, 2006

Subsystems (2)
lore
Share & tools
lore

Horms

author
#0 lore raw

PATCH 1/1 use msleep_interruptable() instead of ssleep() aka msleep()

Dean Manners notices that when an IPVS synchonisation daemons are started the system load slowly climbs up to 1. This seems to be related to the call to ssleep(1) (aka msleep(1000) in the main loop. Replacing this with a call to msleep_interruptable() seems to make the problem go away. Though I'm not sure that it is correct.

net/ipv4/ipvs/ip_vs_sync.c +1 -1
Index: linux-2.6/net/ipv4/ipvs/ip_vs_sync.c
===================================================================
@@ -657,7 +657,7 @@
 		if (stop_master_sync)
 			break;
 
-		ssleep(1);
+		msleep_interruptible(1000);
 	}
 
 	/* clean up the sync_buff queue */
#1 lore raw

Hello,

Quoted 5 lines · Horms

Dean Manners notices that when an IPVS synchonisation daemons are started the system load slowly climbs up to 1. This seems to be related to the call to ssleep(1) (aka msleep(1000) in the main loop. Replacing this with a call to msleep_interruptable() seems to make the problem go away. Though I'm not sure that it is correct.

The same is needed for sync_backup_loop

net/ipv4/ipvs/ip_vs_sync.c line 660

Quoted 2 lines
net/ipv4/ipvs/ip_vs_sync.c +1 -1
-		ssleep(1);
+		msleep_interruptible(1000);

Regards

--
Julian Anastasov <[email protected]>

author
#2 lore raw
Quoted 5 lines · Julian Anastasov

Hello,

On Tue, 28 Nov 2006, Horms wrote:

Quoted 7 lines
Quoted 5 lines

Dean Manners notices that when an IPVS synchonisation daemons are started the system load slowly climbs up to 1. This seems to be related to the call to ssleep(1) (aka msleep(1000) in the main loop. Replacing this with a call to msleep_interruptable() seems to make the problem go away. Though I'm not sure that it is correct.

The same is needed for sync_backup_loop

Good point. It also seems as well to change it in fork_sync_thread() and start_sync_thread(), though these are unlikely to be causing a problem.

Signature · 58 lines
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

Dean Manners notices that when an IPVS synchonisation daemons are
started the system load slowly climbs up to 1. This seems to be related
to the call to ssleep(1) (aka msleep(1000) in the main loop. Replacing
this with a call to msleep_interruptable() seems to make the problem go
away. Though I'm not sure that it is correct.

This is the second edition of this patch, which replaces ssleep()
in the main loop for both the master and backup threads, as well
as some thread synchronisation code. The latter is just for thorougness
as it shouldn't be causing any problems.

Cc: Dean Manners <[email protected]>
Cc: Julian Anastasov <[email protected]>
Signed-Off-By: Simon Horman <[email protected]>

Index: linux-2.6/net/ipv4/ipvs/ip_vs_sync.c
===================================================================
--- linux-2.6.orig/net/ipv4/ipvs/ip_vs_sync.c	2006-11-28 15:30:00.000000000 +0900
+++ linux-2.6/net/ipv4/ipvs/ip_vs_sync.c	2006-11-29 09:46:27.000000000 +0900
@@ -657,7 +657,7 @@
 		if (stop_master_sync)
 			break;
 
-		ssleep(1);
+		msleep_interruptible(1000);
 	}
 
 	/* clean up the sync_buff queue */
@@ -714,7 +714,7 @@
 		if (stop_backup_sync)
 			break;
 
-		ssleep(1);
+		msleep_interruptible(1000);
 	}
 
 	/* release the sending multicast socket */
@@ -826,7 +826,7 @@
 	if ((pid = kernel_thread(sync_thread, startup, 0)) < 0) {
 		IP_VS_ERR("could not create sync_thread due to %d... "
 			  "retrying.\n", pid);
-		ssleep(1);
+		msleep_interruptible(1000);
 		goto repeat;
 	}
 
@@ -860,7 +860,7 @@
 	if ((pid = kernel_thread(fork_sync_thread, &startup, 0)) < 0) {
 		IP_VS_ERR("could not create fork_sync_thread due to %d... "
 			  "retrying.\n", pid);
-		ssleep(1);
+		msleep_interruptible(1000);
 		goto repeat;
 	}
maintainer Applied
#3 lore raw

From: Horms <[email protected]>
Date: Wed, 29 Nov 2006 09:58:35 +0900

Quoted 12 lines · Julian Anastasov
Quoted 11 lines

Hello,

Quoted 5 lines · Horms

Dean Manners notices that when an IPVS synchonisation daemons are started the system load slowly climbs up to 1. This seems to be related to the call to ssleep(1) (aka msleep(1000) in the main loop. Replacing this with a call to msleep_interruptable() seems to make the problem go away. Though I'm not sure that it is correct.

Quoted 4 lines
Quoted 1 line

The same is needed for sync_backup_loop

Good point. It also seems as well to change it in fork_sync_thread() and start_sync_thread(), though these are unlikely to be causing a problem.

Applied, thanks Simon.