Skip to contentSkip to conversation

Fix build error

SAA9730 Ralf Baechle 2 participants 3 messages Nov 28, 2006 – Nov 29, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Confusingly NET_PCI is also set for for non-PCI EISA configurations where building this driver will result in a build error due to a reference to pci_release_regions.

While at it, remove the EXPERIMENTAL - in all its uglyness and despite the sincerest attempts of the buggy hardware the driver is known to work and limit the driver to the Atlas board - the only known system to ever use the SAA9730 before Phillips ended the short live of the SAA9730.

drivers/net/Kconfig +1 -1
index 4f22c8e..6b5b745 100644
@@ -1762,7 +1762,7 @@ config VIA_RHINE_NAPI
 
 config LAN_SAA9730
 	bool "Philips SAA9730 Ethernet support (EXPERIMENTAL)"
-	depends on NET_PCI && EXPERIMENTAL && MIPS
+	depends on NET_PCI && PCI && MIPS_ATLAS
 	help
 	  The SAA9730 is a combined multimedia and peripheral controller used
 	  in thin clients, Internet access terminals, and diskless
#1 lore raw
Quoted 5 lines · Ralf Baechle

Confusingly NET_PCI is also set for for non-PCI EISA configurations where building this driver will result in a build error due to a reference to pci_release_regions.

While at it, remove the EXPERIMENTAL - in all its uglyness and despite

Please also remove the EXPERIMENTAL from the help text.

Quoted 11 lines

the sincerest attempts of the buggy hardware the driver is known to work and limit the driver to the Atlas board - the only known system to ever use the SAA9730 before Phillips ended the short live of the SAA9730.

drivers/net/Kconfig +0 -0
index 4f22c8e..6b5b745 100644

drivers/net/Kconfig config VIA_RHINE_NAPI · line 1768

Quoted 8 lines
drivers/net/Kconfig +1 -1
@@ -1762,7 +1762,7 @@ config VIA_RHINE_NAPI
 
 config LAN_SAA9730
 	bool "Philips SAA9730 Ethernet support (EXPERIMENTAL)"
-	depends on NET_PCI && EXPERIMENTAL && MIPS
+	depends on NET_PCI && PCI && MIPS_ATLAS
 	help
 	  The SAA9730 is a combined multimedia and peripheral controller used
 	  in thin clients, Internet access terminals, and diskless

cu
Adrian

Signature · 4 lines
       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed
#2 lore raw

Confusingly NET_PCI is also set for for non-PCI EISA configurations where building this driver will result in a build error due to a reference to pci_release_regions.

While at it, remove the EXPERIMENTAL - in all its uglyness and despite the sincerest attempts of the buggy hardware the driver is known to work. Also limit the driver to the Atlas board - the only known system to ever use the SAA9730 before Phillips ended the short live of the SAA9730.

drivers/net/Kconfig +2 -2
index 4f22c8e..c80eb79 100644
@@ -1761,8 +1761,8 @@ config VIA_RHINE_NAPI
 	  information.
 
 config LAN_SAA9730
-	bool "Philips SAA9730 Ethernet support (EXPERIMENTAL)"
-	depends on NET_PCI && EXPERIMENTAL && MIPS
+	bool "Philips SAA9730 Ethernet support"
+	depends on NET_PCI && PCI && MIPS_ATLAS
 	help
 	  The SAA9730 is a combined multimedia and peripheral controller used
 	  in thin clients, Internet access terminals, and diskless