fs/sysv/: proper prototypes for 2 functions
PATCH 1/1 fs/sysv/: proper prototypes for 2 functions
This patch adds proper prototypes for sysv_{init,destroy}_icache() in sysv.h
Signed-off-by Adrian Bunk <[email protected]>
---
fs/sysv/super.c | 3 --- fs/sysv/sysv.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-)
fs/sysv/sysv.h renamed from fs/sysv/sysv.h.old +3 -0
@@ -143,6 +143,9 @@extern int sysv_sync_file (struct file *,struct dentry *,int );extern void sysv_set_inode (struct inode *,dev_t );extern int sysv_getattr (struct vfsmount *,struct dentry *,struct kstat *); +int sysv_init_icache (void ); +void sysv_destroy_icache (void ); +/* dir.c */ extern struct sysv_dir_entry *sysv_find_entry (struct dentry *,struct page **);
fs/sysv/super.c renamed from fs/sysv/super.c.old +0 -3
@@ -528,9 +528,6 @@ .fs_flags = FS_REQUIRES_DEV, }; -extern int sysv_init_icache (void )__init ; -extern void sysv_destroy_icache (void ); -static int __init init_sysv_fs (void ) {int error;
Quoted 14 lines · Adrian Bunk
This patch adds proper prototypes for sysv_{init,destroy}_icache() in
sysv.hSigned-off-by Adrian Bunk <[email protected]>---
fs/sysv/super.c | 3 --- fs/sysv/sysv.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-)
fs/sysv/sysv.h line 147
Quoted 5 lines
fs/sysv/sysv.h renamed from fs/sysv/sysv.h.old +2
-0@@ -143,6 +143,9 @@extern int sysv_sync_file (struct file *,struct dentry *,int );extern void sysv_set_inode (struct inode *,dev_t );extern int sysv_getattr (struct vfsmount *,struct dentry *,struct kstat *); +int sysv_init_icache (void ); +void sysv_destroy_icache (void );
Please follow the style used in the rest of the file and add the extern keyword.
fs/sysv/sysv.h line 148
Quoted 1 line
fs/sysv/sysv.h renamed from fs/sysv/sysv.h.old +1
-0+
And don't add a superflous blank line.
Except for that the patch is fine.
Quoted 12 lines · Christoph Hellwig
Quoted 11 lines · Adrian Bunk
This patch adds proper prototypes for sysv_{init,destroy}_icache() in
sysv.hSigned-off-by Adrian Bunk <[email protected]>---
fs/sysv/super.c | 3 --- fs/sysv/sysv.h | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-)
Quoted 11 lines
fs/sysv/sysv.h line 147
Quoted 8 lines
fs/sysv/sysv.h renamed from fs/sysv/sysv.h.old +2
-0@@ -143,6 +143,9 @@extern int sysv_sync_file (struct file *,struct dentry *,int );extern void sysv_set_inode (struct inode *,dev_t );extern int sysv_getattr (struct vfsmount *,struct dentry *,struct kstat *); +int sysv_init_icache (void ); +void sysv_destroy_icache (void );Please follow the style used in the rest of the file and add the extern keyword.
Is it acceptable to remove all the extern's instead?
Quoted 5 lines
fs/sysv/sysv.h line 148
Quoted 1 line
fs/sysv/sysv.h renamed from fs/sysv/sysv.h.old +1
-0+And don't add a superflous blank line.
Except for that the patch is fine.
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed