Skip to contentSkip to conversation

alternatives/paravirt: use NULL for pointers

PATCH In review Randy Dunlap 2 participants 2 messages Nov 29, 2006 – Nov 30, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 alternatives/paravirt: use NULL for pointers

From: Randy Dunlap <[email protected]>

Use NULL instead of 0 for pointers.

arch/x86_64/kernel/../../i386/kernel/alternative.c:432:18: warning: Using plain integer as NULL pointer arch/x86_64/kernel/../../i386/kernel/alternative.c:432:44: warning: Using plain integer as NULL pointer

---
 include/asm-i386/alternative.h   |    5 +++--
 include/asm-x86_64/alternative.h |    5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)
include/asm-i386/alternative.h +3 -2
@@ -5,6 +5,7 @@
 
 #include <asm/types.h>
 
+#include <linux/stddef.h>
 #include <linux/types.h>
 
 struct alt_instr {
@@ -125,8 +126,8 @@ void apply_paravirt(struct paravirt_patc
 static inline void
 apply_paravirt(struct paravirt_patch *start, struct paravirt_patch *end)
 {}
-#define __start_parainstructions 0
-#define __stop_parainstructions 0
+#define __start_parainstructions NULL
+#define __stop_parainstructions NULL
 #endif
 
 #endif /* _I386_ALTERNATIVE_H */
include/asm-x86_64/alternative.h +3 -2
@@ -3,6 +3,7 @@
 
 #ifdef __KERNEL__
 
+#include <linux/stddef.h>
 #include <linux/types.h>
 #include <asm/cpufeature.h>
 
@@ -140,8 +141,8 @@ void apply_paravirt(struct paravirt_patc
 static inline void
 apply_paravirt(struct paravirt_patch *start, struct paravirt_patch *end)
 {}
-#define __start_parainstructions 0
-#define __stop_parainstructions 0
+#define __start_parainstructions NULL
+#define __stop_parainstructions NULL
 #endif
 
 #endif /* _X86_64_ALTERNATIVE_H */

---

#1 lore raw
Quoted 6 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Use NULL instead of 0 for pointers.

arch/x86_64/kernel/../../i386/kernel/alternative.c:432:18: warning: Using plain integer as NULL pointer arch/x86_64/kernel/../../i386/kernel/alternative.c:432:44: warning: Using plain integer as NULL pointer

I fixed it in the original patch thanks

-Andi