mv643xx add missing brackets
Subsystems (2)
PATCH 1/1 mv643xx add missing brackets
Hello,
This patch adds missing brackets.
Signed-off-by Mariusz Kozlowski <[email protected]>
include/linux/mv643xx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/mv643xx.h +2 -2
@@ -724,7 +724,7 @@#define MV643XX_ETH_RX_FIFO_URGENT_THRESHOLD_REG (port) (0x2470 + (port<<10))#define MV643XX_ETH_TX_FIFO_URGENT_THRESHOLD_REG (port) (0x2474 + (port<<10))#define MV643XX_ETH_RX_MINIMAL_FRAME_SIZE_REG (port) (0x247c + (port<<10)) -#define MV643XX_ETH_RX_DISCARDED_FRAMES_COUNTER (port) (0x2484 + (port<<10) +#define MV643XX_ETH_RX_DISCARDED_FRAMES_COUNTER (port) (0x2484 + (port<<10))#define MV643XX_ETH_PORT_DEBUG_0_REG (port) (0x248c + (port<<10))#define MV643XX_ETH_PORT_DEBUG_1_REG (port) (0x2490 + (port<<10))#define MV643XX_ETH_PORT_INTERNAL_ADDR_ERROR_REG (port) (0x2494 + (port<<10))
@@ -1135,7 +1135,7 @@ struct mv64xxx_i2c_pdata {#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_1 (1<<19)#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_2 (1<<20)#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_3 ((1<<20) | (1<<19)) -#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 ((1<<21) +#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 ((1<<21))#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_5 ((1<<21) | (1<<19))#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_6 ((1<<21) | (1<<20))#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_7 ((1<<21) | (1<<20) | (1<<19))
Signature · 3 lines
Regards, Mariusz Kozlowski
Quoted 12 lines · Mariusz Kozlowski
Hello,
This patch adds missing brackets.
Signed-off-by Mariusz Kozlowski <[email protected]>include/linux/mv643xx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/mv643xx.h line 727
Quoted 5 lines
include/linux/mv643xx.h +1
-1@@ -724,7 +724,7 @@#define MV643XX_ETH_RX_FIFO_URGENT_THRESHOLD_REG (port) (0x2470 + (port<<10))#define MV643XX_ETH_TX_FIFO_URGENT_THRESHOLD_REG (port) (0x2474 + (port<<10))#define MV643XX_ETH_RX_MINIMAL_FRAME_SIZE_REG (port) (0x247c + (port<<10)) -#define MV643XX_ETH_RX_DISCARDED_FRAMES_COUNTER (port) (0x2484 + (port<<10) +#define MV643XX_ETH_RX_DISCARDED_FRAMES_COUNTER (port) (0x2484 + (port<<10))
Good. Thanks.
include/linux/mv643xx.h struct mv64xxx_i2c_pdata { · line 1138
Quoted 9 lines
include/linux/mv643xx.h +1
-1#define MV643XX_ETH_PORT_DEBUG_0_REG (port) (0x248c + (port<<10))#define MV643XX_ETH_PORT_DEBUG_1_REG (port) (0x2490 + (port<<10))#define MV643XX_ETH_PORT_INTERNAL_ADDR_ERROR_REG (port) (0x2494 + (port<<10))@@ -1135,7 +1135,7 @@ struct mv64xxx_i2c_pdata {#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_1 (1<<19)#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_2 (1<<20)#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_3 ((1<<20) | (1<<19)) -#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 ((1<<21) +#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 ((1<<21))
Mariusz, please remove the extra parenthesis instead of adding an extra one, like:
#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 (1<<21)
and resubmit.
Thanks,
-Dale
Quoted 6 lines
Quoted 1 line
+#define
MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4((1<<21))Mariusz, please remove the extra parenthesis instead of adding an extra one, like:
#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 (1<<21)and resubmit.
Sure. Here it goes. Second try:
This patch fixes some mv643xx macros.
Signed-off-by Mariusz Kozlowski <[email protected]>
include/linux/mv643xx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/mv643xx.h +2 -2
@@ -724,7 +724,7 @@#define MV643XX_ETH_RX_FIFO_URGENT_THRESHOLD_REG (port) (0x2470 + (port<<10))#define MV643XX_ETH_TX_FIFO_URGENT_THRESHOLD_REG (port) (0x2474 + (port<<10))#define MV643XX_ETH_RX_MINIMAL_FRAME_SIZE_REG (port) (0x247c + (port<<10)) -#define MV643XX_ETH_RX_DISCARDED_FRAMES_COUNTER (port) (0x2484 + (port<<10) +#define MV643XX_ETH_RX_DISCARDED_FRAMES_COUNTER (port) (0x2484 + (port<<10))#define MV643XX_ETH_PORT_DEBUG_0_REG (port) (0x248c + (port<<10))#define MV643XX_ETH_PORT_DEBUG_1_REG (port) (0x2490 + (port<<10))#define MV643XX_ETH_PORT_INTERNAL_ADDR_ERROR_REG (port) (0x2494 + (port<<10))
@@ -1135,7 +1135,7 @@ struct mv64xxx_i2c_pdata {#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_1 (1<<19)#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_2 (1<<20)#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_3 ((1<<20) | (1<<19)) -#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 ((1<<21) +#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 (1<<21)#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_5 ((1<<21) | (1<<19))#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_6 ((1<<21) | (1<<20))#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_7 ((1<<21) | (1<<20) | (1<<19))
Signature · 3 lines
Regards, Mariusz Kozlowski
PATCH 1/1 mv643xx_eth: fix unbalanced parentheses in macros
From: Mariusz Kozlowski <[email protected]>
Signed-off-by Mariusz Kozlowski <[email protected]>
Signed-off-by Dale Farnsworth <[email protected]>
--- include/linux/mv643xx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
include/linux/mv643xx.h +2 -2
@@ -724,7 +724,7 @@#define MV643XX_ETH_RX_FIFO_URGENT_THRESHOLD_REG (port) (0x2470 + (port<<10))#define MV643XX_ETH_TX_FIFO_URGENT_THRESHOLD_REG (port) (0x2474 + (port<<10))#define MV643XX_ETH_RX_MINIMAL_FRAME_SIZE_REG (port) (0x247c + (port<<10)) -#define MV643XX_ETH_RX_DISCARDED_FRAMES_COUNTER (port) (0x2484 + (port<<10) +#define MV643XX_ETH_RX_DISCARDED_FRAMES_COUNTER (port) (0x2484 + (port<<10))#define MV643XX_ETH_PORT_DEBUG_0_REG (port) (0x248c + (port<<10))#define MV643XX_ETH_PORT_DEBUG_1_REG (port) (0x2490 + (port<<10))#define MV643XX_ETH_PORT_INTERNAL_ADDR_ERROR_REG (port) (0x2494 + (port<<10))
@@ -1135,7 +1135,7 @@ struct mv64xxx_i2c_pdata {#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_1 (1<<19)#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_2 (1<<20)#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_3 ((1<<20) | (1<<19)) -#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 ((1<<21) +#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_4 (1<<21)#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_5 ((1<<21) | (1<<19))#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_6 ((1<<21) | (1<<20))#define MV643XX_ETH_DEFAULT_RX_UDP_QUEUE_7 ((1<<21) | (1<<20) | (1<<19))