r8169: Fix iteration variable sign
Subsystems (2)
PATCH 1/1 r8169: Fix iteration variable sign
This changes the type of variable "i" in rtl8169_init_one() from "unsigned int" to "int". "i" is checked for <0 later, which can never happen for "unsigned". This results in broken error handling.
drivers/net/r8169.c +2 -2
@@ -1473,8 +1473,8 @@ rtl8169_init_one(struct pci_dev *pdev, cstruct rtl8169_private *tp;struct net_device *dev;void __iomem *ioaddr; -unsigned int i, pm_cap; -int rc; +unsigned int pm_cap; +int i, rc;if (netif_msg_drv (&debug)) { printk(KERN_INFO "%s Gigabit Ethernet driver %s loaded\n",
Signature · 1 line
Greetings Michael.
PATCH 1/1 r8169: Fix iteration variable sign
This changes the type of variable "i" in rtl8169_init_one() from "unsigned int" to "int". "i" is checked for < 0 later, which can never happen for "unsigned". This results in broken error handling.
drivers/net/r8169.c +2 -2
@@ -1491,8 +1491,8 @@ rtl8169_init_one(struct pci_dev *pdev, cstruct rtl8169_private *tp;struct net_device *dev;void __iomem *ioaddr; -unsigned int i, pm_cap; -int rc; +unsigned int pm_cap; +int i, rc;if (netif_msg_drv (&debug)) { printk(KERN_INFO "%s Gigabit Ethernet driver %s loaded\n",
Quoted 7 lines · Francois Romieu
This changes the type of variable "i" in
rtl8169_init_one()from "unsigned int" to "int". "i" is checked for < 0 later, which can never happen for "unsigned". This results in broken error handling.Signed-off-by Michael Buesch <[email protected]>Signed-off-by Francois Romieu <[email protected]>
ACK but doesn't seem to apply to 2.6.19?
should this go into #upstream rather than #upstream-fixes?
Quoted 6 lines · Jeff Garzik
Quoted 5 lines · Francois Romieu
This changes the type of variable "i" in
rtl8169_init_one()from "unsigned int" to "int". "i" is checked for < 0 later, which can never happen for "unsigned". This results in broken error handling.
Quoted 6 lines
Quoted 2 lines
Signed-off-by Michael Buesch <[email protected]>Signed-off-by Francois Romieu <[email protected]>ACK but doesn't seem to apply to 2.6.19?
should this go into #upstream rather than #upstream-fixes?
Hm, I did this against latest linus' tree.
Signature · 1 line
Greetings Michael.
Jeff Garzik <[email protected]> :
[...]
Quoted 1 line
should this go into #upstream rather than #upstream-fixes?
It's already in.
The attribution does not follow the ordering of the Signed-off-by but the S-o-b are fine.
Signature · 1 line
Ueimor