CPU hotplug broken with 2GB VMSPLIT
Hi,
Just got a new notebook (Lenovo X60), setup a custom kernel and then I noticed that suspend to ram doesn't work anymore. The machine suspends just fine, on resume it brings back the text display but reboots after it has stalled for a few seconds. On the suggestion of Pavel, I tried testing CPU hotplug, and indeed he was right: I can offline 1 of the cores fine, bringing it back online freezes the machine for 3-4 seconds and then reboots.
carl:/sys/devices/system/cpu/cpu1 # echo 0 > online carl:/sys/devices/system/cpu/cpu1 # dmesg Breaking affinity for irq 219
CPU 1 is now offline
SMP alternatives: switching to UP code carl:/sys/devices/system/cpu/cpu1 # echo 1 > online Read from remote host carl: Connection reset by peer
Booting with maxcpus=1 and resume works fine. Does this ring a bell with anyone? With highmem enabled and the standard vmsplit, cpu hotplug works fine for me.
Signature · 1 line
Jens Axboe
Quoted 18 lines · Jens Axboe
Hi,
Just got a new notebook (Lenovo X60), setup a custom kernel and then I noticed that suspend to ram doesn't work anymore. The machine suspends just fine, on resume it brings back the text display but reboots after it has stalled for a few seconds. On the suggestion of Pavel, I tried testing CPU hotplug, and indeed he was right: I can offline 1 of the cores fine, bringing it back online freezes the machine for 3-4 seconds and then reboots.
carl:/sys/devices/system/cpu/cpu1 # echo 0 > online carl:/sys/devices/system/cpu/cpu1 # dmesg Breaking affinity for irq 219
CPU 1 is now offline
SMP alternatives: switching to UP code carl:/sys/devices/system/cpu/cpu1 # echo 1 > online Read from remote host carl: Connection reset by peer
Quoted 3 lines
Booting with maxcpus=1 and resume works fine. Does this ring a bell with anyone? With highmem enabled and the standard vmsplit, cpu hotplug works fine for me.
Some more clues - booting with noreplacement doesn't fix it, so I think the alternatives code is off the hook.
Signature · 1 line
Jens Axboe
Quoted 19 lines · Jens Axboe
Quoted 18 lines · Jens Axboe
Hi,
Just got a new notebook (Lenovo X60), setup a custom kernel and then I noticed that suspend to ram doesn't work anymore. The machine suspends just fine, on resume it brings back the text display but reboots after it has stalled for a few seconds. On the suggestion of Pavel, I tried testing CPU hotplug, and indeed he was right: I can offline 1 of the cores fine, bringing it back online freezes the machine for 3-4 seconds and then reboots.
carl:/sys/devices/system/cpu/cpu1 # echo 0 > online carl:/sys/devices/system/cpu/cpu1 # dmesg Breaking affinity for irq 219
CPU 1 is now offline
SMP alternatives: switching to UP code carl:/sys/devices/system/cpu/cpu1 # echo 1 > online Read from remote host carl: Connection reset by peer
Quoted 6 lines
Quoted 3 lines
Booting with maxcpus=1 and resume works fine. Does this ring a bell with anyone? With highmem enabled and the standard vmsplit, cpu hotplug works fine for me.
Some more clues - booting with noreplacement doesn't fix it, so I think the alternatives code is off the hook.
I don't think this adds any new information, but it has been open awhile:
http://bugme.osdl.org/show_bug.cgi?id=6542
I was able to narrow it down to the vmsplit setting but I wasn't able to debug it further.
Hi!
Quoted 10 lines
Quoted 2 lines
Some more clues - booting with noreplacement doesn't fix it, so I think the alternatives code is off the hook.
I don't think this adds any new information, but it has been open awhile:
http://bugme.osdl.org/show_bug.cgi?id=6542
I was able to narrow it down to the vmsplit setting but I wasn't able to debug it further.
Can we at least add error return or something? Or make CPU_HOTPLUG depend on "normal" VM split, or...? Having s2ram breaking for known problem is annoying...
Pavel
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Quoted 27 lines · Nathan Lynch
Quoted 19 lines · Jens Axboe
Quoted 18 lines · Jens Axboe
Hi,
Just got a new notebook (Lenovo X60), setup a custom kernel and then I noticed that suspend to ram doesn't work anymore. The machine suspends just fine, on resume it brings back the text display but reboots after it has stalled for a few seconds. On the suggestion of Pavel, I tried testing CPU hotplug, and indeed he was right: I can offline 1 of the cores fine, bringing it back online freezes the machine for 3-4 seconds and then reboots.
carl:/sys/devices/system/cpu/cpu1 # echo 0 > online carl:/sys/devices/system/cpu/cpu1 # dmesg Breaking affinity for irq 219
CPU 1 is now offline
SMP alternatives: switching to UP code carl:/sys/devices/system/cpu/cpu1 # echo 1 > online Read from remote host carl: Connection reset by peerQuoted 6 lines
Quoted 3 lines
Booting with maxcpus=1 and resume works fine. Does this ring a bell with anyone? With highmem enabled and the standard vmsplit, cpu hotplug works fine for me.
Some more clues - booting with noreplacement doesn't fix it, so I think the alternatives code is off the hook.
Quoted 7 lines
I don't think this adds any new information, but it has been open awhile:
http://bugme.osdl.org/show_bug.cgi?id=6542
I was able to narrow it down to the vmsplit setting but I wasn't able to debug it further.
Hmm, I'm pretty sure this is the same problem I reported in March, there might be some more information in that thread:
http://marc.theaimsgroup.com/?t=114039363100002&r=1&w=1
but I didn't realize it was vmsplit-related at that time.
Quoted 44 lines · Nathan Lynch
Quoted 5 lines · Nathan Lynch
Quoted 4 lines · Jens Axboe
Quoted 3 lines · Jens Axboe
Hi,
Just got a new notebook (Lenovo X60), setup a custom kernel and
then I
Quoted 1 line
Quoted 1 line
Quoted 1 line
noticed that suspend to ram doesn't work anymore. The machine
suspends
Quoted 1 line
Quoted 1 line
Quoted 1 line
just fine, on resume it brings back the text display but reboots
after
Quoted 1 line
Quoted 1 line
Quoted 1 line
it has stalled for a few seconds. On the suggestion of Pavel, I
tried
Quoted 1 line
Quoted 1 line
Quoted 1 line
testing CPU hotplug, and indeed he was right: I can offline 1 of
the
Quoted 1 line
Quoted 1 line
Quoted 1 line
cores fine, bringing it back online freezes the machine for 3-4
seconds
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
and then reboots.
carl:/sys/devices/system/cpu/cpu1 # echo 0 > online carl:/sys/devices/system/cpu/cpu1 # dmesg Breaking affinity for irq 219
CPU 1 is now offline
SMP alternatives: switching to UP code carl:/sys/devices/system/cpu/cpu1 # echo 1 > online Read from remote host carl: Connection reset by peerBooting with maxcpus=1 and resume works fine. Does this ring a
bell with
Quoted 1 line
Quoted 1 line
Quoted 1 line
anyone? With highmem enabled and the standard vmsplit, cpu
hotplug works
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
fine for me.
Some more clues - booting with noreplacement doesn't fix it, so I
think
Quoted 8 lines
Quoted 1 line
the alternatives code is off the hook.
I don't think this adds any new information, but it has been open awhile:
http://bugme.osdl.org/show_bug.cgi?id=6542
I was able to narrow it down to the vmsplit setting but I wasn't
able
Quoted 8 lines
Quoted 1 line
to debug it further.
Hmm, I'm pretty sure this is the same problem I reported in March, there might be some more information in that thread:
http://marc.theaimsgroup.com/?t=114039363100002&r=1&w=1
but I didn't realize it was vmsplit-related at that time.
Does this patch help?
Thanks,
Shaohua
arch/i386/kernel/smpboot.c +1 -1
@@ -1095,7 +1095,7 @@ static int __cpuinit __smp_prepare_cpu(i/* init low mem mapping */ clone_pgd_range (swapper_pg_dir, swapper_pg_dir +USER_PGD_PTRS , -KERNEL_PGD_PTRS ); + min_t(unsigned long, KERNEL_PGD_PTRS, USER_PGD_PTRS));flush_tlb_all ();schedule_work (&task);wait_for_completion (&done);
Quoted 47 lines · Shaohua Li
Quoted 46 lines · Nathan Lynch
Quoted 5 lines · Nathan Lynch
Quoted 4 lines · Jens Axboe
Quoted 3 lines · Jens Axboe
Hi,
Just got a new notebook (Lenovo X60), setup a custom kernel and
then I
Quoted 1 line
Quoted 1 line
Quoted 1 line
noticed that suspend to ram doesn't work anymore. The machine
suspends
Quoted 1 line
Quoted 1 line
Quoted 1 line
just fine, on resume it brings back the text display but reboots
after
Quoted 1 line
Quoted 1 line
Quoted 1 line
it has stalled for a few seconds. On the suggestion of Pavel, I
tried
Quoted 1 line
Quoted 1 line
Quoted 1 line
testing CPU hotplug, and indeed he was right: I can offline 1 of
the
Quoted 1 line
Quoted 1 line
Quoted 1 line
cores fine, bringing it back online freezes the machine for 3-4
seconds
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
and then reboots.
carl:/sys/devices/system/cpu/cpu1 # echo 0 > online carl:/sys/devices/system/cpu/cpu1 # dmesg Breaking affinity for irq 219
CPU 1 is now offline
SMP alternatives: switching to UP code carl:/sys/devices/system/cpu/cpu1 # echo 1 > online Read from remote host carl: Connection reset by peerBooting with maxcpus=1 and resume works fine. Does this ring a
bell with
Quoted 1 line
Quoted 1 line
Quoted 1 line
anyone? With highmem enabled and the standard vmsplit, cpu
hotplug works
Quoted 3 lines
Quoted 3 lines
Quoted 1 line
fine for me.
Some more clues - booting with noreplacement doesn't fix it, so I
think
Quoted 8 lines
Quoted 1 line
the alternatives code is off the hook.
I don't think this adds any new information, but it has been open awhile:
http://bugme.osdl.org/show_bug.cgi?id=6542
I was able to narrow it down to the vmsplit setting but I wasn't
able
Quoted 1 line
to debug it further.
Quoted 7 lines
Quoted 6 lines
Hmm, I'm pretty sure this is the same problem I reported in March, there might be some more information in that thread:
http://marc.theaimsgroup.com/?t=114039363100002&r=1&w=1
but I didn't realize it was vmsplit-related at that time.
Does this patch help?
It does! Booted a vmsplit 2G kernel again, and started with offlining and onlining CPU1. Worked fine, that would previously reboot the notebook. Then I did a suspend-to-ram -> resume cycle, worked fine as well. Thanks!
Signature · 1 line
Jens Axboe