Skip to contentSkip to conversation

arch/i386/kernel/reboot.c should #include <linux/reboot.h>

PATCH In review Adrian Bunk 2 participants 2 messages Nov 29, 2006 – Dec 1, 2006 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arch/i386/kernel/reboot.c should #include <linux/reboot.h>

Every file should #include the headers containing the prototypes for its global functions.

arch/i386/kernel/reboot.c renamed from arch/i386/kernel/reboot.c.old +1 -0
@@ -12,6 +12,7 @@
 #include <linux/dmi.h>
 #include <linux/ctype.h>
 #include <linux/pm.h>
+#include <linux/reboot.h>
 #include <asm/uaccess.h>
 #include <asm/apic.h>
 #include <asm/desc.h>
#1 lore raw
Quoted 2 lines · On Wed, 29 Nov 2006 11:04:26 +0100 Adrian Bunk <[email protected]> wrote:

Every file should #include the headers containing the prototypes for its global functions.

Makefile renamed from Makefile~add-gcc-wmissing-prototypes +1 -1
@@ -313,7 +313,7 @@ LINUXINCLUDE    := -Iinclude \
 CPPFLAGS        := -D__KERNEL__ $(LINUXINCLUDE)
 
 CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
-                   -fno-strict-aliasing -fno-common
+                   -fno-strict-aliasing -fno-common -Wmissing-prototypes
 AFLAGS          := -D__ASSEMBLY__
 
 # Read KERNELRELEASE from include/config/kernel.release (if it exists)

_

Have fun...