Skip to contentSkip to conversation

PCI: Let PCI_MULTITHREAD_PROBE not be broken

DISCUSSION Alan 1 participant 1 message Dec 2, 2006 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Alan

author NAK
#1 lore raw

Review config PCI_MSI · line 23

Quoted 7 lines · On Sat, 2 Dec 2006 00:59:44 GMT Linux Kernel Mailing List…
(quoted diff) +1 -1
@@ -19,7 +19,7 @@ config PCI_MSI
 
 config PCI_MULTITHREAD_PROBE
 	bool "PCI Multi-threaded probe (EXPERIMENTAL)"
-	depends on PCI && EXPERIMENTAL && BROKEN
+	depends on PCI && EXPERIMENTAL
 	help

NAK.

It is broken as it breaks init time ordering relied upon by many drivers for same probing and it breaks existing drive assumptions that the probe is single threaded and therefore unlocked.

At the very least it needs

	&& !IDE && !WATCHDOG && !ATA

and probably far more.

This should not be enabled or even in the upstream tree until the ordering problem is fixed and the submitter has done a review and fix of all the locking.

Alan