Bad PCI function mask in atiixp driver (was: Re: Linux 2.6.19)
In-Reply-To: <[email protected]>
Quoted 2 lines · Matthijs
make modules gives me these warnings in modpost and then errors out:
WARNING: Can't handle masks in drivers/ide/pci/atiixp:FFFF05
Message is from scripts/file2alias.c::do_pci_entry():
if ((baseclass_mask != 0 && baseclass_mask != 0xFF)
|| (subclass_mask != 0 && subclass_mask != 0xFF)
|| (interface_mask != 0 && interface_mask != 0xFF)) {
warn("Can't handle masks in %s:%04X\n",
filename, id->class_mask);
return 0;
}and it is complaining about this recent addition to atiixp.c:
@@ -348,6 +368,7 @@ static struct pci_device_id atiixp_pci_t
{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
{ PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
+ { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_SATA, PCI_ANY_ID, PCI_ANY_ID, (PCI_CLASS_STORAGE_IDE<<8)|0x8a, 0xffff05, 1},
{ 0, }, };
MODULE_DEVICE_TABLE(pci, atiixp_pci_tbl);
Signature · 2 lines
Chuck "Even supernovas have their duller moments."
Quoted 21 lines · On Sat, 2 Dec 2006 23:06:57 -0500 Chuck Ebbert wrote:
In-Reply-To: <[email protected]>
Quoted 2 lines · Matthijs
make modules gives me these warnings in modpost and then errors out:
WARNING: Can't handle masks in drivers/ide/pci/atiixp:FFFF05Message is from scripts/file2alias.c::do_pci_entry():
if ((baseclass_mask != 0 && baseclass_mask != 0xFF) || (subclass_mask != 0 && subclass_mask != 0xFF) || (interface_mask != 0 && interface_mask != 0xFF)) { warn("Can't handle masks in %s:%04X\n", filename, id->class_mask); return 0; }and it is complaining about this recent addition to
atiixp.c:
Review static struct pci_device_id atiixp_pci_t · line 374
Quoted 7 lines
(quoted diff) +1
-0@@ -348,6 +368,7 @@ static struct pci_device_id atiixp_pci_t { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP300_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP400_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_IDE, PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, + { PCI_VENDOR_ID_ATI, PCI_DEVICE_ID_ATI_IXP600_SATA, PCI_ANY_ID, PCI_ANY_ID, (PCI_CLASS_STORAGE_IDE<<8)|0x8a, 0xffff05, 1}, { 0, }, }; MODULE_DEVICE_TABLE(pci, atiixp_pci_tbl);
http://lkml.org/lkml/2006/11/01/199
However, I'm still dubious.
---
~Randy