i386/kernel/smp.c: don't use set_irq_regs()
PATCH 1/1 i386/kernel/smp.c: don't use set_irq_regs()
We don't need to setup _irq_regs in smp_xxx_interrupt (except apic timer). These handlers run with irqs disabled and do not call functions which need "struct pt_regs".
Signed-off-by Oleg Nesterov <[email protected]>
arch/i386/kernel/smp.c renamed from arch/i386/kernel/smp.c~regs +0 -6
@@ -321,7 +321,6 @@ static inline void leave_mm (unsigned lo fastcall void smp_invalidate_interrupt(struct pt_regs *regs) { -struct pt_regs *old_regs =set_irq_regs (regs);unsigned long cpu; cpu =get_cpu ();
@@ -352,7 +351,6 @@ fastcall void smp_invalidate_interrupt(ssmp_mb__after_clear_bit (); out:put_cpu_no_resched (); -set_irq_regs (old_regs); } static void flush_tlb_others(cpumask_t cpumask, struct mm_struct *mm,
@@ -607,14 +605,11 @@ void smp_send_stop(void)*/ fastcall void smp_reschedule_interrupt(struct pt_regs *regs) { -struct pt_regs *old_regs =set_irq_regs (regs);ack_APIC_irq (); -set_irq_regs (old_regs); } fastcall void smp_call_function_interrupt(struct pt_regs *regs) { -struct pt_regs *old_regs =set_irq_regs (regs);void (*func) (void *info) = call_data->func;void *info = call_data->info;int wait = call_data->wait;
@@ -637,7 +632,6 @@ fastcall void smp_call_function_interrupmb ();atomic_inc (&call_data->finished); } -set_irq_regs (old_regs); }/*
Quoted 5 lines · Oleg Nesterov
We don't need to setup
_irq_regsinsmp_xxx_interrupt(except apic timer). These handlers run with irqs disabled and do not call functions which need "structpt_regs".Signed-off-by Oleg Nesterov <[email protected]>
yeah. These are leftover inefficiencies from the ptregs conversion, which just added a regs variable to every arch-level irq handler blindly.
Acked-by Ingo Molnar <[email protected]>
Ingo
Quoted 3 lines · Oleg Nesterov
We don't need to setup
_irq_regsinsmp_xxx_interrupt(except apic timer). These handlers run with irqs disabled and do not call functions which need "structpt_regs".
Acked-by David Howells <[email protected]>