Skip to contentSkip to conversation

rt2x00: Simplify MAC copying

PATCH In review Ivo van Doorn 1 participant 1 message Dec 3, 2006

Subsystems (3)
Networking Network drivers Networking drivers (wireless)
lore
Share & tools
lore

Ivo van Doorn

author
#0 lore raw

PATCH 18/26 rt2x00: Simplify MAC copying

No set_field commands are required for the mac registers. This was previously done for the byteordering. But since the MAC is already read in the correct byteorder this had never had to happen at all anyway.

Signed-off-by Ivo van Doorn <[email protected]>

---

drivers/net/wireless/d80211/rt2x00/rt2400pci.c +5 -7
diff -rU3 wireless-dev-vendor/drivers/net/wireless/d80211/rt2x00/rt2400pci.c wireless-dev-mac/drivers/net/wireless/d80211/rt2x00/rt2400pci.c
@@ -605,13 +605,11 @@
 {
 	u32 reg[2] = { 0, 0 };
 
-	rt2x00_set_field32(&reg[0], CSR3_BYTE0, ((u8*)addr)[0]);
-	rt2x00_set_field32(&reg[0], CSR3_BYTE1, ((u8*)addr)[1]);
-	rt2x00_set_field32(&reg[0], CSR3_BYTE2, ((u8*)addr)[2]);
-	rt2x00_set_field32(&reg[0], CSR3_BYTE3, ((u8*)addr)[3]);
-	rt2x00_set_field32(&reg[1], CSR4_BYTE4, ((u8*)addr)[4]);
-	rt2x00_set_field32(&reg[1], CSR4_BYTE5, ((u8*)addr)[5]);
-
+	/*
+	 * The MAC address is passed to us as an array of bytes,
+	 * that array is little endian, so no need for byte ordering.
+	 */
+	memcpy(&reg, addr, ETH_ALEN);
 	rt2x00_register_multiwrite(rt2x00dev, CSR3, &reg[0], sizeof(reg));
 }
drivers/net/wireless/d80211/rt2x00/rt2500pci.c +5 -7
diff -rU3 wireless-dev-vendor/drivers/net/wireless/d80211/rt2x00/rt2500pci.c wireless-dev-mac/drivers/net/wireless/d80211/rt2x00/rt2500pci.c
@@ -679,13 +679,11 @@
 {
 	u32 reg[2] = { 0, 0 };
 
-	rt2x00_set_field32(&reg[0], CSR3_BYTE0, ((u8*)addr)[0]);
-	rt2x00_set_field32(&reg[0], CSR3_BYTE1, ((u8*)addr)[1]);
-	rt2x00_set_field32(&reg[0], CSR3_BYTE2, ((u8*)addr)[2]);
-	rt2x00_set_field32(&reg[0], CSR3_BYTE3, ((u8*)addr)[3]);
-	rt2x00_set_field32(&reg[1], CSR4_BYTE4, ((u8*)addr)[4]);
-	rt2x00_set_field32(&reg[1], CSR4_BYTE5, ((u8*)addr)[5]);
-
+	/*
+	 * The MAC address is passed to us as an array of bytes,
+	 * that array is little endian, so no need for byte ordering.
+	 */
+	memcpy(&reg, addr, ETH_ALEN);
 	rt2x00_register_multiwrite(rt2x00dev, CSR3, &reg[0], sizeof(reg));
 }
drivers/net/wireless/d80211/rt2x00/rt2500usb.c +5 -7
diff -rU3 wireless-dev-vendor/drivers/net/wireless/d80211/rt2x00/rt2500usb.c wireless-dev-mac/drivers/net/wireless/d80211/rt2x00/rt2500usb.c
@@ -709,13 +709,11 @@
 {
 	u16 reg[3] = { 0, 0, 0 };
 
-	rt2x00_set_field16(&reg[0], MAC_CSR2_BYTE0, ((u8*)addr)[0]);
-	rt2x00_set_field16(&reg[0], MAC_CSR2_BYTE1, ((u8*)addr)[1]);
-	rt2x00_set_field16(&reg[1], MAC_CSR3_BYTE2, ((u8*)addr)[2]);
-	rt2x00_set_field16(&reg[1], MAC_CSR3_BYTE3, ((u8*)addr)[3]);
-	rt2x00_set_field16(&reg[2], MAC_CSR4_BYTE4, ((u8*)addr)[4]);
-	rt2x00_set_field16(&reg[2], MAC_CSR4_BYTE5, ((u8*)addr)[5]);
-
+	/*
+	 * The MAC address is passed to us as an array of bytes,
+	 * that array is little endian, so no need for byte ordering.
+	 */
+	memcpy(&reg, addr, ETH_ALEN);
 	rt2x00_register_multiwrite(rt2x00dev, MAC_CSR2, &reg[0], sizeof(reg));
 }
drivers/net/wireless/d80211/rt2x00/rt61pci.c +7 -7
diff -rU3 wireless-dev-vendor/drivers/net/wireless/d80211/rt2x00/rt61pci.c wireless-dev-mac/drivers/net/wireless/d80211/rt2x00/rt61pci.c
@@ -910,14 +910,14 @@
 {
 	u32 reg[2] = { 0, 0 };
 
-	rt2x00_set_field32(&reg[0], MAC_CSR2_BYTE0, ((u8*)addr)[0]);
-	rt2x00_set_field32(&reg[0], MAC_CSR2_BYTE1, ((u8*)addr)[1]);
-	rt2x00_set_field32(&reg[0], MAC_CSR2_BYTE2, ((u8*)addr)[2]);
-	rt2x00_set_field32(&reg[0], MAC_CSR2_BYTE3, ((u8*)addr)[3]);
-	rt2x00_set_field32(&reg[1], MAC_CSR3_BYTE4, ((u8*)addr)[4]);
-	rt2x00_set_field32(&reg[1], MAC_CSR3_BYTE5, ((u8*)addr)[5]);
+	/*
+	 * The MAC address is passed to us as an array of bytes,
+	 * that array is little endian, so no need for byte ordering.
+	 * We only need to set the MAC_CSR3_UNICAST_TO_ME_MASK
+	 * at the correct offset.
+	 */
+	memcpy(&reg, addr, ETH_ALEN);
 	rt2x00_set_field32(&reg[1], MAC_CSR3_UNICAST_TO_ME_MASK, 0xff);
-
 	rt2x00_register_multiwrite(rt2x00dev, MAC_CSR2, &reg[0], sizeof(reg));
 }
drivers/net/wireless/d80211/rt2x00/rt73usb.c +7 -7
diff -rU3 wireless-dev-vendor/drivers/net/wireless/d80211/rt2x00/rt73usb.c wireless-dev-mac/drivers/net/wireless/d80211/rt2x00/rt73usb.c
@@ -808,14 +808,14 @@
 {
 	u32 reg[2] = { 0, 0 };
 
-	rt2x00_set_field32(&reg[0], MAC_CSR2_BYTE0, ((u8*)addr)[0]);
-	rt2x00_set_field32(&reg[0], MAC_CSR2_BYTE1, ((u8*)addr)[1]);
-	rt2x00_set_field32(&reg[0], MAC_CSR2_BYTE2, ((u8*)addr)[2]);
-	rt2x00_set_field32(&reg[0], MAC_CSR2_BYTE3, ((u8*)addr)[3]);
-	rt2x00_set_field32(&reg[1], MAC_CSR3_BYTE4, ((u8*)addr)[4]);
-	rt2x00_set_field32(&reg[1], MAC_CSR3_BYTE5, ((u8*)addr)[5]);
+	/*
+	 * The MAC address is passed to us as an array of bytes,
+	 * that array is little endian, so no need for byte ordering.
+	 * We only need to set the MAC_CSR3_UNICAST_TO_ME_MASK
+	 * at the correct offset.
+	 */
+	memcpy(&reg, addr, ETH_ALEN);
 	rt2x00_set_field32(&reg[1], MAC_CSR3_UNICAST_TO_ME_MASK, 0xff);
-
 	rt2x00_register_multiwrite(rt2x00dev, MAC_CSR2, &reg[0], sizeof(reg));
 }