Safely finish closing protocol when guest fails in blkfront
PATCH 1/1 Safely finish closing protocol when guest fails in blkfront
If a guest finds any error and aborts the connection of a block device, it's online state set at device create phase will stop it from being properly cleaned up.
Follows a fix for it.
Signature · 3 lines
Glauber de Oliveira Costa Red Hat Inc. "Free as in Freedom"
# HG changeset patch
# User [email protected]
# Date 1165272179 18000
# Node ID 6702c80880a1ed7e7467a59135f3764fb145cd0b # Parent fd28a1b139dea91b8bfcf06dd233dbdda8f51ff1 [LINUX] Get rid of device if block-attach fails
The current backend code checks to see if a device is online before unregistering it. However, when block attach fails due to a guest failure, guest is the one to start closing protocols, and state is never set to offline again.
Proposal is to check if there are error entries in xenstore, and unregister if it is the case.
linux-2.6-xen-sparse/drivers/xen/blkback/xenbus.c +27 -1
@@ -306,6 +306,32 @@ static void backend_changed(struct xenbu } +static int dev_had_error (struct xenbus_device *dev) +{ +int err; +unsigned int virtual_device, frontend_id; +char *path =NULL ; + + err =xenbus_scanf (XBT_NIL , dev->otherend, +"virtual-device" ,"%u" , &virtual_device); +if (err <0 ) +return 0 ; + + err =xenbus_scanf (XBT_NIL , dev->nodename, +"frontend-id" ,"%u" , &frontend_id); +if (err <0 ) +return 0 ; + + path =kasprintf (GFP_KERNEL ,"%u/error/device/vbd/%u" , + frontend_id,virtual_device); +if (!path) +return 0 ; + + err =xenbus_exists (XBT_NIL ,"/local/domain" ,path); +kfree (path); +return err; +} +/** * Callback received when the frontend's state changes. */
@@ -347,7 +373,7 @@ static void frontend_changed(struct xenbcase XenbusStateClosed:xenbus_switch_state (dev, XenbusStateClosed); -if (xenbus_dev_is_online (dev)) +if (xenbus_dev_is_online (dev) && !dev_had_error (dev))break ;/* fall through if not online */ case XenbusStateUnknown:
_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel
Quoted 5 lines · Glauber de Oliveira Costa
If a guest finds any error and aborts the connection of a block device, it's online state set at device create phase will stop it from being properly cleaned up.
Follows a fix for it.
Assignment and unassignment of physical resources is really a tools issue. Tools should really be integrated with device-hotplug success/failure anyway -- for example, it is likely the initiator would like confirmation of success/failure in most cases.
-- Keir
Quoted 6 lines · Keir Fraser
Quoted 4 lines · Glauber de Oliveira Costa
If a guest finds any error and aborts the connection of a block device, it's online state set at device create phase will stop it from being properly cleaned up.
Quoted 7 lines
Quoted 1 line
Follows a fix for it.
Assignment and unassignment of physical resources is really a tools issue. Tools should really be integrated with device-hotplug success/failure anyway -- for example, it is likely the initiator would like confirmation of success/failure in most cases.
Agree. But what if after properly initiation, frontend finds an error and starts Closing protocol? What will happen is that the test
if (xenbus_dev_is_online(dev))
will cause the device to not be unregistered. At this point, it do not see frontend changes. (putting backend in closing leads to frontend closing,closed, but backend never see frontend closing, never going to closed).
Given that, what tools can do ? At the current point, this is what leads me to believe that arbitrary frontend-failure cases should be handled in the frontend.
Signature · 3 lines
Glauber de Oliveira Costa Red Hat Inc. "Free as in Freedom"
Quoted 10 lines
Quoted 5 lines
Assignment and unassignment of physical resources is really a tools issue. Tools should really be integrated with device-hotplug success/failure anyway -- for example, it is likely the initiator would like confirmation of success/failure in most cases.
Agree. But what if after properly initiation, frontend finds an error and starts Closing protocol? What will happen is that the test
if (
xenbus_dev_is_online(dev))
Quoted 8 lines
will cause the device to not be unregistered. At this point, it do not see frontend changes. (putting backend in closing leads to frontend closing,closed, but backend never see frontend closing, never going to closed).
Given that, what tools can do ? At the current point, this is what leads me to believe that arbitrary frontend-failure cases should be handled in the frontend.
Keir,
Let me just try to clarify this. (after all, I just realised that even if this is the right path, there's a piece missing).
Right now, I think that handling failures in the frontend code is the correct choice, because failures can pretty much happen anytime . According to the diagram at
http://wiki.xensource.com/xenwiki/XenSplitDrivers, a closedown initiated by the frontend should end in the device being unregistered, and I don't think tools will _ever_ be able to do it. The best they can do is wait to see if the device is properly connected, but what if the error happens after it? If this is indeed the real scenario, the missing piece would be to delete the error message, to avoid unregistering devices that should not be unregistered.
If you can assure, that now and ever, errors in the frontend side will _always_ be constrained to the pre-Connect steps, then, my proposal is to set the online flag just after the device is connected. It would assure that device is properly unregistered, and tools would have a way to know if the process was successfull (online = 1). Any comments on that ?
I assume that I don't understand exactly the purpose of online. At first I thought it was save & restore related, but I'm currently able to save & restore with online being always 0. Can you shed some light on it ?
As soon as you answer those, I'll proceed with the right approach to fix this.
Signature · 5 lines
Glauber de Oliveira Costa. "Free as in Freedom" Add your comments to GPLv3 at: http://gplv3.fsf.org/comments/gplv3-draft-2.html