sky2: sparse warnings
Subsystems (2)
PATCH 1/1 sky2: sparse warnings
Get rid of sparse warnings in sky2 driver because of mixed enum usage.
Signed-off-by Stephen Hemminger <[email protected]>
--- drivers/net/sky2.c | 18 ++++-------------- drivers/net/sky2.h | 53 +++++++++++++++++++++++++--------------------------- 2 files changed, 29 insertions(+), 42 deletions(-)
drivers/net/sky2.c +4 -14
@@ -522,7 +522,7 @@ static void sky2_phy_init(struct sky2_hw/* set Tx LED (LED_TX) to blink mode on Rx OR Tx activity */ ledctrl |=PHY_M_LED_BLINK_RT (BLINK_84MS ) |PHY_M_LEDC_TX_CTRL ;/* turn off the Rx LED (LED_RX) */ - ledover |=PHY_M_LED_MO_RX (MO_LED_OFF ); + ledover &= ~PHY_M_LED_MO_RX ; }if (hw->chip_id ==CHIP_ID_YUKON_EC_U && hw->chip_rev ==CHIP_REV_YU_EC_A1 ) {
@@ -545,7 +545,7 @@ static void sky2_phy_init(struct sky2_hwif (sky2->autoneg ==AUTONEG_DISABLE || sky2->speed ==SPEED_100 ) {/* turn on 100 Mbps LED (LED_LINK100) */ - ledover |=PHY_M_LED_MO_100 (MO_LED_ON ); + ledover |=PHY_M_LED_MO_100 ; }if (ledover)
@@ -2917,18 +2917,8 @@ static void sky2_led(struct sky2_hw *hw,default :gm_phy_write (hw, port,PHY_MARV_LED_CTRL ,0 ); -gm_phy_write (hw, port,PHY_MARV_LED_OVER , - on ?PHY_M_LED_MO_DUP (MO_LED_ON ) | -PHY_M_LED_MO_10 (MO_LED_ON ) | -PHY_M_LED_MO_100 (MO_LED_ON ) | -PHY_M_LED_MO_1000 (MO_LED_ON ) | -PHY_M_LED_MO_RX (MO_LED_ON ) - :PHY_M_LED_MO_DUP (MO_LED_OFF ) | -PHY_M_LED_MO_10 (MO_LED_OFF ) | -PHY_M_LED_MO_100 (MO_LED_OFF ) | -PHY_M_LED_MO_1000 (MO_LED_OFF ) | -PHY_M_LED_MO_RX (MO_LED_OFF )); - +gm_phy_write (hw, port,PHY_MARV_LED_OVER , + on ?PHY_M_LED_ALL :0 ); } }
drivers/net/sky2.h +25 -28
111 lines not on this page · raw message
Signature · 5 lines
1.4.1 -- Stephen Hemminger <[email protected]>