Skip to contentSkip to conversation

Remove 'volatile' from spinlock_types

PATCH New Art Haas 1 participant 1 message Dec 6, 2006

lore
Share & tools
lore

Art Haas

author
#0 lore raw

PATCH 1/1 Remove 'volatile' from spinlock_types

Hi.

This is a resubmission of patches originally created by Ingo Molnar. The link below is the initial (?) posting of the patch.

http://marc.theaimsgroup.com/?l=linux-kernel&m=115217423929806&w=2

Remove 'volatile' from spinlock_types as it causes GCC to generate bad code (see link) and locking should be used on kernel data.

---

include/asm-i386/spinlock_types.h +2 -2
index 59efe84..4da9345 100644
@@ -6,13 +6,13 @@
 #endif
 
 typedef struct {
-	volatile unsigned int slock;
+	unsigned int slock;
 } raw_spinlock_t;
 
 #define __RAW_SPIN_LOCK_UNLOCKED	{ 1 }
 
 typedef struct {
-	volatile unsigned int lock;
+	unsigned int lock;
 } raw_rwlock_t;
 
 #define __RAW_RW_LOCK_UNLOCKED		{ RW_LOCK_BIAS }
include/asm-x86_64/spinlock_types.h +2 -2
index 59efe84..4da9345 100644
@@ -6,13 +6,13 @@
 #endif
 
 typedef struct {
-	volatile unsigned int slock;
+	unsigned int slock;
 } raw_spinlock_t;
 
 #define __RAW_SPIN_LOCK_UNLOCKED	{ 1 }
 
 typedef struct {
-	volatile unsigned int lock;
+	unsigned int lock;
 } raw_rwlock_t;
 
 #define __RAW_RW_LOCK_UNLOCKED		{ RW_LOCK_BIAS }
Signature · 4 lines
Man once surrendering his reason, has no remaining guard against absurdities
the most monstrous, and like a ship without rudder, is the sport of every wind.

-Thomas Jefferson to James Smith, 1822