Skip to contentSkip to conversation

acpi: add backlight support to the sony_acpi driver (v2)

PATCH In review Alessandro Guido 5 participants 7 messages Nov 27, 2006 – Dec 7, 2006 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 acpi: add backlight support to the sony_acpi driver (v2)

Enable the sony_acpi driver to use the backlight subsysyem for adjusting the monitor brightness. Old way of changing the brightness will be still available for compatibility with existing tools.

---

 Kconfig     |    1 +
 sony_acpi.c |   53 ++++++++++++++++++++++++++++++++++++++++++++++++-----
 2 files changed, 49 insertions(+), 5 deletions(-)
drivers/acpi/Kconfig +1 -0
Index: linux-2.6.18/drivers/acpi/Kconfig
===================================================================
@@ -251,6 +251,7 @@ config ACPI_TOSHIBA
 config ACPI_SONY
 	tristate "Sony Laptop Extras"
 	depends on X86 && ACPI
+	select BACKLIGHT_CLASS_DEVICE
 	default m
 	  ---help---
 	  This mini-driver drives the ACPI SNC device present in the
drivers/acpi/sony_acpi.c +48 -5

108 lines not on this page · raw message

#1 lore raw

Hi!

Quoted 5 lines

Enable the sony_acpi driver to use the backlight subsysyem for adjusting the monitor brightness. Old way of changing the brightness will be still available for compatibility with existing tools.

Looks okay to me. We really want unified interface for backlight.

Pavel

Signature · 1 line
Thanks for all the (sleeping) penguins.
#2 lore raw
Quoted 1 line · Pavel Machek

Looks okay to me. We really want unified interface for backlight.

Then I request some help to get
http://article.gmane.org/gmane.linux.acpi.devel/19792
merged.

Without it, the backlight interface becomes annoying on laptops. Your screen will be powered off when you remove the modules providing the backlight interface. This is not consistent with the needs of laptop backlight devices, or with the behaviour the drivers had before the backlight sysfs support was added.

Signature · 4 lines
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
#3 lore raw

Hi!

Quoted 11 lines
Quoted 1 line

Looks okay to me. We really want unified interface for backlight.

Then I request some help to get
http://article.gmane.org/gmane.linux.acpi.devel/19792
merged.

Without it, the backlight interface becomes annoying on laptops. Your screen will be powered off when you remove the modules providing the backlight interface. This is not consistent with the needs of laptop backlight devices, or with the behaviour the drivers had before the backlight sysfs support was added.

Just retransmit it to akpm and list, and add acked-by headers with people who said patch is okay... that included me IIRC.

Signature · 1 line
Thanks for all the (sleeping) penguins.
#4 lore raw

Its nice to see acpi moving to the backlight api. Will acpi also move to hwmon and led class support ?

Quoted 18 lines · Pavel Machek

Hi!

Quoted 11 lines
Quoted 1 line

Looks okay to me. We really want unified interface for backlight.

Then I request some help to get
http://article.gmane.org/gmane.linux.acpi.devel/19792
merged.

Without it, the backlight interface becomes annoying on laptops. Your screen will be powered off when you remove the modules providing the backlight interface. This is not consistent with the needs of laptop backlight devices, or with the behaviour the drivers had before the backlight sysfs support was added.

Just retransmit it to akpm and list, and add acked-by headers with people who said patch is okay... that included me IIRC.

#5 lore raw

Please don't top-post...

Quoted 2 lines

Its nice to see acpi moving to the backlight api. Will acpi also move to hwmon and led class support ?

It would be nice... ACPI does not drive many leds ... usually ... but creating battery API based on hwmon and moving ACPI battery support to that API would certainly be nice... and I believe it is ongoing work.
Pavel

Quoted 18 lines
Quoted 18 lines

Hi!

Quoted 11 lines
Quoted 1 line

Looks okay to me. We really want unified interface for backlight.

Then I request some help to get
http://article.gmane.org/gmane.linux.acpi.devel/19792
merged.

Without it, the backlight interface becomes annoying on laptops. Your screen will be powered off when you remove the modules providing the backlight interface. This is not consistent with the needs of laptop backlight devices, or with the behaviour the drivers had before the backlight sysfs support was added.

Just retransmit it to akpm and list, and add acked-by headers with people who said patch is okay... that included me IIRC.

Signature · 1 line
Thanks, Sharp!
#6 lore raw

Hello.

Quoted 7 lines · Pavel Machek

Please don't top-post...

Quoted 2 lines

Its nice to see acpi moving to the backlight api. Will acpi also move to hwmon and led class support ?

It would be nice... ACPI does not drive many leds ... usually ...

I work on led class support for ibm-acpi. It's on is way.

regards
Stefan Schmidt