freezer.h uses task_struct fields
Subsystems (3)
PATCH 1/1 freezer.h uses task_struct fields
From: Randy Dunlap <[email protected]>
freezer.h uses task_struct fields so it should include sched.h.
CC [M] fs/jfs/jfs_txnmgr.o
In file included from fs/jfs/jfs_txnmgr.c:49:include/linux/freezer.h: In function 'frozen':include/linux/freezer.h:9: error: dereferencing pointer to incomplete type include/linux/freezer.h:9: error: 'PF_FROZEN' undeclared (first use in this function) include/linux/freezer.h:9: error: (Each undeclared identifier is reported only once include/linux/freezer.h:9: error: for each function it appears in.) include/linux/freezer.h: In function 'freezing':include/linux/freezer.h:17: error: dereferencing pointer to incomplete type include/linux/freezer.h:17: error: 'PF_FREEZE' undeclared (first use in this function) include/linux/freezer.h: In function 'freeze':include/linux/freezer.h:26: error: dereferencing pointer to incomplete type include/linux/freezer.h:26: error: 'PF_FREEZE' undeclared (first use in this function) include/linux/freezer.h: In function 'do_not_freeze':include/linux/freezer.h:34: error: dereferencing pointer to incomplete type include/linux/freezer.h:34: error: 'PF_FREEZE' undeclared (first use in this function) include/linux/freezer.h: In function 'thaw_process':include/linux/freezer.h:43: error: dereferencing pointer to incomplete type include/linux/freezer.h:43: error: 'PF_FROZEN' undeclared (first use in this function) include/linux/freezer.h:44: warning: implicit declaration of function 'wake_up_process' include/linux/freezer.h: In function 'frozen_process':include/linux/freezer.h:55: error: dereferencing pointer to incomplete type include/linux/freezer.h:55: error: dereferencing pointer to incomplete type include/linux/freezer.h:55: error: 'PF_FREEZE' undeclared (first use in this function) include/linux/freezer.h:55: error: 'PF_FROZEN' undeclared (first use in this function) fs/jfs/jfs_txnmgr.c: In function 'freezing':include/linux/freezer.h:18: warning: control reaches end of non-void function make[2]: *** [fs/jfs/jfs_txnmgr.o] Error 1
--- include/linux/freezer.h | 2 ++ 1 file changed, 2 insertions(+)
include/linux/freezer.h +2 -0
@@ -1,5 +1,7 @@/* Freezer declarations */ +#include <linux/sched.h> +#ifdef CONFIG_PM /* * Check if a process has been frozen
---
Quoted 24 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
freezer.husestask_structfields so it should includesched.h.CC [M]
fs/jfs/jfs_txnmgr.o
In file included fromfs/jfs/jfs_txnmgr.c:49:include/linux/freezer.h: In function 'frozen':include/linux/freezer.h:9: error: dereferencing pointer to incomplete typeinclude/linux/freezer.h:9: error: 'PF_FROZEN' undeclared (first use in this function)include/linux/freezer.h:9: error: (Each undeclared identifier is reported only onceinclude/linux/freezer.h:9: error: for each function it appears in.)include/linux/freezer.h: In function 'freezing':include/linux/freezer.h:17: error: dereferencing pointer to incomplete typeinclude/linux/freezer.h:17: error: 'PF_FREEZE' undeclared (first use in this function)include/linux/freezer.h: In function 'freeze':include/linux/freezer.h:26: error: dereferencing pointer to incomplete typeinclude/linux/freezer.h:26: error: 'PF_FREEZE' undeclared (first use in this function)include/linux/freezer.h: In function 'do_not_freeze':include/linux/freezer.h:34: error: dereferencing pointer to incomplete typeinclude/linux/freezer.h:34: error: 'PF_FREEZE' undeclared (first use in this function)include/linux/freezer.h: In function 'thaw_process':include/linux/freezer.h:43: error: dereferencing pointer to incomplete typeinclude/linux/freezer.h:43: error: 'PF_FROZEN' undeclared (first use in this function)include/linux/freezer.h:44: warning: implicit declaration of function 'wake_up_process'
Quoted 8 lines
include/linux/freezer.h: In function 'frozen_process':include/linux/freezer.h:55: error: dereferencing pointer to incomplete typeinclude/linux/freezer.h:55: error: dereferencing pointer to incomplete typeinclude/linux/freezer.h:55: error: 'PF_FREEZE' undeclared (first use in this function)include/linux/freezer.h:55: error: 'PF_FROZEN' undeclared (first use in this function)fs/jfs/jfs_txnmgr.c: In function 'freezing':include/linux/freezer.h:18: warning: control reaches end of non-void function make[2]: *** [fs/jfs/jfs_txnmgr.o] Error 1
Defining CONFIG_SMP or CONFIG_PREEMPT masks this problem (at least in jfs), since smp_lock.h will include sched.h when CONFIG_LOCK_KERNEL is defined, and smp_lock.h happens to be included by jfs_txngmr.c before freezer.h.
Quoted 2 lines
Signed-off-by Randy Dunlap <[email protected]>
Quoted 16 lines
--- include/linux/freezer.h | 2 ++ 1 file changed, 2 insertions(+)include/linux/freezer.h +2
-0@@ -1,5 +1,7 @@/* Freezer declarations */ +#include <linux/sched.h> +#ifdef CONFIG_PM /* * Check if a process has been frozen
Sorry. I had a misconfiguration in my mail client. My correct address is [email protected], not [email protected]...
Thanks,
Shaggy
Signature · 2 lines
David Kleikamp IBM Linux Technology Center
Quoted 15 lines · On Fri, 08 Dec 2006 08:31:11 -0600 Dave Kleikamp <[email protected]>…
Quoted 8 lines
include/linux/freezer.h: In function 'frozen_process':include/linux/freezer.h:55: error: dereferencing pointer to incomplete typeinclude/linux/freezer.h:55: error: dereferencing pointer to incomplete typeinclude/linux/freezer.h:55: error: 'PF_FREEZE' undeclared (first use in this function)include/linux/freezer.h:55: error: 'PF_FROZEN' undeclared (first use in this function)fs/jfs/jfs_txnmgr.c: In function 'freezing':include/linux/freezer.h:18: warning: control reaches end of non-void function make[2]: *** [fs/jfs/jfs_txnmgr.o] Error 1Defining
CONFIG_SMPorCONFIG_PREEMPTmasks this problem (at least in jfs), sincesmp_lock.hwill includesched.hwhenCONFIG_LOCK_KERNELis defined, andsmp_lock.hhappens to be included byjfs_txngmr.cbeforefreezer.h.Quoted 1 line
Quoted 3 lines
Quoted 1 line
Signed-off-by Randy Dunlap <[email protected]>Acked-by Dave Kleikamp <[email protected]>
OK, thanks guys. This is the sort of patch which I like to put through a decent round of cross-compilation testing, so it's unlikely to appear in mainline for 2-3 days.