ucb1400_ts depends SND_AC97_BUS
Subsystems (4)
PATCH 1/1 ucb1400_ts depends SND_AC97_BUS
From: Randy Dunlap <[email protected]>
This driver is an AC97 codec according to its help text. However, if SOUND is disabled, the "select SND_AC97_BUS" still inserts that into the .config file:
#
# Sound
#
# CONFIG_SOUND is not setCONFIG_SND_AC97_BUS=m
Even if the config software followed dependency chains on selects, we should try to limit usage of "select" to library-type code that is needed (e.g., CRC functions) instead of bus-type support.
--- drivers/input/touchscreen/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/input/touchscreen/Kconfig +1 -1
@@ -146,7 +146,7 @@ config TOUCHSCREEN_TOUCHWIN config TOUCHSCREEN_UCB1400 tristate "Philips UCB1400 touchscreen" - select SND_AC97_BUS + depends on SND_AC97_BUS help This enables support for the Philips UCB1400 touchscreen interface. The UCB1400 is an AC97 audio codec. The touchscreen interface
---
Quoted 6 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
This driver is an AC97 codec according to its help text. However, if SOUND is disabled, the "select
SND_AC97_BUS" still inserts that into the .config file:
Quoted 6 lines
#
# Sound
#
#CONFIG_SOUNDis not setCONFIG_SND_AC97_BUS=m
I consider this abug in kconfig - users of "select" should not know full dependency chain for selected symbol.
Quoted 5 lines
Even if the config software followed dependency chains on selects, we should try to limit usage of "select" to library-type code that is needed (e.g., CRC functions) instead of bus-type support.
I do not agree here - the way our directory structure is laid out "sound" comes after "Input device support" menuconfig entry. Your patch makes user go back and forth in menuconfig, which is awkward. I think using select is fine when an option depends on something down the stream. If user already had a chance to select necessary option then using "depends on" is preferred.
Signature · 1 line
Dmitry
Quoted 14 lines · On Sat, 9 Dec 2006 21:50:01 -0500 Dmitry Torokhov wrote:
Quoted 6 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
This driver is an AC97 codec according to its help text. However, if SOUND is disabled, the "select
SND_AC97_BUS" still inserts that into the .config file:Quoted 6 lines
#
# Sound
#
#CONFIG_SOUNDis not setCONFIG_SND_AC97_BUS=m
Quoted 2 lines
I consider this abug in kconfig - users of "select" should not know full dependency chain for selected symbol.
Seems that I've heard that somewhere else.
so I agree with that part.
Quoted 6 lines
Quoted 5 lines
Even if the config software followed dependency chains on selects, we should try to limit usage of "select" to library-type code that is needed (e.g., CRC functions) instead of bus-type support.
Quoted 6 lines
I do not agree here - the way our directory structure is laid out "sound" comes after "Input device support" menuconfig entry. Your patch makes user go back and forth in menuconfig, which is awkward. I think using select is fine when an option depends on something down the stream. If user already had a chance to select necessary option then using "depends on" is preferred.
Traversing the menus is not difficult.
(It's easier in xconfig or gconfig than menuconfig IMO, but not a big deal in any of them.)
Anyway, are you saying that the only fix for this build error is to fix *config to handle select dependencies?
or could propose another way to handle the build error?
Thanks,
---
~Randy
Quoted 35 lines · Randy Dunlap
Quoted 14 lines · On Sat, 9 Dec 2006 21:50:01 -0500 Dmitry Torokhov wrote:
Quoted 6 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
This driver is an AC97 codec according to its help text. However, if SOUND is disabled, the "select
SND_AC97_BUS" still inserts that into the .config file:Quoted 6 lines
#
# Sound
#
#CONFIG_SOUNDis not setCONFIG_SND_AC97_BUS=mQuoted 2 lines
I consider this abug in kconfig - users of "select" should not know full dependency chain for selected symbol.
Seems that I've heard that somewhere else.
so I agree with that part.Quoted 6 lines
Quoted 5 lines
Even if the config software followed dependency chains on selects, we should try to limit usage of "select" to library-type code that is needed (e.g., CRC functions) instead of bus-type support.
Quoted 6 lines
I do not agree here - the way our directory structure is laid out "sound" comes after "Input device support" menuconfig entry. Your patch makes user go back and forth in menuconfig, which is awkward. I think using select is fine when an option depends on something down the stream. If user already had a chance to select necessary option then using "depends on" is preferred.
Quoted 4 lines
Traversing the menus is not difficult.
(It's easier in xconfig or gconfig than menuconfig IMO, but not a big deal in any of them.)
I agree but many people use menuconfig and may not even be aware of a driver if it is hidden because facility it depends on is not selected. The same with oldconfig - unless you are closely monitor all changelogs (I for example don't, I just pull from Linus) you would not even get prompted for UCB1400 if you do not have sound enabled.
Quoted 4 lines
Anyway, are you saying that the only fix for this build error is to fix *config to handle select dependencies?
or could propose another way to handle the build error?
Would not adding "select SOUND" fix it? We could use it as a bandaid until kconfig os fixed.
Signature · 1 line
Dmitry
Quoted 48 lines · Dmitry Torokhov
Quoted 35 lines · Randy Dunlap
Quoted 14 lines · On Sat, 9 Dec 2006 21:50:01 -0500 Dmitry Torokhov wrote:
Quoted 6 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
This driver is an AC97 codec according to its help text. However, if SOUND is disabled, the "select
SND_AC97_BUS" still inserts that into the .config file:Quoted 6 lines
#
# Sound
#
#CONFIG_SOUNDis not setCONFIG_SND_AC97_BUS=mQuoted 2 lines
I consider this abug in kconfig - users of "select" should not know full dependency chain for selected symbol.
Seems that I've heard that somewhere else.
so I agree with that part.Quoted 6 lines
Quoted 5 lines
Even if the config software followed dependency chains on selects, we should try to limit usage of "select" to library-type code that is needed (e.g., CRC functions) instead of bus-type support.
Quoted 6 lines
I do not agree here - the way our directory structure is laid out "sound" comes after "Input device support" menuconfig entry. Your patch makes user go back and forth in menuconfig, which is awkward. I think using select is fine when an option depends on something down the stream. If user already had a chance to select necessary option then using "depends on" is preferred.
Quoted 4 lines
Traversing the menus is not difficult.
(It's easier in xconfig or gconfig than menuconfig IMO, but not a big deal in any of them.)I agree but many people use menuconfig and may not even be aware of a driver if it is hidden because facility it depends on is not selected. The same with oldconfig - unless you are closely monitor all changelogs (I for example don't, I just pull from Linus) you would not even get prompted for UCB1400 if you do not have sound enabled.
Quoted 7 lines
Quoted 4 lines
Anyway, are you saying that the only fix for this build error is to fix *config to handle select dependencies?
or could propose another way to handle the build error?Would not adding "select SOUND" fix it? We could use it as a bandaid until kconfig os fixed.
Please consider what SND_CONFIG_AC97_BUS corresponds to. It is sound/pci/ac97/ac97_bus.c and if you look into this file you'll see that it is perfectly buildable even if sound is entirely configured out, just like some lib code would be.
Nicolas
Quoted 55 lines · On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
Quoted 53 lines · Dmitry Torokhov
Quoted 35 lines · Randy Dunlap
Quoted 14 lines · On Sat, 9 Dec 2006 21:50:01 -0500 Dmitry Torokhov wrote:
Quoted 6 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
This driver is an AC97 codec according to its help text. However, if SOUND is disabled, the "select
SND_AC97_BUS" still inserts that into the .config file:Quoted 6 lines
#
# Sound
#
#CONFIG_SOUNDis not setCONFIG_SND_AC97_BUS=mQuoted 2 lines
I consider this abug in kconfig - users of "select" should not know full dependency chain for selected symbol.
Seems that I've heard that somewhere else.
so I agree with that part.Quoted 6 lines
Quoted 5 lines
Even if the config software followed dependency chains on selects, we should try to limit usage of "select" to library-type code that is needed (e.g., CRC functions) instead of bus-type support.
Quoted 6 lines
I do not agree here - the way our directory structure is laid out "sound" comes after "Input device support" menuconfig entry. Your patch makes user go back and forth in menuconfig, which is awkward. I think using select is fine when an option depends on something down the stream. If user already had a chance to select necessary option then using "depends on" is preferred.
Quoted 4 lines
Traversing the menus is not difficult.
(It's easier in xconfig or gconfig than menuconfig IMO, but not a big deal in any of them.)I agree but many people use menuconfig and may not even be aware of a driver if it is hidden because facility it depends on is not selected. The same with oldconfig - unless you are closely monitor all changelogs (I for example don't, I just pull from Linus) you would not even get prompted for UCB1400 if you do not have sound enabled.
Quoted 4 lines
Anyway, are you saying that the only fix for this build error is to fix *config to handle select dependencies?
or could propose another way to handle the build error?
Quoted 7 lines
Quoted 2 lines
Would not adding "select SOUND" fix it? We could use it as a bandaid until kconfig os fixed.
Please consider what
SND_CONFIG_AC97_BUScorresponds to. It issound/pci/ac97/ac97_bus.cand if you look into this file you'll see that it is perfectly buildable even if sound is entirely configured out, just like some lib code would be.
OK. Should it (CONFIG_SND_AC97_BUS -> sound/pci/ac97/ac97_bus.c) be buildable when sound is disabled?
If so, where should it be moved to (since afaik, make won't even descend into sound/ if SOUND=n; I don't see that changing any time soon).
---
~Randy
Quoted 9 lines · Randy Dunlap
Quoted 4 lines · On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
Please consider what
SND_CONFIG_AC97_BUScorresponds to. It issound/pci/ac97/ac97_bus.cand if you look into this file you'll see that it is perfectly buildable even if sound is entirely configured out, just like some lib code would be.OK. Should it (
CONFIG_SND_AC97_BUS->sound/pci/ac97/ac97_bus.c) be buildable when sound is disabled?
Yes.
Quoted 3 lines
If so, where should it be moved to (since afaik, make won't even descend into
sound/if SOUND=n; I don't see that changing any time soon).
What about this patch?
----- >8
Subject: break config ordering/dependency between UCB1400 touchscreen driver and sound subsystem
Commit 2d4ba4a3b9aef95d328d74a17ae84f8d658059e2 introduced a dependency that was never meant to exist when the ac97_bus.c module was created. Move ac97_bus.c up the directory hierarchy to make sure it is built when selected even if sound is configured out so things work as originally expected.
---
drivers/input/touchscreen/Kconfig +1 -1
@@ -146,7 +146,7 @@ config TOUCHSCREEN_TOUCHWIN config TOUCHSCREEN_UCB1400 tristate "Philips UCB1400 touchscreen" - depends on SND_AC97_BUS + select AC97_BUS help This enables support for the Philips UCB1400 touchscreen interface. The UCB1400 is an AC97 audio codec. The touchscreen interface
sound/Kconfig +8 -0
@@ -93,4 +93,12 @@ endmenu endif +config AC97_BUS + tristate + help + This is used to avoid config and link hard dependencies between the + sound subsystem and other function drivers completely unrelated to + sound although they're sharing the AC97 bus. Concerned drivers + should "select" this. + endmenu
sound/Makefile +3 -0
@@ -8,6 +8,9 @@ obj-$(CONFIG_DMASOUND) += oss/ obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/ obj-$(CONFIG_SND_AOA) += aoa/ +# This one must be compilable even if sound is configured out +obj-$(CONFIG_AC97_BUS) += ac97_bus.o + ifeq ($(CONFIG_SND),y) obj-y += last.o endif
sound/ac97_bus.c new file +72 -0
72 lines not on this page · raw message
sound/drivers/Kconfig +1 -5
@@ -26,11 +26,7 @@ config SND_VX_LIB config SND_AC97_CODEC tristate select SND_PCM - select SND_AC97_BUS - -config SND_AC97_BUS - tristate - + select AC97_BUS config SND_DUMMY tristate "Dummy (/dev/null) soundcard"
sound/pci/ac97/Makefile +0 -2
@@ -10,11 +10,9 @@ snd-ac97-codec-objs += ac97_proc.o endif snd-ak4531-codec-objs := ak4531_codec.o -snd-ac97-bus-objs := ac97_bus.o # Toplevel Module Dependency obj-$(CONFIG_SND_AC97_CODEC) += snd-ac97-codec.o obj-$(CONFIG_SND_ENS1370) += snd-ak4531-codec.o -obj-$(CONFIG_SND_AC97_BUS) += snd-ac97-bus.o obj-m := $(sort $(obj-m))
sound/pci/ac97/ac97_bus.c deleted +0 -72
72 lines not on this page · raw message
Quoted 12 lines · On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote:
Quoted 9 lines · Randy Dunlap
Quoted 4 lines · On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
Please consider what
SND_CONFIG_AC97_BUScorresponds to. It issound/pci/ac97/ac97_bus.cand if you look into this file you'll see that it is perfectly buildable even if sound is entirely configured out, just like some lib code would be.OK. Should it (
CONFIG_SND_AC97_BUS->sound/pci/ac97/ac97_bus.c) be buildable when sound is disabled?
Quoted 7 lines
Yes.
Quoted 3 lines
If so, where should it be moved to (since afaik, make won't even descend into
sound/if SOUND=n; I don't see that changing any time soon).What about this patch?
About all I can say is that it builds as expected...
Quoted 10 lines
----- >8
Subject: break config ordering/dependency between UCB1400 touchscreen driver and sound subsystemCommit
2d4ba4a3b9aef95d328d74a17ae84f8d658059e2introduced a dependency that was never meant to exist when theac97_bus.cmodule was created. Moveac97_bus.cup the directory hierarchy to make sure it is built when selected even if sound is configured out so things work as originally expected.Signed-off-by Nicolas Pitre <[email protected]>
---
~Randy
Quoted 12 lines · On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote:
Quoted 9 lines · Randy Dunlap
Quoted 4 lines · On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
Please consider what
SND_CONFIG_AC97_BUScorresponds to. It issound/pci/ac97/ac97_bus.cand if you look into this file you'll see that it is perfectly buildable even if sound is entirely configured out, just like some lib code would be.OK. Should it (
CONFIG_SND_AC97_BUS->sound/pci/ac97/ac97_bus.c) be buildable when sound is disabled?
Quoted 7 lines
Yes.
Quoted 3 lines
If so, where should it be moved to (since afaik, make won't even descend into
sound/if SOUND=n; I don't see that changing any time soon).What about this patch?
Can we get this patch or some patch into the input tree for linux-next?
Currently ucb1400_core using ac97_bus_type is the #1 build failure in linux-next. In 50 randconfigs today, this was the failure in 20 builds.
Quoted 237 lines
----- >8
Subject: break config ordering/dependency between UCB1400 touchscreen driver and sound subsystemCommit
2d4ba4a3b9aef95d328d74a17ae84f8d658059e2introduced a dependency that was never meant to exist when theac97_bus.cmodule was created. Moveac97_bus.cup the directory hierarchy to make sure it is built when selected even if sound is configured out so things work as originally expected.Signed-off-by Nicolas Pitre <[email protected]>---
drivers/input/touchscreen/Kconfig +1
-1@@ -146,7 +146,7 @@ config TOUCHSCREEN_TOUCHWIN config TOUCHSCREEN_UCB1400 tristate "Philips UCB1400 touchscreen" - depends on SND_AC97_BUS + select AC97_BUS help This enables support for the Philips UCB1400 touchscreen interface. The UCB1400 is an AC97 audio codec. The touchscreen interfacesound/Kconfig +8
-0@@ -93,4 +93,12 @@ endmenu endif +config AC97_BUS + tristate + help + This is used to avoid config and link hard dependencies between the + sound subsystem and other function drivers completely unrelated to + sound although they're sharing the AC97 bus. Concerned drivers + should "select" this. + endmenusound/Makefile +3
-0@@ -8,6 +8,9 @@ obj-$(CONFIG_DMASOUND) += oss/ obj-$(CONFIG_SND) += core/ i2c/ drivers/ isa/ pci/ ppc/ arm/ synth/ usb/ sparc/ parisc/ pcmcia/ mips/ obj-$(CONFIG_SND_AOA) += aoa/ +# This one must be compilable even if sound is configured out +obj-$(CONFIG_AC97_BUS) += ac97_bus.o + ifeq ($(CONFIG_SND),y) obj-y += last.o endifsound/ac97_bus.c new file +72
-0@@ -0,0 +1,72 @@ +/* +* Linux driver model AC97 bus interface +* +* Author: Nicolas Pitre +* Created: Jan 14, 2005 +* Copyright: (C) MontaVista Software Inc. +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License as published by +* the Free Software Foundation; either version 2 of the License, or +* (at your option) any later version. +*/ + +#include <linux/module.h> +#include <linux/init.h> +#include <linux/device.h> +#include <linux/string.h> + +/* +* Let drivers decide whether they want to support given codec from their +* probe method. Drivers have direct access to the struct snd_ac97 structure and may +* decide based on the id field amongst other things. +*/ +static int ac97_bus_match (struct device *dev,struct device_driver *drv) +{ +return 1 ; +} + +static int ac97_bus_suspend (struct device *dev,pm_message_t state) +{ +int ret =0 ; + +if (dev->driver && dev->driver->suspend) + ret = dev->driver->suspend (dev, state); + +return ret; +} + +static int ac97_bus_resume (struct device *dev) +{ +int ret =0 ; + +if (dev->driver && dev->driver->resume) + ret = dev->driver->resume (dev); + +return ret; +} + +struct bus_type ac97_bus_type = { + .name ="ac97" , + .match = ac97_bus_match, + .suspend = ac97_bus_suspend, + .resume = ac97_bus_resume, +}; + +static int __init ac97_bus_init (void ) +{ +return bus_register (&ac97_bus_type); +} + +subsys_initcall (ac97_bus_init); + +static void __exit ac97_bus_exit(void) +{ +bus_unregister (&ac97_bus_type); +} + +module_exit (ac97_bus_exit); + +EXPORT_SYMBOL (ac97_bus_type); + +MODULE_LICENSE ("GPL" );sound/drivers/Kconfig +1
-5@@ -26,11 +26,7 @@ config SND_VX_LIB config SND_AC97_CODEC tristate select SND_PCM - select SND_AC97_BUS - -config SND_AC97_BUS - tristate - + select AC97_BUS config SND_DUMMY tristate "Dummy (/dev/null) soundcard"sound/pci/ac97/Makefile +0
-2@@ -10,11 +10,9 @@ snd-ac97-codec-objs += ac97_proc.o endif snd-ak4531-codec-objs := ak4531_codec.o -snd-ac97-bus-objs := ac97_bus.o # Toplevel Module Dependency obj-$(CONFIG_SND_AC97_CODEC) += snd-ac97-codec.o obj-$(CONFIG_SND_ENS1370) += snd-ak4531-codec.o -obj-$(CONFIG_SND_AC97_BUS) += snd-ac97-bus.o obj-m := $(sort $(obj-m))sound/pci/ac97/ac97_bus.c deleted +0
-63@@ -1,72 +0,0 @@ -/* -* Linux driver model AC97 bus interface -* -* Author: Nicolas Pitre -* Created: Jan 14, 2005 -* Copyright: (C) MontaVista Software Inc. -* -* This program is free software; you can redistribute it and/or modify -* it under the terms of the GNU General Public License as published by -* the Free Software Foundation; either version 2 of the License, or -* (at your option) any later version. -*/ - -#include <linux/module.h> -#include <linux/init.h> -#include <linux/device.h> -#include <linux/string.h> - -/* -* Let drivers decide whether they want to support given codec from their -* probe method. Drivers have direct access to the struct snd_ac97 structure and may -* decide based on the id field amongst other things. -*/ -static int ac97_bus_match (struct device *dev,struct device_driver *drv) -{ -return 1 ; -} - -static int ac97_bus_suspend (struct device *dev,pm_message_t state) -{ -int ret =0 ; - -if (dev->driver && dev->driver->suspend) - ret = dev->driver->suspend (dev, state); - -return ret; -} - -static int ac97_bus_resume (struct device *dev) -{ -int ret =0 ; - -if (dev->driver && dev->driver->resume) - ret = dev->driver->resume (dev); - -return ret; -} - -struct bus_type ac97_bus_type = { - .name ="ac97" , - .match = ac97_bus_match, - .suspend = ac97_bus_suspend, - .resume = ac97_bus_resume, -}; - -static int __init ac97_bus_init (void ) -{ -return bus_register (&ac97_bus_type); -} - -subsys_initcall (ac97_bus_init); - -static void __exit ac97_bus_exit(void)
sound/pci/ac97/ac97_bus.c
Quoted 10 lines
sound/pci/ac97/ac97_bus.c deleted +0
-10-{ -bus_unregister (&ac97_bus_type); -} - -module_exit (ac97_bus_exit); - -EXPORT_SYMBOL (ac97_bus_type); - -MODULE_LICENSE ("GPL" ); -
---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
Quoted 16 lines · Randy Dunlap
Quoted 14 lines · On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote:
Quoted 9 lines · Randy Dunlap
Quoted 4 lines · On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
Please consider what
SND_CONFIG_AC97_BUScorresponds to. It issound/pci/ac97/ac97_bus.cand if you look into this file you'll see that it is perfectly buildable even if sound is entirely configured out, just like some lib code would be.OK. Should it (
CONFIG_SND_AC97_BUS->sound/pci/ac97/ac97_bus.c) be buildable when sound is disabled?Yes.
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
If so, where should it be moved to (since afaik, make won't even descend into
sound/if SOUND=n; I don't see that changing any time soon).What about this patch?
Can we get this patch or some patch into the input tree for linux-next?
This patch is commit e1036502e5263851259d147771226161e5ccc85a and appeared in mainline almost 2 years ago.
Nicolas
Quoted 22 lines · On Fri, 05 Sep 2008 00:37:17 -0400 (EDT) Nicolas Pitre wrote:
Quoted 20 lines · Randy Dunlap
Quoted 18 lines · On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote:
Quoted 9 lines · Randy Dunlap
Quoted 4 lines · On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
Please consider what
SND_CONFIG_AC97_BUScorresponds to. It issound/pci/ac97/ac97_bus.cand if you look into this file you'll see that it is perfectly buildable even if sound is entirely configured out, just like some lib code would be.OK. Should it (
CONFIG_SND_AC97_BUS->sound/pci/ac97/ac97_bus.c) be buildable when sound is disabled?Yes.
Quoted 3 lines
If so, where should it be moved to (since afaik, make won't even descend into
sound/if SOUND=n; I don't see that changing any time soon).
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
What about this patch?
Can we get this patch or some patch into the input tree for linux-next?
This patch is commit
e1036502e5263851259d147771226161e5ccc85aand appeared in mainline almost 2 years ago.
Ack. Sorry about that. Wrong ucb thread.
ucb1400_core still has build errors in linux-next since it uses ac97_bus_type even when CONFIG_SOUND=n.
---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
Quoted 28 lines · Randy Dunlap
Quoted 26 lines · On Fri, 05 Sep 2008 00:37:17 -0400 (EDT) Nicolas Pitre wrote:
Quoted 23 lines · Randy Dunlap
Quoted 12 lines · On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote:
Quoted 9 lines · Randy Dunlap
Quoted 4 lines · On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
Please consider what
SND_CONFIG_AC97_BUScorresponds to. It issound/pci/ac97/ac97_bus.cand if you look into this file you'll see that it is perfectly buildable even if sound is entirely configured out, just like some lib code would be.OK. Should it (
CONFIG_SND_AC97_BUS->sound/pci/ac97/ac97_bus.c) be buildable when sound is disabled?Quoted 7 lines
Yes.
Quoted 3 lines
If so, where should it be moved to (since afaik, make won't even descend into
sound/if SOUND=n; I don't see that changing any time soon).What about this patch?
Can we get this patch or some patch into the input tree for linux-next?
Quoted 7 lines
Quoted 2 lines
This patch is commit
e1036502e5263851259d147771226161e5ccc85aand appeared in mainline almost 2 years ago.Ack. Sorry about that. Wrong ucb thread.
ucb1400_corestill has build errors in linux-next since it usesac97_bus_typeeven whenCONFIG_SOUND=n.
Both sound (AC97) and UCB1400 should be able to select CONFIG_AC97_BUS independently from each other.
And in linux/sound/Makefile one can find this note:
# This one must be compilable even if sound is configured out obj-$(CONFIG_AC97_BUS) += ac97_bus.o
This was fixed 2 years ago. Who broke it this time?
Nicolas
At Fri, 05 Sep 2008 01:09:48 -0400 (EDT),
Quoted 42 lines · Nicolas Pitre
Quoted 28 lines · Randy Dunlap
Quoted 26 lines · On Fri, 05 Sep 2008 00:37:17 -0400 (EDT) Nicolas Pitre wrote:
Quoted 23 lines · Randy Dunlap
Quoted 12 lines · On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote:
Quoted 9 lines · Randy Dunlap
Quoted 4 lines · On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
Please consider what
SND_CONFIG_AC97_BUScorresponds to. It issound/pci/ac97/ac97_bus.cand if you look into this file you'll see that it is perfectly buildable even if sound is entirely configured out, just like some lib code would be.OK. Should it (
CONFIG_SND_AC97_BUS->sound/pci/ac97/ac97_bus.c) be buildable when sound is disabled?Quoted 7 lines
Yes.
Quoted 3 lines
If so, where should it be moved to (since afaik, make won't even descend into
sound/if SOUND=n; I don't see that changing any time soon).What about this patch?
Can we get this patch or some patch into the input tree for linux-next?
Quoted 7 lines
Quoted 2 lines
This patch is commit
e1036502e5263851259d147771226161e5ccc85aand appeared in mainline almost 2 years ago.Ack. Sorry about that. Wrong ucb thread.
ucb1400_corestill has build errors in linux-next since it usesac97_bus_typeeven whenCONFIG_SOUND=n.Both sound (AC97) and UCB1400 should be able to select
CONFIG_AC97_BUSindependently from each other.
Quoted 6 lines
And in linux/sound/Makefile one can find this note:
# This one must be compilable even if sound is configured out obj-$(CONFIG_AC97_BUS) += ac97_bus.oThis was fixed 2 years ago. Who broke it this time?
Oh, it must be me.
Could you check the patch below?
thanks,
Takashi
sound/Kconfig +3 -1
@@ -91,6 +91,9 @@ endif # SOUND_PRIME endif # !M68K +endif # SOUND + +# AC97_BUS is used from both sound and ucb1400 config AC97_BUS tristate help
@@ -99,4 +102,3 @@ config AC97_BUS sound although they're sharing the AC97 bus. Concerned drivers should "select" this. -endif # SOUND
Quoted 44 lines · Takashi Iwai
At Fri, 05 Sep 2008 01:09:48 -0400 (EDT),
Quoted 42 lines · Nicolas Pitre
Quoted 28 lines · Randy Dunlap
Quoted 26 lines · On Fri, 05 Sep 2008 00:37:17 -0400 (EDT) Nicolas Pitre wrote:
Quoted 23 lines · Randy Dunlap
Quoted 12 lines · On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote:
Quoted 9 lines · Randy Dunlap
Quoted 4 lines · On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
Please consider what
SND_CONFIG_AC97_BUScorresponds to. It issound/pci/ac97/ac97_bus.cand if you look into this file you'll see that it is perfectly buildable even if sound is entirely configured out, just like some lib code would be.OK. Should it (
CONFIG_SND_AC97_BUS->sound/pci/ac97/ac97_bus.c) be buildable when sound is disabled?Quoted 7 lines
Yes.
Quoted 3 lines
If so, where should it be moved to (since afaik, make won't even descend into
sound/if SOUND=n; I don't see that changing any time soon).What about this patch?
Can we get this patch or some patch into the input tree for linux-next?
Quoted 7 lines
Quoted 2 lines
This patch is commit
e1036502e5263851259d147771226161e5ccc85aand appeared in mainline almost 2 years ago.Ack. Sorry about that. Wrong ucb thread.
ucb1400_corestill has build errors in linux-next since it usesac97_bus_typeeven whenCONFIG_SOUND=n.Both sound (AC97) and UCB1400 should be able to select
CONFIG_AC97_BUSindependently from each other.
Quoted 8 lines
Quoted 6 lines
And in linux/sound/Makefile one can find this note:
# This one must be compilable even if sound is configured out obj-$(CONFIG_AC97_BUS) += ac97_bus.oThis was fixed 2 years ago. Who broke it this time?
Oh, it must be me.
I think both your patch and the one I previously posted are needed.
Nicolas
At Fri, 05 Sep 2008 10:52:25 -0400 (EDT),
Quoted 49 lines · Nicolas Pitre
Quoted 46 lines · Takashi Iwai
At Fri, 05 Sep 2008 01:09:48 -0400 (EDT),
Quoted 44 lines · Nicolas Pitre
Quoted 28 lines · Randy Dunlap
Quoted 26 lines · On Fri, 05 Sep 2008 00:37:17 -0400 (EDT) Nicolas Pitre wrote:
Quoted 23 lines · Randy Dunlap
Quoted 12 lines · On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote:
Quoted 9 lines · Randy Dunlap
Quoted 4 lines · On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
Please consider what
SND_CONFIG_AC97_BUScorresponds to. It issound/pci/ac97/ac97_bus.cand if you look into this file you'll see that it is perfectly buildable even if sound is entirely configured out, just like some lib code would be.OK. Should it (
CONFIG_SND_AC97_BUS->sound/pci/ac97/ac97_bus.c) be buildable when sound is disabled?Quoted 7 lines
Yes.
Quoted 3 lines
If so, where should it be moved to (since afaik, make won't even descend into
sound/if SOUND=n; I don't see that changing any time soon).What about this patch?
Can we get this patch or some patch into the input tree for linux-next?
Quoted 7 lines
Quoted 2 lines
This patch is commit
e1036502e5263851259d147771226161e5ccc85aand appeared in mainline almost 2 years ago.Ack. Sorry about that. Wrong ucb thread.
ucb1400_corestill has build errors in linux-next since it usesac97_bus_typeeven whenCONFIG_SOUND=n.Both sound (AC97) and UCB1400 should be able to select
CONFIG_AC97_BUSindependently from each other.And in linux/sound/Makefile one can find this note:
Quoted 8 lines
Quoted 6 lines
Quoted 4 lines
# This one must be compilable even if sound is configured out obj-$(CONFIG_AC97_BUS) += ac97_bus.oThis was fixed 2 years ago. Who broke it this time?
Oh, it must be me.
I think both your patch and the one I previously posted are needed.
Could you repost? I can't find it easily now.
thanks,
Takashi
Quoted 5 lines · Takashi Iwai
At Fri, 05 Sep 2008 10:52:25 -0400 (EDT),
Quoted 3 lines · Nicolas Pitre
On Fri, 5 Sep 2008, Takashi Iwai wrote:
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
This was fixed 2 years ago. Who broke it this time?
Oh, it must be me.
I think both your patch and the one I previously posted are needed.
Could you repost? I can't find it easily now.
drivers/input/touchscreen/Kconfig +0 -1
@@ -219,7 +219,6 @@ config TOUCHSCREEN_ATMEL_TSADCC config TOUCHSCREEN_UCB1400 tristate "Philips UCB1400 touchscreen" - select AC97_BUS depends on UCB1400_CORE help This enables support for the Philips UCB1400 touchscreen interface.
drivers/mfd/Kconfig +1 -0
@@ -52,6 +52,7 @@ config HTC_PASIC3 config UCB1400_CORE tristate "Philips UCB1400 Core driver" + select AC97_BUS help This enables support for the Philips UCB1400 core functions. The UCB1400 is an AC97 audio codec.
Nicolas
At Fri, 05 Sep 2008 12:32:32 -0400 (EDT),
Quoted 8 lines · Nicolas Pitre
Quoted 5 lines · Takashi Iwai
At Fri, 05 Sep 2008 10:52:25 -0400 (EDT),
Quoted 3 lines · Nicolas Pitre
On Fri, 5 Sep 2008, Takashi Iwai wrote:
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
This was fixed 2 years ago. Who broke it this time?
Oh, it must be me.
I think both your patch and the one I previously posted are needed.
Could you repost? I can't find it easily now.
Thanks. For linux-next, yes, it's needed. But it's not for 2.6.27.
Meanwhile, my fix should be included in 2.6.27 since it's a regression.
Randy, could you check whether these two patches fix your problem? I'll put my patch to my tree for the next pull request after your confirmation.
Can Nicolas's patch be to input tree, or any other taker?
thanks,
Takashi
Quoted 28 lines
drivers/input/touchscreen/Kconfig +0
-1@@ -219,7 +219,6 @@ config TOUCHSCREEN_ATMEL_TSADCC config TOUCHSCREEN_UCB1400 tristate "Philips UCB1400 touchscreen" - select AC97_BUS depends on UCB1400_CORE help This enables support for the Philips UCB1400 touchscreen interface.drivers/mfd/Kconfig +1
-0@@ -52,6 +52,7 @@ config HTC_PASIC3 config UCB1400_CORE tristate "Philips UCB1400 Core driver" + select AC97_BUS help This enables support for the Philips UCB1400 core functions. The UCB1400 is an AC97 audio codec.Nicolas
Dmitry Torokhov
maintainerQuoted 20 lines · Takashi Iwai
At Fri, 05 Sep 2008 12:32:32 -0400 (EDT),
Quoted 8 lines · Nicolas Pitre
Quoted 5 lines · Takashi Iwai
At Fri, 05 Sep 2008 10:52:25 -0400 (EDT),
Quoted 3 lines · Nicolas Pitre
On Fri, 5 Sep 2008, Takashi Iwai wrote:
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
This was fixed 2 years ago. Who broke it this time?
Oh, it must be me.
I think both your patch and the one I previously posted are needed.
Could you repost? I can't find it easily now.
Thanks. For linux-next, yes, it's needed. But it's not for 2.6.27.
Quoted 9 lines
Meanwhile, my fix should be included in 2.6.27 since it's a regression.
Randy, could you check whether these two patches fix your problem? I'll put my patch to my tree for the next pull request after your confirmation.
Can Nicolas's patch be to input tree, or any other taker?
I'll take it.
Signature · 1 line
Dmitry
At Fri, 5 Sep 2008 14:33:18 -0400,
Quoted 25 lines · Dmitry Torokhov
Quoted 23 lines · Takashi Iwai
At Fri, 05 Sep 2008 12:32:32 -0400 (EDT),
Quoted 8 lines · Nicolas Pitre
Quoted 5 lines · Takashi Iwai
At Fri, 05 Sep 2008 10:52:25 -0400 (EDT),
Quoted 3 lines · Nicolas Pitre
On Fri, 5 Sep 2008, Takashi Iwai wrote:
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line
This was fixed 2 years ago. Who broke it this time?
Oh, it must be me.
I think both your patch and the one I previously posted are needed.
Could you repost? I can't find it easily now.
Thanks. For linux-next, yes, it's needed. But it's not for 2.6.27.
Meanwhile, my fix should be included in 2.6.27 since it's a regression.
Quoted 8 lines
Quoted 6 lines
Randy, could you check whether these two patches fix your problem? I'll put my patch to my tree for the next pull request after your confirmation.
Can Nicolas's patch be to input tree, or any other taker?
I'll take it.
Thanks!
Takashi
Quoted 13 lines · Takashi Iwai
At Fri, 05 Sep 2008 12:32:32 -0400 (EDT),
Quoted 10 lines · Nicolas Pitre
Quoted 8 lines · Takashi Iwai
At Fri, 05 Sep 2008 10:52:25 -0400 (EDT),
Quoted 5 lines · Nicolas Pitre
Quoted 2 lines · Takashi Iwai
Quoted 1 line
This was fixed 2 years ago. Who broke it this time?
Oh, it must be me.
I think both your patch and the one I previously posted are needed.
Could you repost? I can't find it easily now.
Quoted 8 lines
Thanks. For linux-next, yes, it's needed. But it's not for 2.6.27.
Meanwhile, my fix should be included in 2.6.27 since it's a regression.
Randy, could you check whether these two patches fix your problem? I'll put my patch to my tree for the next pull request after your confirmation.
Yes, all fixed/good. Thanks.
Quoted 35 lines
Can Nicolas's patch be to input tree, or any other taker?
thanks,
Takashi
Quoted 28 lines
drivers/input/touchscreen/Kconfig +0
-1@@ -219,7 +219,6 @@ config TOUCHSCREEN_ATMEL_TSADCC config TOUCHSCREEN_UCB1400 tristate "Philips UCB1400 touchscreen" - select AC97_BUS depends on UCB1400_CORE help This enables support for the Philips UCB1400 touchscreen interface.drivers/mfd/Kconfig +1
-0@@ -52,6 +52,7 @@ config HTC_PASIC3 config UCB1400_CORE tristate "Philips UCB1400 Core driver" + select AC97_BUS help This enables support for the Philips UCB1400 core functions. The UCB1400 is an AC97 audio codec.Nicolas
At Fri, 05 Sep 2008 14:09:24 -0700,
Quoted 17 lines · Randy Dunlap
Quoted 15 lines · Takashi Iwai
At Fri, 05 Sep 2008 12:32:32 -0400 (EDT),
Quoted 10 lines · Nicolas Pitre
Quoted 8 lines · Takashi Iwai
At Fri, 05 Sep 2008 10:52:25 -0400 (EDT),
Quoted 5 lines · Nicolas Pitre
Quoted 2 lines · Takashi Iwai
Quoted 1 line
This was fixed 2 years ago. Who broke it this time?
Oh, it must be me.
I think both your patch and the one I previously posted are needed.
Could you repost? I can't find it easily now.
Thanks. For linux-next, yes, it's needed. But it's not for 2.6.27.
Quoted 8 lines
Quoted 6 lines
Meanwhile, my fix should be included in 2.6.27 since it's a regression.
Randy, could you check whether these two patches fix your problem? I'll put my patch to my tree for the next pull request after your confirmation.
Yes, all fixed/good. Thanks.
Thanks for checking!
Takashi
Quoted 28 lines · Randy Dunlap
Quoted 26 lines · On Fri, 05 Sep 2008 00:37:17 -0400 (EDT) Nicolas Pitre wrote:
Quoted 23 lines · Randy Dunlap
Quoted 12 lines · On Sun, 10 Dec 2006 22:55:25 -0500 (EST) Nicolas Pitre wrote:
Quoted 9 lines · Randy Dunlap
Quoted 4 lines · On Sat, 09 Dec 2006 22:17:55 -0500 (EST) Nicolas Pitre wrote:
Please consider what
SND_CONFIG_AC97_BUScorresponds to. It issound/pci/ac97/ac97_bus.cand if you look into this file you'll see that it is perfectly buildable even if sound is entirely configured out, just like some lib code would be.OK. Should it (
CONFIG_SND_AC97_BUS->sound/pci/ac97/ac97_bus.c) be buildable when sound is disabled?Quoted 7 lines
Yes.
Quoted 3 lines
If so, where should it be moved to (since afaik, make won't even descend into
sound/if SOUND=n; I don't see that changing any time soon).What about this patch?
Can we get this patch or some patch into the input tree for linux-next?
Quoted 7 lines
Quoted 2 lines
This patch is commit
e1036502e5263851259d147771226161e5ccc85aand appeared in mainline almost 2 years ago.Ack. Sorry about that. Wrong ucb thread.
ucb1400_corestill has build errors in linux-next since it usesac97_bus_typeeven whenCONFIG_SOUND=n.
What about this?
drivers/input/touchscreen/Kconfig +0 -1
@@ -219,7 +219,6 @@ config TOUCHSCREEN_ATMEL_TSADCC config TOUCHSCREEN_UCB1400 tristate "Philips UCB1400 touchscreen" - select AC97_BUS depends on UCB1400_CORE help This enables support for the Philips UCB1400 touchscreen interface.
drivers/mfd/Kconfig +1 -0
@@ -52,6 +52,7 @@ config HTC_PASIC3 config UCB1400_CORE tristate "Philips UCB1400 Core driver" + select AC97_BUS help This enables support for the Philips UCB1400 core functions. The UCB1400 is an AC97 audio codec.
Nicolas