Skip to contentSkip to conversation

ipc-procfs-sysctl mixups

PATCH In review Randy Dunlap 2 participants 2 messages Dec 9, 2006 Proc sysctl

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipc-procfs-sysctl mixups

From: Randy Dunlap <[email protected]>

When CONFIG_PROC_FS=n and CONFIG_PROC_SYSCTL=n but CONFIG_SYSVIPC=y, we get this build error:

kernel/built-in.o:(.data+0xc38): undefined reference to proc_ipc_doulongvec_minmax' kernel/built-in.o:(.data+0xc88): undefined reference to proc_ipc_doulongvec_minmax' kernel/built-in.o:(.data+0xcd8): undefined reference to proc_ipc_dointvec' kernel/built-in.o:(.data+0xd28): undefined reference to proc_ipc_dointvec' kernel/built-in.o:(.data+0xd78): undefined reference to proc_ipc_dointvec' kernel/built-in.o:(.data+0xdc8): undefined reference to proc_ipc_dointvec' kernel/built-in.o:(.data+0xe18): undefined reference to `proc_ipc_dointvec'
make: *** [vmlinux] Error 1

---
 kernel/sysctl.c |   11 +++++++++++
 1 file changed, 11 insertions(+)
kernel/sysctl.c +11 -0
@@ -2408,6 +2408,17 @@ static int proc_do_ipc_string(ctl_table 
 {
 	return -ENOSYS;
 }
+static int proc_ipc_dointvec(ctl_table *table, int write, struct file *filp,
+		void __user *buffer, size_t *lenp, loff_t *ppos)
+{
+	return -ENOSYS;
+}
+static int proc_ipc_doulongvec_minmax(ctl_table *table, int write,
+		struct file *filp, void __user *buffer,
+		size_t *lenp, loff_t *ppos)
+{
+	return -ENOSYS;
+}
 #endif
 
 int proc_dointvec(ctl_table *table, int write, struct file *filp,

---

Acked-by on v1 1/1
#1 lore raw
Quoted 16 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

When CONFIG_PROC_FS=n and CONFIG_PROC_SYSCTL=n but CONFIG_SYSVIPC=y, we get this build error:

kernel/built-in.o:(.data+0xc38): undefined reference to `proc_ipc_doulongvec_minmax'
kernel/built-in.o:(.data+0xc88): undefined reference to `proc_ipc_doulongvec_minmax'
kernel/built-in.o:(.data+0xcd8): undefined reference to proc_ipc_dointvec' kernel/built-in.o:(.data+0xd28): undefined reference to proc_ipc_dointvec' kernel/built-in.o:(.data+0xd78): undefined reference to proc_ipc_dointvec' kernel/built-in.o:(.data+0xdc8): undefined reference to proc_ipc_dointvec' kernel/built-in.o:(.data+0xe18): undefined reference to `proc_ipc_dointvec'
make: *** [vmlinux] Error 1

Quoted 1 line

Oops. Thanks for catching this.

Eric