Skip to contentSkip to conversation

x86 smp: export smp_num_siblings for oprofile

PATCH In review Randy Dunlap 2 participants 2 messages Dec 9, 2006

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86 smp: export smp_num_siblings for oprofile

From: Randy Dunlap <[email protected]>

oprofile uses smp_num_siblings without testing for CONFIG_X86_HT. I looked at modifying oprofile, but this way is cleaner & simpler and I didn't see a good reason not to just export it when CONFIG_SMP.

WARNING: "smp_num_siblings" [arch/i386/oprofile/oprofile.ko] undefined!

---
 arch/i386/kernel/smpboot.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/i386/kernel/smpboot.c +1 -1
@@ -69,7 +69,7 @@ static int __devinitdata smp_b_stepping;
 
 /* Number of siblings per CPU package */
 int smp_num_siblings = 1;
-#ifdef CONFIG_X86_HT
+#ifdef CONFIG_SMP
 EXPORT_SYMBOL(smp_num_siblings);
 #endif
 

---

#1 lore raw
Quoted 16 lines · On Sat, 9 Dec 2006 00:34:24 -0800 Randy Dunlap <[email protected]> wrote:

From: Randy Dunlap <[email protected]>

oprofile uses smp_num_siblings without testing for CONFIG_X86_HT. I looked at modifying oprofile, but this way is cleaner & simpler and I didn't see a good reason not to just export it when CONFIG_SMP.

WARNING: "smp_num_siblings" [arch/i386/oprofile/oprofile.ko] undefined!

---
 arch/i386/kernel/smpboot.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

arch/i386/kernel/smpboot.c static int __devinitdata smp_b_stepping; · line 74

Quoted 7 lines
arch/i386/kernel/smpboot.c +1 -1
@@ -69,7 +69,7 @@ static int __devinitdata smp_b_stepping;
 
 /* Number of siblings per CPU package */
 int smp_num_siblings = 1;
-#ifdef CONFIG_X86_HT
+#ifdef CONFIG_SMP
 EXPORT_SYMBOL(smp_num_siblings);
 #endif

smpboot.c isn't compiled if CONFIG_SMP=n, so I'll just remove the ifdef, thanks.