Make lm70_remove a __devexit function
PATCH 1/1 Make lm70_remove a __devexit function
Saves a few bytes on the module.
Signed-off-by Ralf Baechle <ralf at linux-mips.org>
drivers/hwmon/lm70.c +1 -1
@@ -126,7 +126,7 @@ out_dev_reg_failed:return status; } -static int __exit lm70_remove(struct spi_device *spi) +static int __devexit lm70_remove(struct spi_device *spi) {struct lm70 *p_lm70 =dev_get_drvdata (&spi->dev);
Hi Ralf,
Quoted 9 lines · Ralf Baechle
Saves a few bytes on the module.
Signed-off-by Ralf Baechle <ralf at linux-mips.org>drivers/hwmon/lm70.c +0
-0
drivers/hwmon/lm70.c out_dev_reg_failed: · line 132
Quoted 8 lines
drivers/hwmon/lm70.c +1
-1@@ -126,7 +126,7 @@ out_dev_reg_failed:return status; } -static int __exit lm70_remove(struct spi_device *spi) +static int __devexit lm70_remove(struct spi_device *spi) {struct lm70 *p_lm70 =dev_get_drvdata (&spi->dev);
You're not actually saving memory with this change, as __devexit is resolved to either __exit (i.e. nothing changes) or nothing (i.e. the code is now always compiled in.) This is a bugfix though as currently the code may be striped away while the driver still holds a pointer to it.
Good catch, applied (with a different header comment), thanks.
Signature · 1 line
Jean Delvare