Skip to contentSkip to conversation

usblp: Add serial number to device ID

PATCH New Dirk Eibach 1 participant 1 message Dec 12, 2006

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usblp: Add serial number to device ID

I noticed that some USB-printers, e.g. Canon PIXMA iP3000 don't add their serial number to the IEEE-1284 device ID string as expected by userspace apps like cups.
Because of this, connecting multiple printers of the same type to a system does not work properly.

This patch adds the usb serial number to the device ID if it is left out by the printer.

This patch applies to kernel 2.6.18.

---

drivers/usb/class/usblp.c +12 -0
@@ -1134,6 +1134,18 @@ static int usblp_cache_device_id_string(
 		length = USBLP_DEVICE_ID_SIZE - 1;
 	usblp->device_id_string[length] = '\0';
 
+	/* Insert serial number into the device ID string if the printer
+	 * is braindead enough to leave it out. */
+	if ( (usblp->dev->serial)
+		&& (length + strlen(usblp->dev->serial) + 6 < USBLP_DEVICE_ID_SIZE)
+		&& !strstr(usblp->device_id_string+2, "SERN:")
+		&& !strstr(usblp->device_id_string+2, "SER:") )
+	{
+		sprintf(usblp->device_id_string+length, "SERN:%s;", usblp->dev->serial);
+		length += 6 + strlen(usblp->dev->serial);
+		*((__be16 *)usblp->device_id_string) = cpu_to_be16(length);
+	}
+
 	dbg("usblp%d Device ID string [len=%d]=\"%s\"",
 		usblp->minor, length, &usblp->device_id_string[2]);