Skip to contentSkip to conversation

Add libraw1394 to buildroot

PATCH New Lars Munch 2 participants 5 messages Dec 12, 2006 – Dec 13, 2006

lore
Share & tools
lore

Lars Munch

author
#0 lore raw

PATCH 1/1 Add libraw1394 to buildroot

Hi all

The attached patch adds libraw1394-1.2.1 to buildroot. libraw1394 is a library for direct access to IEEE 1394 bus.

Please apply.

-- Lars Munch

-------------- next part --------------

package/libraw1394/libraw1394.mk +60 -0
Index: buildroot/package/libraw1394/libraw1394.mk
===================================================================
@@ -0,0 +1,60 @@
+#############################################################
+#
+# libraw1394
+#
+#############################################################
+
+LIBRAW1394_VERSION:=1.2.1
+LIBRAW1394_SOURCE:=libraw1394-$(LIBRAW1394_VERSION).tar.gz
+LIBRAW1394_SITE:=http://www.linux1394.org/dl
+LIBRAW1394_DIR:=$(BUILD_DIR)/libraw1394-$(LIBRAW1394_VERSION)
+
+$(DL_DIR)/$(LIBRAW1394_SOURCE):
+	$(WGET) -P $(DL_DIR) $(LIBRAW1394_SITE)/$(LIBRAW1394_SOURCE)
+
+$(LIBRAW1394_DIR)/.source: $(DL_DIR)/$(LIBRAW1394_SOURCE)
+	$(ZCAT) $(DL_DIR)/$(LIBRAW1394_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
+	touch $(LIBRAW1394_DIR)/.source
+
+$(LIBRAW1394_DIR)/.configured: $(LIBRAW1394_DIR)/.source
+	(cd $(LIBRAW1394_DIR); \
+		$(TARGET_CONFIGURE_OPTS) \
+		CFLAGS="$(TARGET_CFLAGS)" \
+		./configure \
+			--target=$(GNU_TARGET_NAME) \
+			--host=$(GNU_TARGET_NAME) \
+			--build=$(GNU_HOST_NAME) \
+			--prefix=$(STAGING_DIR) \
+	);
+	touch $(LIBRAW1394_DIR)/.configured;
+
+$(LIBRAW1394_DIR)/.compiled: $(LIBRAW1394_DIR)/.configured
+	$(MAKE) -C $(LIBRAW1394_DIR)
+	touch $(LIBRAW1394_DIR)/.compiled
+
+$(STAGING_DIR)/lib/libraw1394.so: $(LIBRAW1394_DIR)/.compiled
+	make -C $(LIBRAW1394_DIR)/src install
+
+$(TARGET_DIR)/usr/lib/libraw1394.so: $(STAGING_DIR)/lib/libraw1394.so
+	cp -dpf $(STAGING_DIR)/lib/libraw1394.so* $(TARGET_DIR)/usr/lib/
+
+libraw1394: uclibc $(TARGET_DIR)/usr/lib/libraw1394.so
+
+libraw1394-source: $(DL_DIR)/$(LIBRAW1394_SOURCE)
+
+libraw1394-clean:
+	rm $(TARGET_DIR)/usr/lib/libraw1394.so*
+	-$(MAKE) -C $(LIBRAW1394_DIR) clean
+
+libraw1394-dirclean:
+	rm -rf $(LIBRAW1394_DIR)
+
+#############################################################
+#
+# Toplevel Makefile options
+#
+#############################################################
+ifeq ($(strip $(BR2_PACKAGE_LIBRAW1394)),y)
+TARGETS+=libraw1394
+endif
+
package/libraw1394/Config.in +11 -0
Index: buildroot/package/libraw1394/Config.in
===================================================================
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_LIBRAW1394
+	bool "libraw1394"
+	default n
+	help
+		Library for direct access to IEEE 1394 bus.
+
+		Through libraw1394/raw1394, applications can directly
+		send to and receive from other nodes without requiring
+		a kernel driver for the protocol in question.
+
+		http://www.linux1394.org/
package/Config.in +1 -0
Index: buildroot/package/Config.in
===================================================================
@@ -73,6 +73,7 @@
 source "package/libmad/Config.in"
 source "package/libpcap/Config.in"
 source "package/libpng/Config.in"
+source "package/libraw1394/Config.in"
 source "package/libsysfs/Config.in"
 source "package/libtool/Config.in"
 source "package/libusb/Config.in"
#1 lore raw

PATCH 1/1 Add libraw1394 to buildroot

Quoted 4 lines · Lars Munch

Hi all

The attached patch adds libraw1394-1.2.1 to buildroot. libraw1394 is a library for direct access to IEEE 1394 bus.

A few comments below..

Quoted 24 lines

Please apply.

-- Lars Munch

Index: buildroot/package/libraw1394/libraw1394.mk
===================================================================

package/libraw1394/libraw1394.mk +12 -0
@@ -0,0 +1,60 @@
+#############################################################
+#
+# libraw1394
+#
+#############################################################
+
+LIBRAW1394_VERSION:=1.2.1
+LIBRAW1394_SOURCE:=libraw1394-$(LIBRAW1394_VERSION).tar.gz
+LIBRAW1394_SITE:=http://www.linux1394.org/dl
+LIBRAW1394_DIR:=$(BUILD_DIR)/libraw1394-$(LIBRAW1394_VERSION)
+
+$(DL_DIR)/$(LIBRAW1394_SOURCE):

package/libraw1394/libraw1394.mk line 22

Quoted 10 lines
package/libraw1394/libraw1394.mk +10 -0
+	$(WGET) -P $(DL_DIR) $(LIBRAW1394_SITE)/$(LIBRAW1394_SOURCE)
+
+$(LIBRAW1394_DIR)/.source: $(DL_DIR)/$(LIBRAW1394_SOURCE)
+	$(ZCAT) $(DL_DIR)/$(LIBRAW1394_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
+	touch $(LIBRAW1394_DIR)/.source
+
+$(LIBRAW1394_DIR)/.configured: $(LIBRAW1394_DIR)/.source
+	(cd $(LIBRAW1394_DIR); \
+		$(TARGET_CONFIGURE_OPTS) \
+		CFLAGS="$(TARGET_CFLAGS)" \

Please make sure to use the HOSTCC and/or HOSTCXX the user gave us. I don't have plain "gcc" nor "g++", but have to specify make HOSTCC=... HOSTCXX=...
so packages that need the host-compiler pickup the right compiler.

I didn't look if libraw1394 is umong these packages, so this might not apply for this particular package. Please double-check.

Quoted 15 lines
package/libraw1394/libraw1394.mk +15 -0
+		./configure \
+			--target=$(GNU_TARGET_NAME) \
+			--host=$(GNU_TARGET_NAME) \
+			--build=$(GNU_HOST_NAME) \
+			--prefix=$(STAGING_DIR) \
+	);
+	touch $(LIBRAW1394_DIR)/.configured;
+
+$(LIBRAW1394_DIR)/.compiled: $(LIBRAW1394_DIR)/.configured
+	$(MAKE) -C $(LIBRAW1394_DIR)
+	touch $(LIBRAW1394_DIR)/.compiled
+
+$(STAGING_DIR)/lib/libraw1394.so: $(LIBRAW1394_DIR)/.compiled
+	make -C $(LIBRAW1394_DIR)/src install
+

package/libraw1394/libraw1394.mk line 47

Quoted 10 lines
package/libraw1394/libraw1394.mk +10 -0
+$(TARGET_DIR)/usr/lib/libraw1394.so: $(STAGING_DIR)/lib/libraw1394.so
+	cp -dpf $(STAGING_DIR)/lib/libraw1394.so* $(TARGET_DIR)/usr/lib/
+
+libraw1394: uclibc $(TARGET_DIR)/usr/lib/libraw1394.so
+
+libraw1394-source: $(DL_DIR)/$(LIBRAW1394_SOURCE)
+
+libraw1394-clean:
+	rm $(TARGET_DIR)/usr/lib/libraw1394.so*
+	-$(MAKE) -C $(LIBRAW1394_DIR) clean

Can we please settle on the convention that
foo-clean uninstalls itself from the target-dir?

TIA,

author
#2 lore raw

PATCH 1/1 Add libraw1394 to buildroot

Quoted 7 lines · Bernhard Fischer
Quoted 4 lines · Lars Munch

Hi all

The attached patch adds libraw1394-1.2.1 to buildroot. libraw1394 is a library for direct access to IEEE 1394 bus.

A few comments below..

Thanks for the comments.

Quoted 33 lines
Quoted 17 lines

Index: buildroot/package/libraw1394/libraw1394.mk
===================================================================

package/libraw1394/libraw1394.mk +12 -0
@@ -0,0 +1,60 @@
+#############################################################
+#
+# libraw1394
+#
+#############################################################
+
+LIBRAW1394_VERSION:=1.2.1
+LIBRAW1394_SOURCE:=libraw1394-$(LIBRAW1394_VERSION).tar.gz
+LIBRAW1394_SITE:=http://www.linux1394.org/dl
+LIBRAW1394_DIR:=$(BUILD_DIR)/libraw1394-$(LIBRAW1394_VERSION)
+
+$(DL_DIR)/$(LIBRAW1394_SOURCE):

package/libraw1394/libraw1394.mk line 22

Quoted 10 lines
package/libraw1394/libraw1394.mk +10 -0
+	$(WGET) -P $(DL_DIR) $(LIBRAW1394_SITE)/$(LIBRAW1394_SOURCE)
+
+$(LIBRAW1394_DIR)/.source: $(DL_DIR)/$(LIBRAW1394_SOURCE)
+	$(ZCAT) $(DL_DIR)/$(LIBRAW1394_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
+	touch $(LIBRAW1394_DIR)/.source
+
+$(LIBRAW1394_DIR)/.configured: $(LIBRAW1394_DIR)/.source
+	(cd $(LIBRAW1394_DIR); \
+		$(TARGET_CONFIGURE_OPTS) \
+		CFLAGS="$(TARGET_CFLAGS)" \

Please make sure to use the HOSTCC and/or HOSTCXX the user gave us. I don't have plain "gcc" nor "g++", but have to specify make HOSTCC=... HOSTCXX=...
so packages that need the host-compiler pickup the right compiler.

Quoted 2 lines

I didn't look if libraw1394 is umong these packages, so this might not apply for this particular package. Please double-check.

You are right, libraw1394 seems to need a CC_FOR_BUILD="$(HOSTCC)". I will add that.

Quoted 21 lines
Quoted 21 lines
package/libraw1394/libraw1394.mk +20 -0
+		./configure \
+			--target=$(GNU_TARGET_NAME) \
+			--host=$(GNU_TARGET_NAME) \
+			--build=$(GNU_HOST_NAME) \
+			--prefix=$(STAGING_DIR) \
+	);
+	touch $(LIBRAW1394_DIR)/.configured;
+
+$(LIBRAW1394_DIR)/.compiled: $(LIBRAW1394_DIR)/.configured
+	$(MAKE) -C $(LIBRAW1394_DIR)
+	touch $(LIBRAW1394_DIR)/.compiled
+
+$(STAGING_DIR)/lib/libraw1394.so: $(LIBRAW1394_DIR)/.compiled
+	make -C $(LIBRAW1394_DIR)/src install
+
+$(TARGET_DIR)/usr/lib/libraw1394.so: $(STAGING_DIR)/lib/libraw1394.so
+	cp -dpf $(STAGING_DIR)/lib/libraw1394.so* $(TARGET_DIR)/usr/lib/
+
+libraw1394: uclibc $(TARGET_DIR)/usr/lib/libraw1394.so
+
Quoted 8 lines

package/libraw1394/libraw1394.mk line 47

Quoted 5 lines
package/libraw1394/libraw1394.mk +5 -0
+libraw1394-source: $(DL_DIR)/$(LIBRAW1394_SOURCE)
+
+libraw1394-clean:
+	rm $(TARGET_DIR)/usr/lib/libraw1394.so*
+	-$(MAKE) -C $(LIBRAW1394_DIR) clean

Can we please settle on the convention that
foo-clean uninstalls itself from the target-dir?

I am not sure what you mean. It already removes itself from the target-dir?

Thanks for the help
Lars Munch

#3 lore raw

PATCH 1/1 Add libraw1394 to buildroot

Quoted 24 lines · Lars Munch
Quoted 6 lines · Bernhard Fischer
Quoted 4 lines · Lars Munch

Hi all

The attached patch adds libraw1394-1.2.1 to buildroot. libraw1394 is a library for direct access to IEEE 1394 bus.

Quoted 16 lines

package/libraw1394/libraw1394.mk line 47

Quoted 13 lines

+$(STAGING_DIR)/lib/libraw1394.so: $(LIBRAW1394_DIR)/.compiled

package/libraw1394/libraw1394.mk +12 -0
+	make -C $(LIBRAW1394_DIR)/src install
+
+$(TARGET_DIR)/usr/lib/libraw1394.so: $(STAGING_DIR)/lib/libraw1394.so
+	cp -dpf $(STAGING_DIR)/lib/libraw1394.so* $(TARGET_DIR)/usr/lib/
+
+libraw1394: uclibc $(TARGET_DIR)/usr/lib/libraw1394.so
+
+libraw1394-source: $(DL_DIR)/$(LIBRAW1394_SOURCE)
+
+libraw1394-clean:
+	rm $(TARGET_DIR)/usr/lib/libraw1394.so*
+	-$(MAKE) -C $(LIBRAW1394_DIR) clean

Can we please settle on the convention that
foo-clean uninstalls itself from the target-dir?

Quoted 1 line

I am not sure what you mean. It already removes itself from the target-dir?

You're right since you IIRC install into the staging dir and just cp the *.so for the target. Sorry for my sloppy reading.

That may raise the question if and iff then how we want to allow for installing .a into the target to ease e.g. debugging. Generally nothing i want to worry for now, though. :)

Please refresh (the CC_FOR_BUILD) and resend.
TIA and cheers,
Bernhard

author
#4 lore raw

PATCH 1/1 Add libraw1394 to buildroot

Quoted 30 lines · Bernhard Fischer
Quoted 24 lines · Lars Munch
Quoted 6 lines · Bernhard Fischer
Quoted 4 lines · Lars Munch

Hi all

The attached patch adds libraw1394-1.2.1 to buildroot. libraw1394 is a library for direct access to IEEE 1394 bus.

Quoted 16 lines

Review

Quoted 13 lines

+$(STAGING_DIR)/lib/libraw1394.so: $(LIBRAW1394_DIR)/.compiled

(quoted diff) +12 -0
+	make -C $(LIBRAW1394_DIR)/src install
+
+$(TARGET_DIR)/usr/lib/libraw1394.so: $(STAGING_DIR)/lib/libraw1394.so
+	cp -dpf $(STAGING_DIR)/lib/libraw1394.so* $(TARGET_DIR)/usr/lib/
+
+libraw1394: uclibc $(TARGET_DIR)/usr/lib/libraw1394.so
+
+libraw1394-source: $(DL_DIR)/$(LIBRAW1394_SOURCE)
+
+libraw1394-clean:
+	rm $(TARGET_DIR)/usr/lib/libraw1394.so*
+	-$(MAKE) -C $(LIBRAW1394_DIR) clean

Can we please settle on the convention that
foo-clean uninstalls itself from the target-dir?

Quoted 1 line

I am not sure what you mean. It already removes itself from the target-dir?

You're right since you IIRC install into the staging dir and just cp the *.so for the target. Sorry for my sloppy reading.

Quoted 7 lines

That may raise the question if and iff then how we want to allow for installing .a into the target to ease e.g. debugging. Generally nothing i want to worry for now, though. :)

Please refresh (the CC_FOR_BUILD) and resend.
TIA and cheers,
Bernhard

Updated patch attached.

Please apply.

-- Lars Munch

-------------- next part --------------

package/libraw1394/libraw1394.mk +60 -0
Index: buildroot/package/libraw1394/libraw1394.mk
===================================================================
@@ -0,0 +1,60 @@
+#############################################################
+#
+# libraw1394
+#
+#############################################################
+
+LIBRAW1394_VERSION:=1.2.1
+LIBRAW1394_SOURCE:=libraw1394-$(LIBRAW1394_VERSION).tar.gz
+LIBRAW1394_SITE:=http://www.linux1394.org/dl
+LIBRAW1394_DIR:=$(BUILD_DIR)/libraw1394-$(LIBRAW1394_VERSION)
+
+$(DL_DIR)/$(LIBRAW1394_SOURCE):
+	$(WGET) -P $(DL_DIR) $(LIBRAW1394_SITE)/$(LIBRAW1394_SOURCE)
+
+$(LIBRAW1394_DIR)/.source: $(DL_DIR)/$(LIBRAW1394_SOURCE)
+	$(ZCAT) $(DL_DIR)/$(LIBRAW1394_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) -
+	touch $(LIBRAW1394_DIR)/.source
+
+$(LIBRAW1394_DIR)/.configured: $(LIBRAW1394_DIR)/.source
+	(cd $(LIBRAW1394_DIR); \
+		$(TARGET_CONFIGURE_OPTS) CC_FOR_BUILD="$(HOSTCC)" \
+		CFLAGS="$(TARGET_CFLAGS)" \
+		./configure \
+			--target=$(GNU_TARGET_NAME) \
+			--host=$(GNU_TARGET_NAME) \
+			--build=$(GNU_HOST_NAME) \
+			--prefix=$(STAGING_DIR) \
+	);
+	touch $(LIBRAW1394_DIR)/.configured;
+
+$(LIBRAW1394_DIR)/.compiled: $(LIBRAW1394_DIR)/.configured
+	$(MAKE) -C $(LIBRAW1394_DIR)
+	touch $(LIBRAW1394_DIR)/.compiled
+
+$(STAGING_DIR)/lib/libraw1394.so: $(LIBRAW1394_DIR)/.compiled
+	make -C $(LIBRAW1394_DIR)/src install
+
+$(TARGET_DIR)/usr/lib/libraw1394.so: $(STAGING_DIR)/lib/libraw1394.so
+	cp -dpf $(STAGING_DIR)/lib/libraw1394.so* $(TARGET_DIR)/usr/lib/
+
+libraw1394: uclibc $(TARGET_DIR)/usr/lib/libraw1394.so
+
+libraw1394-source: $(DL_DIR)/$(LIBRAW1394_SOURCE)
+
+libraw1394-clean:
+	rm $(TARGET_DIR)/usr/lib/libraw1394.so*
+	-$(MAKE) -C $(LIBRAW1394_DIR) clean
+
+libraw1394-dirclean:
+	rm -rf $(LIBRAW1394_DIR)
+
+#############################################################
+#
+# Toplevel Makefile options
+#
+#############################################################
+ifeq ($(strip $(BR2_PACKAGE_LIBRAW1394)),y)
+TARGETS+=libraw1394
+endif
+
package/libraw1394/Config.in +11 -0
Index: buildroot/package/libraw1394/Config.in
===================================================================
@@ -0,0 +1,11 @@
+config BR2_PACKAGE_LIBRAW1394
+	bool "libraw1394"
+	default n
+	help
+		Library for direct access to IEEE 1394 bus.
+
+		Through libraw1394/raw1394, applications can directly
+		send to and receive from other nodes without requiring
+		a kernel driver for the protocol in question.
+
+		http://www.linux1394.org/
package/Config.in +1 -0
Index: buildroot/package/Config.in
===================================================================
@@ -75,6 +75,7 @@
 source "package/libmad/Config.in"
 source "package/libpcap/Config.in"
 source "package/libpng/Config.in"
+source "package/libraw1394/Config.in"
 source "package/libsysfs/Config.in"
 source "package/libtool/Config.in"
 source "package/libusb/Config.in"